dillon1000/react
Commit
Browse files Remove method name prefix from warnings and errors (#28432)
This pattern is a petpeeve of mine. I don't consider this best practice and so most don't have these prefixes. Very inconsistent. At best this is useless and noisey that you have to parse because the information is also in the stack trace. At worse these are misleading because they're highlighting something internal (like validateDOMNesting) which even suggests an internal bug. Even the ones public to React aren't necessarily what you called because you might be calling a wrapper around it. That would be properly reflected in a stack trace - which can also properly ignore list so that the first stack you see is your callsite, Which might be like `render()` in react-testing-library rather than `createRoot()` for example.
Changed paths39 files
First-parent comparisonpackages/react-dom-bindings/src/client/validateDOMNesting.js ModifiedM packages/react-dom/src/__tests__/ReactCompositeComponent-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOM-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMComponent-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFloat-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMForm-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMLegacyComponentTree-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMLegacyFiber-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMOption-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMRoot-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerLifecycles-test.js ModifiedM packages/react-dom/src/__tests__/ReactFunctionComponent-test.js ModifiedM packages/react-dom/src/__tests__/ReactLegacyMount-test.js ModifiedM packages/react-dom/src/__tests__/ReactLegacyUpdates-test.js ModifiedM packages/react-dom/src/__tests__/ReactServerRendering-test.js ModifiedM packages/react-dom/src/__tests__/ReactTestUtils-test.js ModifiedM packages/react-dom/src/__tests__/ReactUpdates-test.js ModifiedM packages/react-dom/src/__tests__/validateDOMNesting-test.js ModifiedM packages/react-dom/src/client/ReactDOMLegacy.js ModifiedM packages/react-dom/src/client/ReactDOMRoot.js ModifiedM packages/react-dom/src/test-utils/ReactTestUtils.js ModifiedM packages/react-native-renderer/src/legacy-events/EventPluginUtils.js ModifiedM packages/react-native-renderer/src/legacy-events/accumulate.js ModifiedM packages/react-native-renderer/src/legacy-events/accumulateInto.js ModifiedM packages/react-reconciler/src/ReactFiberBeginWork.js ModifiedM packages/react-reconciler/src/ReactFiberClassComponent.js ModifiedM packages/react-reconciler/src/ReactFiberReconciler.js ModifiedM packages/react-reconciler/src/__tests__/ReactLazy-test.internal.js ModifiedM packages/react-server/src/ReactFizzClassComponent.js ModifiedM packages/react-server/src/ReactFizzServer.js ModifiedM packages/react/src/ReactBaseClasses.js ModifiedM packages/react/src/ReactLazy.js ModifiedM packages/react/src/__tests__/ReactCoffeeScriptClass-test.coffee ModifiedM packages/react/src/__tests__/ReactES6Class-test.js ModifiedM packages/react/src/__tests__/ReactElementClone-test.js ModifiedM packages/react/src/__tests__/ReactTypeScriptClass-test.ts ModifiedM packages/react/src/__tests__/createReactClassIntegration-test.js ModifiedM packages/react/src/jsx/ReactJSXElement.js ModifiedM scripts/error-codes/codes.json ModifiedPatch
Files changed
Rendering syntax-highlighted changes…