dillon1000/react

Commit

Replace Implicit Options on SuspenseList with Explicit Options (#33424)

We want to change the defaults for `revealOrder` and `tail` on
SuspenseList. This is an intermediate step to allow experimental users
to upgrade.

To explicitly specify these options I added `revealOrder="independent"`
and `tail="visible"`.

I then added warnings if `undefined` or `null` is passed. You must now
always explicitly specify them. However, semantics are still preserved
for now until the next step.

We also want to change the rendering order of the `children` prop for
`revealOrder="backwards"`. As an intermediate step I first added
`revealOrder="unstable_legacy-backwards"` option. This will only be
temporary until all users can switch to the new `"backwards"` semantics
once we flip it in the next step.

I also clarified the types that the directional props requires iterable
children but not iterable inside of those. Rows with multiple items can
be modeled as explicit fragments.
Browse files
Changed paths18 files
First-parent comparison
M .eslintrc.js ModifiedM fixtures/ssr/src/components/LargeContent.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFizzStaticBrowser-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFizzSuspenseList-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFloat-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerSuspense-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactWrongReturnPointer-test.js ModifiedM packages/react-reconciler/src/ReactChildFiber.js ModifiedM packages/react-reconciler/src/ReactFiberBeginWork.js ModifiedM packages/react-reconciler/src/ReactFiberSuspenseComponent.js ModifiedM packages/react-reconciler/src/__tests__/ReactContextPropagation-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactErrorStacks-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseList-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseyCommitPhase-test.js ModifiedM packages/react-server/src/ReactFizzServer.js ModifiedM packages/shared/ReactTypes.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…