{"body":"We are using it with lazy and the combination Suspense + lazy seems pretty\r\nstable. maxDuration is not but that's only enabled when you're in\r\nConcurrentMode which is still unstable.","parents":["c8ef2feda98d8cc9fb59829148b3db1671ac3b9b"],"patch":"diff --git a\/fixtures\/dom\/src\/components\/fixtures\/suspense\/index.js b\/fixtures\/dom\/src\/components\/fixtures\/suspense\/index.js\nindex b4e9c4dd62..2de6e257cd 100644\n--- a\/fixtures\/dom\/src\/components\/fixtures\/suspense\/index.js\n+++ b\/fixtures\/dom\/src\/components\/fixtures\/suspense\/index.js\n@@ -5,7 +5,7 @@ import TestCase from '..\/..\/TestCase';\n const React = window.React;\n const ReactDOM = window.ReactDOM;\n \n-const Suspense = React.unstable_Suspense;\n+const Suspense = React.Suspense;\n \n let cache = new Set();\n \ndiff --git a\/fixtures\/unstable-async\/suspense\/src\/components\/App.js b\/fixtures\/unstable-async\/suspense\/src\/components\/App.js\nindex b2b6a5378a..8b1cf1acf3 100644\n--- a\/fixtures\/unstable-async\/suspense\/src\/components\/App.js\n+++ b\/fixtures\/unstable-async\/suspense\/src\/components\/App.js\n@@ -1,4 +1,4 @@\n-import React, {lazy, unstable_Suspense as Suspense, PureComponent} from 'react';\n+import React, {lazy, Suspense, PureComponent} from 'react';\n import {unstable_scheduleCallback} from 'scheduler';\n import {\n unstable_trace as trace,\ndiff --git a\/fixtures\/unstable-async\/suspense\/src\/components\/UserPage.js b\/fixtures\/unstable-async\/suspense\/src\/components\/UserPage.js\nindex 6a83fe0a0c..4bcffae7ab 100644\n--- a\/fixtures\/unstable-async\/suspense\/src\/components\/UserPage.js\n+++ b\/fixtures\/unstable-async\/suspense\/src\/components\/UserPage.js\n@@ -1,4 +1,4 @@\n-import React, {unstable_Suspense as Suspense} from 'react';\n+import React, {Suspense} from 'react';\n import {createResource} from 'react-cache';\n import Spinner from '.\/Spinner';\n import {cache} from '..\/cache';\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMServerSuspense-test.internal.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMServerSuspense-test.internal.js\nindex 878f0b8727..93574d8357 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMServerSuspense-test.internal.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMServerSuspense-test.internal.js\n@@ -48,9 +48,9 @@ describe('ReactDOMServerSuspense', () => {\n throw new Promise(() => {});\n };\n const e = await serverRender(\n- }>\n+ }>\n \n- <\/React.unstable_Suspense>,\n+ <\/React.Suspense>,\n );\n \n expect(e.tagName).toBe('DIV');\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMSuspensePlaceholder-test.internal.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMSuspensePlaceholder-test.internal.js\nindex 06b4a8d2db..7e506bbe3a 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMSuspensePlaceholder-test.internal.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMSuspensePlaceholder-test.internal.js\n@@ -23,11 +23,10 @@ describe('ReactDOMSuspensePlaceholder', () => {\n beforeEach(() => {\n jest.resetModules();\n ReactFeatureFlags = require('shared\/ReactFeatureFlags');\n- ReactFeatureFlags.enableSuspense = true;\n React = require('react');\n ReactDOM = require('react-dom');\n ReactCache = require('react-cache');\n- Suspense = React.unstable_Suspense;\n+ Suspense = React.Suspense;\n container = document.createElement('div');\n \n function invalidateCache() {\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactServerRendering-test.js b\/packages\/react-dom\/src\/__tests__\/ReactServerRendering-test.js\nindex b6afd3ebae..b28892df11 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactServerRendering-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactServerRendering-test.js\n@@ -610,7 +610,7 @@ describe('ReactDOMServer', () => {\n \n it('throws for unsupported types on the server', () => {\n expect(() => {\n- ReactDOMServer.renderToString();\n+ ReactDOMServer.renderToString();\n }).toThrow('ReactDOMServer does not yet support Suspense.');\n \n async function fakeImport(result) {\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactServerRenderingHydration-test.js b\/packages\/react-dom\/src\/__tests__\/ReactServerRenderingHydration-test.js\nindex 5d249674bc..2080488a24 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactServerRenderingHydration-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactServerRenderingHydration-test.js\n@@ -470,9 +470,9 @@ describe('ReactDOMServerHydration', () => {\n

\n Hello{' '}\n {this.state.isClient && (\n- \n+ \n \n- <\/React.unstable_Suspense>\n+ <\/React.Suspense>\n )}\n <\/div>\n );\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactIncrementalPerf-test.internal.js b\/packages\/react-reconciler\/src\/__tests__\/ReactIncrementalPerf-test.internal.js\nindex a7df3fd83b..01a462debb 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactIncrementalPerf-test.internal.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactIncrementalPerf-test.internal.js\n@@ -587,9 +587,9 @@ describe('ReactDebugFiberPerf', () => {\n \n ReactNoop.render(\n \n- }>\n+ }>\n \n- <\/React.unstable_Suspense>\n+ <\/React.Suspense>\n <\/Parent>,\n );\n ReactNoop.flush();\n@@ -605,9 +605,9 @@ describe('ReactDebugFiberPerf', () => {\n \n ReactNoop.render(\n \n- \n+ \n \n- <\/React.unstable_Suspense>\n+ <\/React.Suspense>\n <\/Parent>,\n );\n ReactNoop.flush();\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactLazy-test.internal.js b\/packages\/react-reconciler\/src\/__tests__\/ReactLazy-test.internal.js\nindex 0f3aa2d1b6..22155831fb 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactLazy-test.internal.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactLazy-test.internal.js\n@@ -11,7 +11,7 @@ describe('ReactLazy', () => {\n ReactFeatureFlags.debugRenderPhaseSideEffectsForStrictMode = false;\n ReactFeatureFlags.replayFailedUnitOfWorkWithInvokeGuardedCallback = false;\n React = require('react');\n- Suspense = React.unstable_Suspense;\n+ Suspense = React.Suspense;\n lazy = React.lazy;\n ReactTestRenderer = require('react-test-renderer');\n });\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactMemo-test.internal.js b\/packages\/react-reconciler\/src\/__tests__\/ReactMemo-test.internal.js\nindex d6e1cba77c..8105d392bd 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactMemo-test.internal.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactMemo-test.internal.js\n@@ -56,7 +56,7 @@ describe('memo', () => {\n function sharedTests(label, memo) {\n describe(`${label}`, () => {\n it('bails out on props equality', async () => {\n- const {unstable_Suspense: Suspense} = React;\n+ const {Suspense} = React;\n \n function Counter({count}) {\n return ;\n@@ -93,7 +93,7 @@ describe('memo', () => {\n });\n \n it(\"does not bail out if there's a context change\", async () => {\n- const {unstable_Suspense: Suspense} = React;\n+ const {Suspense} = React;\n \n const CountContext = React.createContext(0);\n \n@@ -142,7 +142,7 @@ describe('memo', () => {\n });\n \n it('accepts custom comparison function', async () => {\n- const {unstable_Suspense: Suspense} = React;\n+ const {Suspense} = React;\n \n function Counter({count}) {\n return ;\n@@ -184,7 +184,7 @@ describe('memo', () => {\n });\n \n it('supports non-pure class components', async () => {\n- const {unstable_Suspense: Suspense} = React;\n+ const {Suspense} = React;\n \n class CounterInner extends React.Component {\n static defaultProps = {suffix: '!'};\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspense-test.internal.js b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspense-test.internal.js\nindex 2cdf008d5d..8362ee523d 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspense-test.internal.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspense-test.internal.js\n@@ -23,7 +23,7 @@ describe('ReactSuspense', () => {\n \/\/ JestReact = require('jest-react');\n ReactCache = require('react-cache');\n \n- Suspense = React.unstable_Suspense;\n+ Suspense = React.Suspense;\n \n function invalidateCache() {\n cache = ReactCache.createCache(invalidateCache);\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspensePlaceholder-test.internal.js b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspensePlaceholder-test.internal.js\nindex 8aa144985d..2163725844 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspensePlaceholder-test.internal.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspensePlaceholder-test.internal.js\n@@ -37,7 +37,7 @@ function runPlaceholderTests(suiteLabel, loadReactNoop) {\n \/\/ JestReact = require('jest-react');\n ReactCache = require('react-cache');\n \n- Suspense = React.unstable_Suspense;\n+ Suspense = React.Suspense;\n \n function invalidateCache() {\n cache = ReactCache.createCache(invalidateCache);\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.internal.js b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.internal.js\nindex 5071e52b4b..b36a9a70a4 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.internal.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.internal.js\n@@ -24,7 +24,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n Fragment = React.Fragment;\n ReactNoop = require('react-noop-renderer');\n ReactCache = require('react-cache');\n- Suspense = React.unstable_Suspense;\n+ Suspense = React.Suspense;\n StrictMode = React.StrictMode;\n ConcurrentMode = React.unstable_ConcurrentMode;\n \ndiff --git a\/packages\/react\/src\/React.js b\/packages\/react\/src\/React.js\nindex a1fa6f607b..feaf958b4b 100644\n--- a\/packages\/react\/src\/React.js\n+++ b\/packages\/react\/src\/React.js\n@@ -55,7 +55,7 @@ const React = {\n Fragment: REACT_FRAGMENT_TYPE,\n StrictMode: REACT_STRICT_MODE_TYPE,\n unstable_ConcurrentMode: REACT_CONCURRENT_MODE_TYPE,\n- unstable_Suspense: REACT_SUSPENSE_TYPE,\n+ Suspense: REACT_SUSPENSE_TYPE,\n unstable_Profiler: REACT_PROFILER_TYPE,\n \n createElement: __DEV__ ? createElementWithValidation : createElement,\ndiff --git a\/packages\/react\/src\/__tests__\/ReactProfiler-test.internal.js b\/packages\/react\/src\/__tests__\/ReactProfiler-test.internal.js\nindex 990ba59fbd..85b4cb2d50 100644\n--- a\/packages\/react\/src\/__tests__\/ReactProfiler-test.internal.js\n+++ b\/packages\/react\/src\/__tests__\/ReactProfiler-test.internal.js\n@@ -2228,9 +2228,9 @@ describe('Profiler', () => {\n SchedulerTracing.unstable_trace(interaction.name, mockNow(), () => {\n ReactNoop.render(\n \n- }>\n+ }>\n \n- <\/React.unstable_Suspense>\n+ <\/React.Suspense>\n \n \n <\/React.unstable_Profiler>,\n@@ -2316,11 +2316,11 @@ describe('Profiler', () => {\n () => {\n ReactTestRenderer.create(\n \n- }>\n \n- <\/React.unstable_Suspense>\n+ <\/React.Suspense>\n <\/React.unstable_Profiler>,\n );\n },\n@@ -2370,11 +2370,11 @@ describe('Profiler', () => {\n () => {\n ReactTestRenderer.create(\n \n- }>\n \n- <\/React.unstable_Suspense>\n+ <\/React.Suspense>\n <\/React.unstable_Profiler>,\n );\n },\n@@ -2410,11 +2410,11 @@ describe('Profiler', () => {\n () => {\n renderer = ReactTestRenderer.create(\n \n- }>\n \n- <\/React.unstable_Suspense>\n+ <\/React.Suspense>\n <\/React.unstable_Profiler>,\n {\n unstable_isConcurrent: true,\n@@ -2458,11 +2458,11 @@ describe('Profiler', () => {\n () => {\n renderer = ReactTestRenderer.create(\n \n- }>\n \n- <\/React.unstable_Suspense>\n+ <\/React.Suspense>\n <\/React.unstable_Profiler>,\n {unstable_isConcurrent: true},\n );\n@@ -2497,11 +2497,11 @@ describe('Profiler', () => {\n () => {\n renderer = ReactTestRenderer.create(\n \n- }>\n \n- <\/React.unstable_Suspense>\n+ <\/React.Suspense>\n \n <\/React.unstable_Profiler>,\n );\n@@ -2531,11 +2531,11 @@ describe('Profiler', () => {\n () => {\n renderer.update(\n \n- }>\n \n- <\/React.unstable_Suspense>\n+ <\/React.Suspense>\n \n <\/React.unstable_Profiler>,\n );\n@@ -2593,11 +2593,11 @@ describe('Profiler', () => {\n () => {\n renderer = ReactTestRenderer.create(\n \n- }>\n \n- <\/React.unstable_Suspense>\n+ <\/React.Suspense>\n \n <\/React.unstable_Profiler>,\n {unstable_isConcurrent: true},\n@@ -2631,11 +2631,11 @@ describe('Profiler', () => {\n () => {\n renderer.update(\n \n- }>\n \n- <\/React.unstable_Suspense>\n+ <\/React.Suspense>\n \n <\/React.unstable_Profiler>,\n );\ndiff --git a\/packages\/react\/src\/__tests__\/ReactProfilerDOM-test.internal.js b\/packages\/react\/src\/__tests__\/ReactProfilerDOM-test.internal.js\nindex 998c0c2497..f63cfab515 100644\n--- a\/packages\/react\/src\/__tests__\/ReactProfilerDOM-test.internal.js\n+++ b\/packages\/react\/src\/__tests__\/ReactProfilerDOM-test.internal.js\n@@ -119,11 +119,9 @@ describe('ProfilerDOM', () => {\n const root = ReactDOM.unstable_createRoot(element);\n batch = root.createBatch();\n batch.render(\n- }>\n+ }>\n \n- <\/React.unstable_Suspense>,\n+ <\/React.Suspense>,\n );\n batch.then(\n SchedulerTracing.unstable_wrap(() => {\n","files":[{"path":"fixtures\/dom\/src\/components\/fixtures\/suspense\/index.js","status":"M"},{"path":"fixtures\/unstable-async\/suspense\/src\/components\/App.js","status":"M"},{"path":"fixtures\/unstable-async\/suspense\/src\/components\/UserPage.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMServerSuspense-test.internal.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMSuspensePlaceholder-test.internal.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactServerRendering-test.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactServerRenderingHydration-test.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactIncrementalPerf-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactLazy-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactMemo-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactSuspense-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactSuspensePlaceholder-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.internal.js","status":"M"},{"path":"packages\/react\/src\/React.js","status":"M"},{"path":"packages\/react\/src\/__tests__\/ReactProfiler-test.internal.js","status":"M"},{"path":"packages\/react\/src\/__tests__\/ReactProfilerDOM-test.internal.js","status":"M"}],"commit":{"authoredAt":"2018-10-22T22:40:05-07:00","revision":"d75c69e0cf2a842adc47edab87ca5103411e6949","shortRevision":"d75c69e0cf","authorName":"Sebastian Markbåge","subject":"Remove unstable_ prefix from Suspense (#13922)","authorEmail":"sebastian@calyptus.eu"}}

dillon1000/react

Files changed