dillon1000/react

Commit

Remove internal `act` builds from public modules (#21721)

* Move internal version of act to shared module

No reason to have three different copies of this anymore.

I've left the the renderer-specific `act` entry points because legacy
mode tests need to also be wrapped in `batchedUpdates`. Next, I'll update
the tests to use `batchedUpdates` manually when needed.

* Migrates tests to use internal module directly

Instead of the `unstable_concurrentAct` exports. Now we can drop those
from the public builds.

I put it in the jest-react package since that's where we put our other
testing utilities (like `toFlushAndYield`). Not so much so it can be
consumed publicly (nobody uses that package except us), but so it works
with our build tests.

* Remove unused internal fields

These were used by the old act implementation. No longer needed.
Browse files
Changed paths81 files
First-parent comparison
M packages/jest-react/src/JestReact.js ModifiedR packages/react-dom/src/test-utils/ReactTestUtilsInternalAct.js →packages/jest-react/src/internalAct.js RenamedM packages/react-client/src/__tests__/ReactFlight-test.js ModifiedM packages/react-debug-tools/src/__tests__/ReactHooksInspectionIntegration-test.js ModifiedM packages/react-devtools-shared/src/__tests__/inspectedElement-test.js ModifiedM packages/react-devtools-shared/src/__tests__/storeComponentFilters-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFiberAsync-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMHooks-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMNativeEventHeuristic-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMNestedEvents-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMRoot-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationHooks-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerSelectiveHydration-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerSuspense-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMSuspensePlaceholder-test.js ModifiedM packages/react-dom/src/__tests__/ReactErrorBoundaries-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactUpdates-test.js ModifiedM packages/react-dom/src/__tests__/ReactWrongReturnPointer-test.js ModifiedM packages/react-dom/src/__tests__/utils/ReactDOMServerIntegrationTestUtils.js ModifiedM packages/react-dom/src/client/ReactDOM.js ModifiedM packages/react-dom/src/events/__tests__/DOMPluginEventSystem-test.internal.js ModifiedM packages/react-dom/src/events/plugins/__tests__/ChangeEventPlugin-test.js ModifiedM packages/react-dom/src/events/plugins/__tests__/SimpleEventPlugin-test.js ModifiedM packages/react-dom/src/test-utils/ReactTestUtils.js ModifiedM packages/react-interactions/events/src/dom/create-event-handle/__tests__/useFocusWithin-test.internal.js ModifiedM packages/react-noop-renderer/src/createReactNoop.js ModifiedM packages/react-reconciler/src/ReactFiberReconciler.js ModifiedM packages/react-reconciler/src/ReactFiberReconciler.new.js ModifiedM packages/react-reconciler/src/ReactFiberReconciler.old.js ModifiedM packages/react-reconciler/src/ReactFiberWorkLoop.new.js ModifiedM packages/react-reconciler/src/ReactFiberWorkLoop.old.js ModifiedM packages/react-reconciler/src/__tests__/ReactCPUSuspense-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactCache-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactClassSetStateCallback-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactContextPropagation-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactEffectOrdering-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactExpiration-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactFlushSync-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactHooks-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactHooksWithNoopRenderer-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalScheduling-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalUpdates-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactInterleavedUpdates-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactMemo-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactNoopRendererAct-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactOffscreen-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactSchedulerIntegration-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactSubtreeFlagsWarning-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspense-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseEffectsSemantics-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseFuzz-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseList-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseWithNoopRenderer-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactTransition-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactUpdatePriority-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactUpdaters-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/SchedulingProfiler-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/StrictEffectsMode-test.js ModifiedM packages/react-reconciler/src/__tests__/StrictEffectsModeDefaults-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/useMutableSource-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/useMutableSourceHydration-test.js ModifiedM packages/react-reconciler/src/__tests__/useRef-test.internal.js ModifiedM packages/react-refresh/src/__tests__/ReactFresh-test.js ModifiedM packages/react-refresh/src/__tests__/ReactFreshIntegration-test.js ModifiedM packages/react-server-dom-relay/src/__tests__/ReactFlightDOMRelay-test.internal.js ModifiedM packages/react-server-dom-webpack/src/__tests__/ReactFlightDOM-test.js ModifiedM packages/react-test-renderer/src/ReactTestRenderer.js ModifiedD packages/react/src/IsSomeRendererActing.js DeletedM packages/react/src/ReactSharedInternals.js ModifiedM packages/react/src/__tests__/ReactCoffeeScriptClass-test.coffee ModifiedM packages/react/src/__tests__/ReactES6Class-test.js ModifiedM packages/react/src/__tests__/ReactProfiler-test.internal.js ModifiedM packages/react/src/__tests__/ReactStrictMode-test.internal.js ModifiedM packages/react/src/__tests__/ReactTypeScriptClass-test.ts ModifiedR packages/react/src/__tests__/testDefinitions/ReactDOMTestUtils.d.ts →packages/react/src/__tests__/testDefinitions/ReactInternalAct.d.ts RenamedM packages/react/src/forks/ReactSharedInternals.umd.js ModifiedM packages/use-subscription/src/__tests__/useSubscription-test.js ModifiedM scripts/jest/typescript/preprocessor.js ModifiedM scripts/rollup/bundles.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…