dillon1000/react

Commit

Fixes children when using dangerouslySetInnerHtml in a selected <option> (#13078)

* Fixes children when using dangerouslySetInnerHtml in a selected <option>

This fixes an inadvertent cast of undefined children to an empty string when creating an option tag that will be selected:

```
  <select defaultValue="test">
    <option value='test' dangerouslySetInnerHTML={{ __html: '&rlm; test'}} />
  </select>
```

This causes an invariant error because both children and dangerouslySetInnerHTML are set.

* PR fix and new ReactDOMServerIntegrationForms test

* Account for null case

* Combine test cases into single test

* Add tests for failure cases

* Fix lint
Browse files
Changed paths3 files
First-parent comparison
M packages/react-dom/src/__tests__/ReactDOMSelect-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationForms-test.js ModifiedM packages/react-dom/src/server/ReactPartialRenderer.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…