dillon1000/react

Commit

Fix `findComponentRoot` w/ Unidentified Nodes

The current `ReactInstanceHandles` has a bug where `findComponentRoot` barfs if it comes across a node that was not identified by React (via `ReactID`). This fixes that.

This was always a bug, but it became more apparent once we switched to `data-reactid` because arbitrary `document.createElement`'d nodes are much more likely to have an `id` than they are to have a `data-reactid`.
Browse files
CommitSyncScript authored dbd9d99bcd01849b737f608a8862c4300cbae217 Parent c032743
Changed paths2 files
First-parent comparison
M src/core/ReactInstanceHandles.js ModifiedM src/core/__tests__/ReactInstanceHandles-test.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…