{"files":[{"status":"M","path":"packages\/react-test-renderer\/src\/ReactTestRenderer.js"},{"status":"M","path":"packages\/react-test-renderer\/src\/__tests__\/ReactTestRendererTraversal-test.js"}],"patch":"diff --git a\/packages\/react-test-renderer\/src\/ReactTestRenderer.js b\/packages\/react-test-renderer\/src\/ReactTestRenderer.js\nindex 977a1f5c68..d3ef7aff4f 100644\n--- a\/packages\/react-test-renderer\/src\/ReactTestRenderer.js\n+++ b\/packages\/react-test-renderer\/src\/ReactTestRenderer.js\n@@ -411,6 +411,7 @@ const validWrapperTypes = new Set([\n FunctionalComponent,\n ClassComponent,\n HostComponent,\n+ ForwardRef,\n ]);\n \n class ReactTestInstance {\n@@ -475,6 +476,7 @@ class ReactTestInstance {\n case FunctionalComponent:\n case ClassComponent:\n case HostComponent:\n+ case ForwardRef:\n children.push(wrapFiber(node));\n break;\n case HostText:\n@@ -484,7 +486,6 @@ class ReactTestInstance {\n case ContextProvider:\n case ContextConsumer:\n case Mode:\n- case ForwardRef:\n descend = true;\n break;\n default:\ndiff --git a\/packages\/react-test-renderer\/src\/__tests__\/ReactTestRendererTraversal-test.js b\/packages\/react-test-renderer\/src\/__tests__\/ReactTestRendererTraversal-test.js\nindex 587a094f8a..e6f3909b0b 100644\n--- a\/packages\/react-test-renderer\/src\/__tests__\/ReactTestRendererTraversal-test.js\n+++ b\/packages\/react-test-renderer\/src\/__tests__\/ReactTestRendererTraversal-test.js\n@@ -37,6 +37,7 @@ describe('ReactTestRendererTraversal', () => {\n \n \n <\/ExampleNull>\n+ \n <\/View>\n <\/View>\n );\n@@ -48,13 +49,17 @@ describe('ReactTestRendererTraversal', () => {\n const ExampleFn = props => ;\n const ExampleNull = props => null;\n \n+ const ExampleForwardRef = React.forwardRef((props, ref) => (\n+ \n+ ));\n+\n it('initializes', () => {\n const render = ReactTestRenderer.create();\n const hasFooProp = node => node.props.hasOwnProperty('foo');\n \n \/\/ assert .props, .type and .parent attributes\n const foo = render.root.find(hasFooProp);\n- expect(foo.props.children).toHaveLength(7);\n+ expect(foo.props.children).toHaveLength(8);\n expect(foo.type).toBe(View);\n expect(render.root.parent).toBe(null);\n expect(foo.children[0].parent).toBe(foo);\n@@ -116,14 +121,16 @@ describe('ReactTestRendererTraversal', () => {\n \n expect(() => render.root.findByType(ExampleFn)).not.toThrow(); \/\/ 1 match\n expect(() => render.root.findByType(View)).not.toThrow(); \/\/ 1 match\n+ expect(() => render.root.findByType(ExampleForwardRef)).not.toThrow(); \/\/ 1 match\n \/\/ note: there are clearly multiple in general, but there\n \/\/ is only one being rendered at root node level\n expect(() => render.root.findByType(ExampleNull)).toThrow(); \/\/ 2 matches\n \n expect(render.root.findAllByType(ExampleFn)).toHaveLength(1);\n expect(render.root.findAllByType(View, {deep: false})).toHaveLength(1);\n- expect(render.root.findAllByType(View)).toHaveLength(7);\n+ expect(render.root.findAllByType(View)).toHaveLength(8);\n expect(render.root.findAllByType(ExampleNull)).toHaveLength(2);\n+ expect(render.root.findAllByType(ExampleForwardRef)).toHaveLength(1);\n \n const nulls = render.root.findAllByType(ExampleNull);\n expect(nulls[0].findAllByType(View)).toHaveLength(0);\n@@ -138,17 +145,21 @@ describe('ReactTestRendererTraversal', () => {\n const foo = 'foo';\n const bar = 'bar';\n const baz = 'baz';\n+ const qux = 'qux';\n \n expect(() => render.root.findByProps({foo})).not.toThrow(); \/\/ 1 match\n expect(() => render.root.findByProps({bar})).toThrow(); \/\/ >1 matches\n expect(() => render.root.findByProps({baz})).toThrow(); \/\/ >1 matches\n+ expect(() => render.root.findByProps({qux})).not.toThrow(); \/\/ 1 match\n \n expect(render.root.findAllByProps({foo}, {deep: false})).toHaveLength(1);\n expect(render.root.findAllByProps({bar}, {deep: false})).toHaveLength(5);\n expect(render.root.findAllByProps({baz}, {deep: false})).toHaveLength(2);\n+ expect(render.root.findAllByProps({qux}, {deep: false})).toHaveLength(1);\n \n expect(render.root.findAllByProps({foo})).toHaveLength(2);\n expect(render.root.findAllByProps({bar})).toHaveLength(9);\n expect(render.root.findAllByProps({baz})).toHaveLength(4);\n+ expect(render.root.findAllByProps({qux})).toHaveLength(3);\n });\n });\n","commit":{"authorEmail":"dan.abramov@gmail.com","revision":"e0ca51a85d7c5b01c1efa7edb40080770d508cad","authoredAt":"2018-05-01T19:55:06+01:00","authorName":"Dan Abramov","subject":"Make React.forwardRef() components discoverable by TestRenderer traversal (#12725)","shortRevision":"e0ca51a85d"},"body":"","parents":["7dd4ca2911d742f9b5c457ce2d010432fa2d6578"]}

dillon1000/react

Files changed