{"patch":"diff --git a\/scripts\/fiber\/tests-passing.txt b\/scripts\/fiber\/tests-passing.txt\nindex 5eb43be0ba..b2952dfe3d 100644\n--- a\/scripts\/fiber\/tests-passing.txt\n+++ b\/scripts\/fiber\/tests-passing.txt\n@@ -159,7 +159,6 @@ src\/isomorphic\/classic\/__tests__\/ReactContextValidator-test.js\n * should check child context types\n * should warn (but not error) if getChildContext method is missing\n * should pass parent context if getChildContext method is missing\n-* should only warn about missing getChildContext once per component type\n \n src\/isomorphic\/classic\/class\/__tests__\/ReactBind-test.js\n * Holds reference to instance\ndiff --git a\/src\/isomorphic\/classic\/__tests__\/ReactContextValidator-test.js b\/src\/isomorphic\/classic\/__tests__\/ReactContextValidator-test.js\nindex cd844e9f52..883764e067 100644\n--- a\/src\/isomorphic\/classic\/__tests__\/ReactContextValidator-test.js\n+++ b\/src\/isomorphic\/classic\/__tests__\/ReactContextValidator-test.js\n@@ -294,20 +294,36 @@ describe('ReactContextValidator', () => {\n it('should warn (but not error) if getChildContext method is missing', () => {\n spyOn(console, 'error');\n \n- var MyComponent = React.createClass({\n- childContextTypes: {\n+ class ComponentA extends React.Component {\n+ static childContextTypes = {\n foo: React.PropTypes.string.isRequired,\n- },\n-\n- render: function() {\n+ };\n+ render() {\n return

;\n- },\n- });\n+ }\n+ }\n+ class ComponentB extends React.Component {\n+ static childContextTypes = {\n+ foo: React.PropTypes.string.isRequired,\n+ };\n+ render() {\n+ return

;\n+ }\n+ }\n \n- ReactTestUtils.renderIntoDocument();\n+ ReactTestUtils.renderIntoDocument();\n expectDev(console.error.calls.count()).toBe(1);\n expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toBe(\n- 'Warning: getChildContext() is not defined for MyComponent'\n+ 'Warning: getChildContext() is not defined for ComponentA'\n+ );\n+\n+ \/\/ Warnings should be deduped by component type\n+ ReactTestUtils.renderIntoDocument();\n+ expectDev(console.error.calls.count()).toBe(1);\n+ ReactTestUtils.renderIntoDocument();\n+ expectDev(console.error.calls.count()).toBe(2);\n+ expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(1)[0])).toBe(\n+ 'Warning: getChildContext() is not defined for ComponentB'\n );\n });\n \n@@ -356,38 +372,4 @@ describe('ReactContextValidator', () => {\n expect(childContext.foo).toBe('FOO');\n });\n \n- it('should only warn about missing getChildContext once per component type', () => {\n- spyOn(console, 'error');\n-\n- class ComponentA extends React.Component {\n- static childContextTypes = {\n- foo: React.PropTypes.string.isRequired,\n- };\n- render() {\n- return

;\n- }\n- }\n- class ComponentB extends React.Component {\n- static childContextTypes = {\n- foo: React.PropTypes.string.isRequired,\n- };\n- render() {\n- return

;\n- }\n- }\n-\n- ReactTestUtils.renderIntoDocument();\n- expectDev(console.error.calls.count()).toBe(1);\n- expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toBe(\n- 'Warning: getChildContext() is not defined for ComponentA'\n- );\n- ReactTestUtils.renderIntoDocument();\n- expectDev(console.error.calls.count()).toBe(1);\n- ReactTestUtils.renderIntoDocument();\n- expectDev(console.error.calls.count()).toBe(2);\n- expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(1)[0])).toBe(\n- 'Warning: getChildContext() is not defined for ComponentB'\n- );\n- });\n-\n });\n","body":"","commit":{"revision":"e17cc98a898f0e92e1f8a709820b9c82ea8a1965","subject":"Removed redundant gCC test","authorEmail":"bvaughn@fb.com","authorName":"Brian Vaughn","shortRevision":"e17cc98a89","authoredAt":"2017-01-10T14:03:23-08:00"},"parents":["4f08884b5d132ed7275261769e403ce44517dcc7"],"files":[{"path":"scripts\/fiber\/tests-passing.txt","status":"M"},{"path":"src\/isomorphic\/classic\/__tests__\/ReactContextValidator-test.js","status":"M"}]}

dillon1000/react

Files changed