{"body":"","files":[{"path":"src\/renderers\/dom\/fiber\/ReactDOMFiberComponent.js","status":"M"}],"parents":["ec178acf151f2642897f3ef5aa29005e059be4b8"],"patch":"diff --git a\/src\/renderers\/dom\/fiber\/ReactDOMFiberComponent.js b\/src\/renderers\/dom\/fiber\/ReactDOMFiberComponent.js\nindex 2069246dd5..4c245e94ed 100644\n--- a\/src\/renderers\/dom\/fiber\/ReactDOMFiberComponent.js\n+++ b\/src\/renderers\/dom\/fiber\/ReactDOMFiberComponent.js\n@@ -495,127 +495,6 @@ function isCustomComponent(tagName, props) {\n return tagName.indexOf('-') >= 0 || props.is != null;\n }\n \n-\n-\/**\n- * Creates markup for the open tag and all attributes.\n- *\n- * This method has side effects because events get registered.\n- *\n- * Iterating over object properties is faster than iterating over arrays.\n- * @see http:\/\/jsperf.com\/obj-vs-arr-iteration\n- *\n- * @private\n- * @param {ReactReconcileTransaction|ReactServerRenderingTransaction} transaction\n- * @param {object} props\n- * @return {string} Markup of opening tag.\n- *\/\n-function createOpenTagMarkupAndPutListeners(workInProgress, transaction, props) {\n- var ret = '<' + workInProgress._currentElement.type;\n-\n- for (var propKey in props) {\n- if (!props.hasOwnProperty(propKey)) {\n- continue;\n- }\n- var propValue = props[propKey];\n- if (propValue == null) {\n- continue;\n- }\n- if (registrationNameModules.hasOwnProperty(propKey)) {\n- if (propValue) {\n- enqueuePutListener(workInProgress, propKey, propValue, transaction);\n- }\n- } else {\n- if (propKey === STYLE) {\n- if (propValue) {\n- if (__DEV__) {\n- \/\/ See `_updateDOMProperties`. style block\n- workInProgress._previousStyle = propValue;\n- }\n- propValue = workInProgress._previousStyleCopy = Object.assign({}, props.style);\n- }\n- propValue = CSSPropertyOperations.createMarkupForStyles(propValue, workInProgress);\n- }\n- var markup = null;\n- if (workInProgress._tag != null && isCustomComponent(workInProgress._tag, props)) {\n- if (!RESERVED_PROPS.hasOwnProperty(propKey)) {\n- markup = DOMPropertyOperations.createMarkupForCustomAttribute(propKey, propValue);\n- }\n- } else {\n- markup = DOMPropertyOperations.createMarkupForProperty(propKey, propValue);\n- }\n- if (markup) {\n- ret += ' ' + markup;\n- }\n- }\n- }\n-\n- \/\/ For static pages, no need to put React ID and checksum. Saves lots of\n- \/\/ bytes.\n- if (transaction.renderToStaticMarkup) {\n- return ret;\n- }\n-\n- if (!workInProgress._hostParent) {\n- ret += ' ' + DOMPropertyOperations.createMarkupForRoot();\n- }\n- ret += ' ' + DOMPropertyOperations.createMarkupForID(workInProgress._domID);\n- return ret;\n-}\n-\n-\/**\n- * Creates markup for the content between the tags.\n- *\n- * @private\n- * @param {ReactReconcileTransaction|ReactServerRenderingTransaction} transaction\n- * @param {object} props\n- * @param {object} context\n- * @return {string} Content markup.\n- *\/\n-function createContentMarkup(workInProgress, transaction, props, context) {\n- var ret = '';\n-\n- \/\/ Intentional use of != to avoid catching zero\/false.\n- var innerHTML = props.dangerouslySetInnerHTML;\n- if (innerHTML != null) {\n- if (innerHTML.__html != null) {\n- ret = innerHTML.__html;\n- }\n- } else {\n- var contentToUse =\n- CONTENT_TYPES[typeof props.children] ? props.children : null;\n- var childrenToUse = contentToUse != null ? null : props.children;\n- if (contentToUse != null) {\n- \/\/ TODO: Validate that text is allowed as a child of this node\n- ret = escapeTextContentForBrowser(contentToUse);\n- if (__DEV__) {\n- setAndValidateContentChildDev.call(workInProgress, contentToUse);\n- }\n- } else if (childrenToUse != null) {\n- var mountImages = workInProgress.mountChildren(\n- childrenToUse,\n- transaction,\n- context\n- );\n- ret = mountImages.join('');\n- }\n- }\n- if (newlineEatingTags[workInProgress._tag] && ret.charAt(0) === '\\n') {\n- \/\/ text\/html ignores the first character in these tags if it's a newline\n- \/\/ Prefer to break application\/xml over text\/html (for now) by adding\n- \/\/ a newline specifically to get eaten by the parser. (Alternately for\n- \/\/ textareas, replacing \"^\\n\" with \"\\r\\n\" doesn't get eaten, and the first\n- \/\/ \\r is normalized out by HTMLTextAreaElement#value.)\n- \/\/ See: \n- \/\/ See: \n- \/\/ See: \n- \/\/ See: Parsing of \"textarea\" \"listing\" and \"pre\" elements\n- \/\/ from \n- return '\\n' + ret;\n- } else {\n- return ret;\n- }\n-}\n-\n function createInitialChildren(workInProgress, transaction, props, context, lazyTree) {\n \/\/ Intentional use of != to avoid catching zero\/false.\n var innerHTML = props.dangerouslySetInnerHTML;\n@@ -981,60 +860,50 @@ var ReactDOMFiberComponent = {\n \n var mountImage;\n var type = workInProgress._currentElement.type;\n- if (transaction.useCreateElement) {\n- var ownerDocument = hostContainerInfo._ownerDocument;\n- var el;\n- if (namespaceURI === DOMNamespaces.html) {\n- if (workInProgress._tag === 'script') {\n- \/\/ Create the script via .innerHTML so its \"parser-inserted\" flag is\n- \/\/ set to true and it does not execute\n- var div = ownerDocument.createElement('div');\n- div.innerHTML = `<${type}><\/${type}>`;\n- el = div.removeChild(div.firstChild);\n- } else if (props.is) {\n- el = ownerDocument.createElement(type, props.is);\n- } else {\n- \/\/ Separate else branch instead of using `props.is || undefined` above becuase of a Firefox bug.\n- \/\/ See discussion in https:\/\/github.com\/facebook\/react\/pull\/6896\n- \/\/ and discussion in https:\/\/bugzilla.mozilla.org\/show_bug.cgi?id=1276240\n- el = ownerDocument.createElement(type);\n- }\n+ var ownerDocument = hostContainerInfo._ownerDocument;\n+ var el;\n+ if (namespaceURI === DOMNamespaces.html) {\n+ if (workInProgress._tag === 'script') {\n+ \/\/ Create the script via .innerHTML so its \"parser-inserted\" flag is\n+ \/\/ set to true and it does not execute\n+ var div = ownerDocument.createElement('div');\n+ div.innerHTML = `<${type}><\/${type}>`;\n+ el = div.removeChild(div.firstChild);\n+ } else if (props.is) {\n+ el = ownerDocument.createElement(type, props.is);\n } else {\n- el = ownerDocument.createElementNS(\n- namespaceURI,\n- type\n- );\n- }\n- var isCustomComponentTag = isCustomComponent(workInProgress._tag, props);\n- if (__DEV__ && isCustomComponentTag && !didWarnShadyDOM && el.shadyRoot) {\n- var owner = workInProgress._currentElement._owner;\n- var name = owner && owner.getName() || 'A component';\n- warning(\n- false,\n- '%s is using shady DOM. Using shady DOM with React can ' +\n- 'cause things to break subtly.',\n- name\n- );\n- didWarnShadyDOM = true;\n- }\n- ReactDOMComponentTree.precacheNode(workInProgress, el);\n- workInProgress._flags |= Flags.hasCachedChildNodes;\n- if (!workInProgress._hostParent) {\n- DOMPropertyOperations.setAttributeForRoot(el);\n+ \/\/ Separate else branch instead of using `props.is || undefined` above becuase of a Firefox bug.\n+ \/\/ See discussion in https:\/\/github.com\/facebook\/react\/pull\/6896\n+ \/\/ and discussion in https:\/\/bugzilla.mozilla.org\/show_bug.cgi?id=1276240\n+ el = ownerDocument.createElement(type);\n }\n- updateDOMProperties(workInProgress, null, props, transaction, isCustomComponentTag);\n- var lazyTree = DOMLazyTree(el);\n- createInitialChildren(workInProgress, transaction, props, context, lazyTree);\n- mountImage = lazyTree;\n } else {\n- var tagOpen = createOpenTagMarkupAndPutListeners(workInProgress, transaction, props);\n- var tagContent = createContentMarkup(workInProgress, transaction, props, context);\n- if (!tagContent && omittedCloseTags[workInProgress._tag]) {\n- mountImage = tagOpen + '\/>';\n- } else {\n- mountImage = tagOpen + '>' + tagContent + '<\/' + type + '>';\n- }\n+ el = ownerDocument.createElementNS(\n+ namespaceURI,\n+ type\n+ );\n+ }\n+ var isCustomComponentTag = isCustomComponent(workInProgress._tag, props);\n+ if (__DEV__ && isCustomComponentTag && !didWarnShadyDOM && el.shadyRoot) {\n+ var owner = workInProgress._currentElement._owner;\n+ var name = owner && owner.getName() || 'A component';\n+ warning(\n+ false,\n+ '%s is using shady DOM. Using shady DOM with React can ' +\n+ 'cause things to break subtly.',\n+ name\n+ );\n+ didWarnShadyDOM = true;\n+ }\n+ ReactDOMComponentTree.precacheNode(workInProgress, el);\n+ workInProgress._flags |= Flags.hasCachedChildNodes;\n+ if (!workInProgress._hostParent) {\n+ DOMPropertyOperations.setAttributeForRoot(el);\n }\n+ updateDOMProperties(workInProgress, null, props, transaction, isCustomComponentTag);\n+ var lazyTree = DOMLazyTree(el);\n+ createInitialChildren(workInProgress, transaction, props, context, lazyTree);\n+ mountImage = lazyTree;\n \n switch (workInProgress._tag) {\n case 'input':\n","commit":{"authoredAt":"2016-11-15T17:42:11+00:00","authorEmail":"sema@fb.com","revision":"e34e8974db85e98e735a73a65f01e49b35e6f414","shortRevision":"e34e8974db","authorName":"Sebastian Markbage","subject":"Remove markup related paths"}}

dillon1000/react

Files changed