dillon1000/react
Commit
Browse files Move string ref coercion to JSX runtime (#28473)
Based on: - #28464 --- This moves the entire string ref implementation out Fiber and into the JSX runtime. The string is converted to a callback ref during element creation. This is a subtle change in behavior, because it will have already been converted to a callback ref if you access element.prop.ref or element.ref. But this is only for Meta, because string refs are disabled entirely in open source. And if it leads to an issue in practice, the solution is to switch to a different ref type, which Meta is going to do regardless.
Changed paths14 files
First-parent comparisonpackages/react-dom/src/__tests__/ReactComponent-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationRefs-test.js ModifiedM packages/react-dom/src/__tests__/ReactDeprecationWarnings-test.js ModifiedM packages/react-dom/src/__tests__/ReactFunctionComponent-test.js ModifiedM packages/react-dom/src/__tests__/multiple-copies-of-react-test.js ModifiedM packages/react-dom/src/__tests__/refs-test.js ModifiedM packages/react-reconciler/src/ReactChildFiber.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalSideEffects-test.js ModifiedM packages/react/src/__tests__/ReactCoffeeScriptClass-test.coffee ModifiedM packages/react/src/__tests__/ReactES6Class-test.js ModifiedM packages/react/src/__tests__/ReactElementClone-test.js ModifiedM packages/react/src/__tests__/ReactStrictMode-test.js ModifiedM packages/react/src/__tests__/ReactTypeScriptClass-test.ts ModifiedM packages/react/src/jsx/ReactJSXElement.js ModifiedPatch
Files changed
Rendering syntax-highlighted changes…