{"parents":["f86afca090b668d8be10b642750844759768d1ad"],"commit":{"subject":"Add Promise as a child test to Flight fixture (#28778)","revision":"e63918d2cd53b03c19119b475e116d1b45fd0f84","authorEmail":"silbermann.sebastian@gmail.com","authoredAt":"2024-04-08T17:06:17+02:00","authorName":"Sebastian Silbermann","shortRevision":"e63918d2cd"},"body":"","files":[{"status":"M","path":"fixtures\/flight\/__tests__\/__e2e__\/smoke.test.js"},{"status":"M","path":"fixtures\/flight\/src\/App.js"}],"patch":"diff --git a\/fixtures\/flight\/__tests__\/__e2e__\/smoke.test.js b\/fixtures\/flight\/__tests__\/__e2e__\/smoke.test.js\nindex af889d5de1..267bd10908 100644\n--- a\/fixtures\/flight\/__tests__\/__e2e__\/smoke.test.js\n+++ b\/fixtures\/flight\/__tests__\/__e2e__\/smoke.test.js\n@@ -13,7 +13,9 @@ test('smoke test', async ({page}) => {\n pageErrors.push(error.stack);\n });\n await page.goto('\/');\n- await expect(page.locator('h1')).toHaveText('Hello World');\n+ await expect(page.getByTestId('promise-as-a-child-test')).toHaveText(\n+ 'Promise as a child hydrates without errors: deferred text'\n+ );\n \n await expect(consoleErrors).toEqual([]);\n await expect(pageErrors).toEqual([]);\ndiff --git a\/fixtures\/flight\/src\/App.js b\/fixtures\/flight\/src\/App.js\nindex 7a14beb460..027056c515 100644\n--- a\/fixtures\/flight\/src\/App.js\n+++ b\/fixtures\/flight\/src\/App.js\n@@ -19,6 +19,10 @@ import {like, greet, increment} from '.\/actions.js';\n \n import {getServerState} from '.\/ServerState.js';\n \n+const promisedText = new Promise(resolve =>\n+ setTimeout(() => resolve('deferred text'), 100)\n+);\n+\n export default async function App() {\n const res = await fetch('http:\/\/localhost:3001\/todos');\n const todos = await res.json();\n@@ -32,6 +36,11 @@ export default async function App() {\n \n \n

{getServerState()}<\/h1>\n+ \n+
\n+ Promise as a child hydrates without errors: {promisedText}\n+ <\/div>\n+ <\/React.Suspense>\n \n \n \n"}

{getServerState()}<\/h1>\n+ \n+ \n+ Promise as a child hydrates without errors: {promisedText}\n+ <\/div>\n+ <\/React.Suspense>\n \n \n \n"}

{getServerState()}<\/h1>\n+ \n+
\n+ Promise as a child hydrates without errors: {promisedText}\n+ <\/div>\n+ <\/React.Suspense>\n \n \n \n"}

dillon1000/react

Files changed