{"patch":"diff --git a\/compiler\/forget\/src\/CompilerPipeline.ts b\/compiler\/forget\/src\/CompilerPipeline.ts\nindex 88b654485b..7ed34d2351 100644\n--- a\/compiler\/forget\/src\/CompilerPipeline.ts\n+++ b\/compiler\/forget\/src\/CompilerPipeline.ts\n@@ -27,6 +27,7 @@ import {\n flattenReactiveLoops,\n inferReactiveScopeVariables,\n mergeOverlappingReactiveScopes,\n+ promoteUsedTemporaries,\n propagateScopeDependencies,\n pruneUnusedLabels,\n pruneUnusedLValues,\n@@ -128,6 +129,13 @@ export function* run(\n value: reactiveFunction,\n });\n \n+ promoteUsedTemporaries(reactiveFunction);\n+ yield log({\n+ kind: \"reactive\",\n+ name: \"promoteUsedTemporaries\",\n+ value: reactiveFunction,\n+ });\n+\n pruneUnusedLabels(reactiveFunction);\n yield log({\n kind: \"reactive\",\ndiff --git a\/compiler\/forget\/src\/ReactiveScopes\/CodegenReactiveFunction.ts b\/compiler\/forget\/src\/ReactiveScopes\/CodegenReactiveFunction.ts\nindex db1f42003b..5ad5e480bf 100644\n--- a\/compiler\/forget\/src\/ReactiveScopes\/CodegenReactiveFunction.ts\n+++ b\/compiler\/forget\/src\/ReactiveScopes\/CodegenReactiveFunction.ts\n@@ -185,8 +185,11 @@ function codegenReactiveScope(\n firstOutputIndex = index;\n }\n \n- \/\/ TODO @josephsavona: ensure change and temp variables have non-conflicting names\n- output.name ??= `t${index}`;\n+ invariant(\n+ output.name != null,\n+ \"Expected identifier '@%s' to be named\",\n+ output.id\n+ );\n \n const name = convertIdentifier(output);\n cx.declare(output);\ndiff --git a\/compiler\/forget\/src\/ReactiveScopes\/InferReactiveIdentifiers.ts b\/compiler\/forget\/src\/ReactiveScopes\/InferReactiveIdentifiers.ts\nnew file mode 100644\nindex 0000000000..654353ff0e\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/ReactiveScopes\/InferReactiveIdentifiers.ts\n@@ -0,0 +1,127 @@\n+\/**\n+ * Copyright (c) Facebook, Inc. and its affiliates.\n+ *\n+ * This source code is licensed under the MIT license found in the\n+ * LICENSE file in the root directory of this source tree.\n+ *\/\n+\n+import {\n+ Identifier,\n+ ReactiveFunction,\n+ ReactiveInstruction,\n+ ReactiveScope,\n+} from \"..\/HIR\/HIR\";\n+import {\n+ eachReactiveValueOperand,\n+ ReactiveFunctionVisitor,\n+ visitReactiveFunction,\n+} from \".\/visitors\";\n+\n+type IdentifierReactivity = Map;\n+class Environment extends ReactiveFunctionVisitor {\n+ override visitInstruction(\n+ instr: ReactiveInstruction,\n+ reactivityMap: IdentifierReactivity\n+ ) {\n+ this.traverseInstruction(instr, reactivityMap);\n+ const lval = instr.lvalue;\n+ if (lval == null || reactivityMap.get(lval.place.identifier) === true) {\n+ return;\n+ }\n+ const { value } = instr;\n+ let hasReactiveInput = false;\n+ for (const operand of eachReactiveValueOperand(value)) {\n+ \/\/ We currently treat free variables (from module or global scope) as\n+ \/\/ non-reactive. We may later want type information about specific\n+ \/\/ free variables, or a toggle `treatFreeVarsAsReactive`.\n+ if (reactivityMap.get(operand.identifier)) {\n+ hasReactiveInput = true;\n+ break;\n+ }\n+ }\n+ reactivityMap.set(lval.place.identifier, hasReactiveInput);\n+\n+ if (hasReactiveInput) {\n+ \/\/ all mutating effects must also be marked as reactive\n+ for (const operand of eachReactiveValueOperand(value)) {\n+ if (operand.effect === \"store\" || operand.effect === \"mutate\") {\n+ \/\/ Explicitly compare to `false` here, since absence from the\n+ \/\/ map indicates a free variable\n+ \/\/ todo [@mofeiZ] add knowledge about free variables\n+ if (reactivityMap.get(operand.identifier) === false) {\n+ reactivityMap.set(operand.identifier, true);\n+ }\n+ }\n+ }\n+ }\n+ }\n+}\n+\/**\n+ * Computes a map of {@link Place} -> reactivityMap. A Place is reactive if any\n+ * operant used in its construction is reactive. Sources of reactivity are\n+ * {@link ReactiveFunction.params} and HookCall return values (TODO).\n+ * Free values are currently not populated.\n+ *\n+ * This relies on alias analysis done by InferReactiveScopeVariables, which\n+ * creates reactive scopes for variables that mutate together. If one value\n+ * declared in a scope is Reactive, then the rest are marked as reactive as\n+ * well.\n+ * e.g.\n+ * ```javascript\n+ * function foo(props) {\n+ * let x = {};\n+ * let y = [];\n+ * x.y = y;\n+ * y.push(props.a)\n+ * \/\/ references to x are reactive here\n+ * }\n+ * ```\n+ * This an overestimate when two identifiers have overlapping scope, but\n+ * one is not actually reactive. However, since the same ReactiveBlock now\n+ * produces both identifiers, they are effectively both effective (i.e.\n+ * object creation is not stable)\n+ * e.g.\n+ * ```javascript\n+ * function bar(props) {\n+ * let x = {};\n+ * let y = [];\n+ * mutate1(x, props);\n+ * mutate2(y);\n+ * }\n+ * ```\n+ *\/\n+export function inferReactiveIdentifiers(\n+ fn: ReactiveFunction\n+): Set {\n+ const visitor = new Environment();\n+ const reactivityMap: IdentifierReactivity = new Map();\n+ for (const param of fn.params) {\n+ reactivityMap.set(param.identifier, true);\n+ }\n+ const actuallyReactiveScopes = new Set();\n+ let prevScopesSize = -1;\n+\n+ \/\/ TODO(mofeiZ): avoid fixpoint iteration by keeping a map of identifiers\n+ \/\/ read by a ReactiveScope (that are produced outside of it)\n+ while (actuallyReactiveScopes.size > prevScopesSize) {\n+ prevScopesSize = actuallyReactiveScopes.size;\n+ visitReactiveFunction(fn, visitor, reactivityMap);\n+\n+ for (const [id, value] of reactivityMap) {\n+ const { scope } = id;\n+ if (value && scope != null) {\n+ actuallyReactiveScopes.add(scope);\n+ }\n+ }\n+ for (const [id, _] of reactivityMap) {\n+ if (id.scope && actuallyReactiveScopes.has(id.scope)) {\n+ reactivityMap.set(id, true);\n+ }\n+ }\n+ }\n+ const result = new Set();\n+ reactivityMap.forEach((isReactive, id) => {\n+ if (isReactive) result.add(id);\n+ });\n+ return result;\n+}\ndiff --git a\/compiler\/forget\/src\/ReactiveScopes\/PromoteUsedTemporaries.ts b\/compiler\/forget\/src\/ReactiveScopes\/PromoteUsedTemporaries.ts\nnew file mode 100644\nindex 0000000000..d15dda3236\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/ReactiveScopes\/PromoteUsedTemporaries.ts\n@@ -0,0 +1,37 @@\n+\/**\n+ * Copyright (c) Facebook, Inc. and its affiliates.\n+ *\n+ * This source code is licensed under the MIT license found in the\n+ * LICENSE file in the root directory of this source tree.\n+ *\/\n+\n+import { ReactiveFunction, ReactiveScopeBlock } from \"..\/HIR\/HIR\";\n+import { ReactiveFunctionVisitor, visitReactiveFunction } from \".\/visitors\";\n+\n+type VisitorState = {\n+ nextId: number;\n+};\n+class Visitor extends ReactiveFunctionVisitor {\n+ override visitScope(block: ReactiveScopeBlock, state: VisitorState) {\n+ this.traverseScope(block, state);\n+ for (const dep of block.scope.dependencies) {\n+ const { identifier } = dep.place;\n+ if (identifier.name == null) {\n+ identifier.name = `t${state.nextId++}`;\n+ }\n+ }\n+ \/\/ This is technically optional. We could prune ReactiveScopes\n+ \/\/ whose outputs are not used in another computation or return\n+ \/\/ value.\n+ \/\/ Many of our current test fixtures do not return a value, so\n+ \/\/ it is better for now to promote (and memoize) every output.\n+ for (const identifier of block.scope.outputs) {\n+ if (identifier.name == null) {\n+ identifier.name = `t${state.nextId++}`;\n+ }\n+ }\n+ }\n+}\n+export function promoteUsedTemporaries(fn: ReactiveFunction) {\n+ visitReactiveFunction(fn, new Visitor(), { nextId: 0 });\n+}\ndiff --git a\/compiler\/forget\/src\/ReactiveScopes\/PropagateScopeDependencies.ts b\/compiler\/forget\/src\/ReactiveScopes\/PropagateScopeDependencies.ts\nindex e8bbc8cd25..71107c4a2e 100644\n--- a\/compiler\/forget\/src\/ReactiveScopes\/PropagateScopeDependencies.ts\n+++ b\/compiler\/forget\/src\/ReactiveScopes\/PropagateScopeDependencies.ts\n@@ -9,7 +9,6 @@ import {\n Identifier,\n InstructionId,\n InstructionKind,\n- isPrimitiveType,\n LValue,\n makeInstructionId,\n Place,\n@@ -22,6 +21,7 @@ import {\n } from \"..\/HIR\/HIR\";\n import { eachInstructionValueOperand } from \"..\/HIR\/visitors\";\n import { assertExhaustive } from \"..\/Utils\/utils\";\n+import { inferReactiveIdentifiers } from \".\/InferReactiveIdentifiers\";\n import { eachReactiveValueOperand } from \".\/visitors\";\n \n \/**\n@@ -31,7 +31,7 @@ import { eachReactiveValueOperand } from \".\/visitors\";\n * their direct dependencies and those of their child scopes.\n *\/\n export function propagateScopeDependencies(fn: ReactiveFunction): void {\n- const context = new Context();\n+ const context = new Context(inferReactiveIdentifiers(fn));\n if (fn.id !== null) {\n context.declare(fn.id, { kind: DeclKind.Const, id: makeInstructionId(0) });\n }\n@@ -57,9 +57,16 @@ type Scopes = Array;\n class Context {\n #declarations: DeclMap = new Map();\n #dependencies: Set = new Set();\n+ #reactiveIdentifiers: Set;\n+ \/\/ Produces a de-duplicated mapping of Id -> ReactiveScopeDependency\n+ \/\/ This helps with.. temporaries that are created only for property loads\n+ \/\/ but can be generalized to all non-allocating temporaries\n #properties: Map = new Map();\n #scopes: Scopes = [];\n \n+ constructor(reactiveIdentifiers: Set) {\n+ this.#reactiveIdentifiers = reactiveIdentifiers;\n+ }\n enter(scope: ReactiveScope, fn: () => void): Set {\n const previousDependencies = this.#dependencies;\n const scopedDependencies = new Set();\n@@ -97,6 +104,10 @@ class Context {\n return this.#scopes.at(-1)!;\n }\n \n+ isReactive(id: Identifier): boolean {\n+ return this.#reactiveIdentifiers.has(id);\n+ }\n+\n visitOperand(place: Place): void {\n this.visitDependency({ place, path: null });\n }\n@@ -133,6 +144,8 @@ class Context {\n }\n \n const decl = this.#declarations.get(maybeDependency.place.identifier);\n+ \/\/ if decl is undefined here, then this is a free var\n+ \/\/ (all other decls e.g. `let x;` should be initialized in BuildHIR)\n \n \/\/ Any value used after its defining scope has concluded must be added as an\n \/\/ output of its defining scope. Regardless of whether its a const or not,\n@@ -323,19 +336,13 @@ function visitInstruction(context: Context, instr: ReactiveInstruction): void {\n const { lvalue } = instr;\n visitInstructionValue(context, instr.value, lvalue);\n if (lvalue !== null && lvalue.kind !== InstructionKind.Reassign) {\n- const range = lvalue.place.identifier.mutableRange;\n \/\/ TODO: only assign Const if the value is never reassigned\n- const kind =\n- range.end === range.start + 1\n- ? valueKind(lvalue.place.identifier)\n- : DeclKind.Dynamic;\n+ const kind = context.isReactive(lvalue.place.identifier)\n+ ? DeclKind.Dynamic\n+ : DeclKind.Const;\n context.declare(lvalue.place.identifier, {\n kind,\n id: lvalue.place.identifier.mutableRange.start,\n });\n }\n }\n-\n-function valueKind(id: Identifier): DeclKind {\n- return isPrimitiveType(id) ? DeclKind.Const : DeclKind.Dynamic;\n-}\ndiff --git a\/compiler\/forget\/src\/ReactiveScopes\/index.ts b\/compiler\/forget\/src\/ReactiveScopes\/index.ts\nindex b848df584e..9ae824a373 100644\n--- a\/compiler\/forget\/src\/ReactiveScopes\/index.ts\n+++ b\/compiler\/forget\/src\/ReactiveScopes\/index.ts\n@@ -13,6 +13,7 @@ export { flattenReactiveLoops } from \".\/FlattenReactiveLoops\";\n export { inferReactiveScopeVariables } from \".\/InferReactiveScopeVariables\";\n export { mergeOverlappingReactiveScopes } from \".\/MergeOverlappingReactiveScopes\";\n export { printReactiveFunction } from \".\/PrintReactiveFunction\";\n+export { promoteUsedTemporaries } from \".\/PromoteUsedTemporaries\";\n export { propagateScopeDependencies } from \".\/PropagateScopeDependencies\";\n export { pruneTemporaryLValues as pruneUnusedLValues } from \".\/PruneTemporaryLValues\";\n export { pruneUnusedLabels } from \".\/PruneUnusedLabels\";\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/alias-nested-member-path.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/alias-nested-member-path.expect.md\nindex 0c334b707d..503fd28b3a 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/alias-nested-member-path.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/alias-nested-member-path.expect.md\n@@ -25,25 +25,21 @@ function component() {\n } else {\n z = $[0];\n }\n- const c_1 = $[1] !== z;\n let y;\n- if (c_1) {\n+ if ($[1] === Symbol.for(\"react.memo_cache_sentinel\")) {\n y = {};\n y.z = z;\n- $[1] = z;\n- $[2] = y;\n+ $[1] = y;\n } else {\n- y = $[2];\n+ y = $[1];\n }\n- const c_3 = $[3] !== y;\n let x;\n- if (c_3) {\n+ if ($[2] === Symbol.for(\"react.memo_cache_sentinel\")) {\n x = {};\n x.y = y;\n- $[3] = y;\n- $[4] = x;\n+ $[2] = x;\n } else {\n- x = $[4];\n+ x = $[2];\n }\n return x;\n }\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/call.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/call.expect.md\nindex a7c6bca8b9..890ddb71e7 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/call.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/call.expect.md\n@@ -36,18 +36,14 @@ function Component(props) {\n a = $[0];\n b = $[1];\n }\n- const c_2 = $[2] !== a;\n- const c_3 = $[3] !== b;\n- let t4;\n- if (c_2 || c_3) {\n- t4 =

<\/div>;\n- $[2] = a;\n- $[3] = b;\n- $[4] = t4;\n+ let t0;\n+ if ($[2] === Symbol.for(\"react.memo_cache_sentinel\")) {\n+ t0 =

<\/div>;\n+ $[2] = t0;\n } else {\n- t4 = $[4];\n+ t0 = $[2];\n }\n- return t4;\n+ return t0;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/capture-param-mutate.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/capture-param-mutate.expect.md\nindex 3a4cadfef2..ef532db205 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/capture-param-mutate.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/capture-param-mutate.expect.md\n@@ -48,9 +48,9 @@ function getNativeLogFunction(level) {\n function getNativeLogFunction(level) {\n const $ = React.useMemoCache();\n const c_0 = $[0] !== level;\n- let t1;\n+ let t0;\n if (c_0) {\n- t1 = function () {\n+ t0 = function () {\n let str;\n if (arguments.length === 1 && typeof arguments[0] === \"string\") {\n str = arguments[0];\n@@ -86,11 +86,11 @@ function getNativeLogFunction(level) {\n global.nativeLoggingHook(str, logLevel);\n };\n $[0] = level;\n- $[1] = t1;\n+ $[1] = t0;\n } else {\n- t1 = $[1];\n+ t0 = $[1];\n }\n- return t1;\n+ return t0;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/capturing-nested-member-call.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/capturing-nested-member-call.expect.md\nindex 97ca8ed82d..a94432c3a9 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/capturing-nested-member-call.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/capturing-nested-member-call.expect.md\n@@ -18,19 +18,19 @@ function component(a) {\n function component(a) {\n const $ = React.useMemoCache();\n const c_0 = $[0] !== a;\n- let t1;\n+ let t0;\n if (c_0) {\n- t1 = { a: a };\n+ t0 = { a: a };\n $[0] = a;\n- $[1] = t1;\n+ $[1] = t0;\n } else {\n- t1 = $[1];\n+ t0 = $[1];\n }\n- const c_2 = $[2] !== t1;\n+ const c_2 = $[2] !== t0;\n let z;\n if (c_2) {\n- z = { a: t1 };\n- $[2] = t1;\n+ z = { a: t0 };\n+ $[2] = t0;\n $[3] = z;\n } else {\n z = $[3];\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/capturing-nested-member-expr-in-nested-func.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/capturing-nested-member-expr-in-nested-func.expect.md\nindex c151e82a6a..c61ce1d035 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/capturing-nested-member-expr-in-nested-func.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/capturing-nested-member-expr-in-nested-func.expect.md\n@@ -20,19 +20,19 @@ function component(a) {\n function component(a) {\n const $ = React.useMemoCache();\n const c_0 = $[0] !== a;\n- let t1;\n+ let t0;\n if (c_0) {\n- t1 = { a: a };\n+ t0 = { a: a };\n $[0] = a;\n- $[1] = t1;\n+ $[1] = t0;\n } else {\n- t1 = $[1];\n+ t0 = $[1];\n }\n- const c_2 = $[2] !== t1;\n+ const c_2 = $[2] !== t0;\n let z;\n if (c_2) {\n- z = { a: t1 };\n- $[2] = t1;\n+ z = { a: t0 };\n+ $[2] = t0;\n $[3] = z;\n } else {\n z = $[3];\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/capturing-nested-member-expr.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/capturing-nested-member-expr.expect.md\nindex 6fd615e2a8..f8d5a90dc3 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/capturing-nested-member-expr.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/capturing-nested-member-expr.expect.md\n@@ -18,19 +18,19 @@ function component(a) {\n function component(a) {\n const $ = React.useMemoCache();\n const c_0 = $[0] !== a;\n- let t1;\n+ let t0;\n if (c_0) {\n- t1 = { a: a };\n+ t0 = { a: a };\n $[0] = a;\n- $[1] = t1;\n+ $[1] = t0;\n } else {\n- t1 = $[1];\n+ t0 = $[1];\n }\n- const c_2 = $[2] !== t1;\n+ const c_2 = $[2] !== t0;\n let z;\n if (c_2) {\n- z = { a: t1 };\n- $[2] = t1;\n+ z = { a: t0 };\n+ $[2] = t0;\n $[3] = z;\n } else {\n z = $[3];\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/component.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/component.expect.md\nindex 6adcc0b3df..f935af44d7 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/component.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/component.expect.md\n@@ -74,31 +74,31 @@ function Component(props) {\n \n const count = renderedItems.length;\n const c_5 = $[5] !== count;\n- let t6;\n+ let t0;\n if (c_5) {\n- t6 =

{count} Items<\/h1>;\n+ t0 =

{count} Items<\/h1>;\n $[5] = count;\n- $[6] = t6;\n+ $[6] = t0;\n } else {\n- t6 = $[6];\n+ t0 = $[6];\n }\n- const c_7 = $[7] !== t6;\n+ const c_7 = $[7] !== t0;\n const c_8 = $[8] !== renderedItems;\n- let t9;\n+ let t1;\n if (c_7 || c_8) {\n- t9 = (\n+ t1 = (\n
\n- {t6}\n+ {t0}\n {renderedItems}\n <\/div>\n );\n- $[7] = t6;\n+ $[7] = t0;\n $[8] = renderedItems;\n- $[9] = t9;\n+ $[9] = t1;\n } else {\n- t9 = $[9];\n+ t1 = $[9];\n }\n- return t9;\n+ return t1;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/concise-arrow-expr.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/concise-arrow-expr.expect.md\nindex 64bab0f4c1..88504d3c0b 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/concise-arrow-expr.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/concise-arrow-expr.expect.md\n@@ -24,25 +24,21 @@ function component() {\n }\n const x = t0[0];\n const setX = t0[1];\n- const c_1 = $[1] !== setX;\n let handler;\n- if (c_1) {\n+ if ($[1] === Symbol.for(\"react.memo_cache_sentinel\")) {\n handler = (v) => setX(v);\n- $[1] = setX;\n- $[2] = handler;\n+ $[1] = handler;\n } else {\n- handler = $[2];\n+ handler = $[1];\n }\n- const c_3 = $[3] !== handler;\n- let t4;\n- if (c_3) {\n- t4 = <\/Foo>;\n- $[3] = handler;\n- $[4] = t4;\n+ let t1;\n+ if ($[2] === Symbol.for(\"react.memo_cache_sentinel\")) {\n+ t1 = <\/Foo>;\n+ $[2] = t1;\n } else {\n- t4 = $[4];\n+ t1 = $[2];\n }\n- return t4;\n+ return t1;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/conditional-on-mutable.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/conditional-on-mutable.expect.md\nindex 7ced099303..98104268a8 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/conditional-on-mutable.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/conditional-on-mutable.expect.md\n@@ -61,16 +61,16 @@ function ComponentA(props) {\n }\n const c_5 = $[5] !== a;\n const c_6 = $[6] !== b;\n- let t7;\n+ let t0;\n if (c_5 || c_6) {\n- t7 = <\/Foo>;\n+ t0 = <\/Foo>;\n $[5] = a;\n $[6] = b;\n- $[7] = t7;\n+ $[7] = t0;\n } else {\n- t7 = $[7];\n+ t0 = $[7];\n }\n- return t7;\n+ return t0;\n }\n \n function ComponentB(props) {\n@@ -100,16 +100,16 @@ function ComponentB(props) {\n }\n const c_5 = $[5] !== a;\n const c_6 = $[6] !== b;\n- let t7;\n+ let t0;\n if (c_5 || c_6) {\n- t7 = <\/Foo>;\n+ t0 = <\/Foo>;\n $[5] = a;\n $[6] = b;\n- $[7] = t7;\n+ $[7] = t0;\n } else {\n- t7 = $[7];\n+ t0 = $[7];\n }\n- return t7;\n+ return t0;\n }\n \n function Foo() {}\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/constructor.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/constructor.expect.md\nindex b1435869fc..1a2134d653 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/constructor.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/constructor.expect.md\n@@ -37,18 +37,14 @@ function Component(props) {\n a = $[0];\n b = $[1];\n }\n- const c_2 = $[2] !== a;\n- const c_3 = $[3] !== b;\n- let t4;\n- if (c_2 || c_3) {\n- t4 =
<\/div>;\n- $[2] = a;\n- $[3] = b;\n- $[4] = t4;\n+ let t0;\n+ if ($[2] === Symbol.for(\"react.memo_cache_sentinel\")) {\n+ t0 =
<\/div>;\n+ $[2] = t0;\n } else {\n- t4 = $[4];\n+ t0 = $[2];\n }\n- return t4;\n+ return t0;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/hook-call.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/hook-call.expect.md\nindex bcc9d40e84..dd07baa66c 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/hook-call.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/hook-call.expect.md\n@@ -34,33 +34,27 @@ function Component(props) {\n } else {\n x = $[0];\n }\n- const c_1 = $[1] !== x;\n let y;\n- if (c_1) {\n+ if ($[1] === Symbol.for(\"react.memo_cache_sentinel\")) {\n y = useFreeze(x);\n- $[1] = x;\n- $[2] = y;\n+ $[1] = y;\n } else {\n- y = $[2];\n+ y = $[1];\n }\n foo(y, x);\n- const c_3 = $[3] !== x;\n- const c_4 = $[4] !== y;\n- let t5;\n- if (c_3 || c_4) {\n- t5 = (\n+ let t0;\n+ if ($[2] === Symbol.for(\"react.memo_cache_sentinel\")) {\n+ t0 = (\n \n {x}\n {y}\n <\/Component>\n );\n- $[3] = x;\n- $[4] = y;\n- $[5] = t5;\n+ $[2] = t0;\n } else {\n- t5 = $[5];\n+ t0 = $[2];\n }\n- return t5;\n+ return t0;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/independent-across-if.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/independent-across-if.expect.md\nindex 1b554966c2..c4c9591424 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/independent-across-if.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/independent-across-if.expect.md\n@@ -80,16 +80,16 @@ function Component(props) {\n }\n const c_5 = $[5] !== a;\n const c_6 = $[6] !== b;\n- let t7;\n+ let t0;\n if (c_5 || c_6) {\n- t7 = <\/Foo>;\n+ t0 = <\/Foo>;\n $[5] = a;\n $[6] = b;\n- $[7] = t7;\n+ $[7] = t0;\n } else {\n- t7 = $[7];\n+ t0 = $[7];\n }\n- return t7;\n+ return t0;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/independent.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/independent.expect.md\nindex d75aadfb5c..4110de0dd7 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/independent.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/independent.expect.md\n@@ -59,16 +59,16 @@ function Component(props) {\n }\n const c_4 = $[4] !== a;\n const c_5 = $[5] !== b;\n- let t6;\n+ let t0;\n if (c_4 || c_5) {\n- t6 = <\/Foo>;\n+ t0 = <\/Foo>;\n $[4] = a;\n $[5] = b;\n- $[6] = t6;\n+ $[6] = t0;\n } else {\n- t6 = $[6];\n+ t0 = $[6];\n }\n- return t6;\n+ return t0;\n }\n \n function compute() {}\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/independently-memoize-object-property.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/independently-memoize-object-property.expect.md\nindex 05014d499d..6d67a3e778 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/independently-memoize-object-property.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/independently-memoize-object-property.expect.md\n@@ -25,16 +25,16 @@ function foo(a, b, c) {\n x = { a: a };\n const c_4 = $[4] !== b;\n const c_5 = $[5] !== c;\n- let t6;\n+ let t0;\n if (c_4 || c_5) {\n- t6 = [b, c];\n+ t0 = [b, c];\n $[4] = b;\n $[5] = c;\n- $[6] = t6;\n+ $[6] = t0;\n } else {\n- t6 = $[6];\n+ t0 = $[6];\n }\n- x.y = t6;\n+ x.y = t0;\n $[0] = a;\n $[1] = b;\n $[2] = c;\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/interdependent-across-if.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/interdependent-across-if.expect.md\nindex 62646e2447..8828da6b15 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/interdependent-across-if.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/interdependent-across-if.expect.md\n@@ -68,16 +68,16 @@ function Component(props) {\n }\n const c_5 = $[5] !== a;\n const c_6 = $[6] !== b;\n- let t7;\n+ let t0;\n if (c_5 || c_6) {\n- t7 = <\/Foo>;\n+ t0 = <\/Foo>;\n $[5] = a;\n $[6] = b;\n- $[7] = t7;\n+ $[7] = t0;\n } else {\n- t7 = $[7];\n+ t0 = $[7];\n }\n- return t7;\n+ return t0;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/interdependent.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/interdependent.expect.md\nindex e0bc030839..bcf1fcf03b 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/interdependent.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/interdependent.expect.md\n@@ -56,16 +56,16 @@ function Component(props) {\n }\n const c_4 = $[4] !== a;\n const c_5 = $[5] !== b;\n- let t6;\n+ let t0;\n if (c_4 || c_5) {\n- t6 = <\/Foo>;\n+ t0 = <\/Foo>;\n $[4] = a;\n $[5] = b;\n- $[6] = t6;\n+ $[6] = t0;\n } else {\n- t6 = $[6];\n+ t0 = $[6];\n }\n- return t6;\n+ return t0;\n }\n \n function compute() {}\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/jsx-fragment.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/jsx-fragment.expect.md\nindex caa5b712d2..0b33ac6033 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/jsx-fragment.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/jsx-fragment.expect.md\n@@ -27,32 +27,28 @@ function Foo(props) {\n } else {\n t0 = $[0];\n }\n- const c_1 = $[1] !== t0;\n- let t2;\n- if (c_1) {\n- t2 =
{t0}<\/div>;\n- $[1] = t0;\n- $[2] = t2;\n+ let t1;\n+ if ($[1] === Symbol.for(\"react.memo_cache_sentinel\")) {\n+ t1 =
{t0}<\/div>;\n+ $[1] = t1;\n } else {\n- t2 = $[2];\n+ t1 = $[1];\n }\n- const c_3 = $[3] !== props.greeting;\n- const c_4 = $[4] !== t2;\n- let t5;\n- if (c_3 || c_4) {\n- t5 = (\n+ const c_2 = $[2] !== props.greeting;\n+ let t2;\n+ if (c_2) {\n+ t2 = (\n <>\n Hello {props.greeting}\n- {t2}\n+ {t1}\n <\/>\n );\n- $[3] = props.greeting;\n- $[4] = t2;\n- $[5] = t5;\n+ $[2] = props.greeting;\n+ $[3] = t2;\n } else {\n- t5 = $[5];\n+ t2 = $[3];\n }\n- return t5;\n+ return t2;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/jsx-spread.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/jsx-spread.expect.md\nindex 260fa1f7c6..1df2983d79 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/jsx-spread.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/jsx-spread.expect.md\n@@ -16,35 +16,35 @@ function Component(props) {\n function Component(props) {\n const $ = React.useMemoCache();\n const c_0 = $[0] !== props;\n- let t1;\n+ let t0;\n if (c_0) {\n- t1 = props.cond ? props.foo : props.bar;\n+ t0 = props.cond ? props.foo : props.bar;\n $[0] = props;\n- $[1] = t1;\n+ $[1] = t0;\n } else {\n- t1 = $[1];\n+ t0 = $[1];\n }\n- const c_2 = $[2] !== t1;\n- let t3;\n+ const c_2 = $[2] !== t0;\n+ let t1;\n if (c_2) {\n- t3 = { bar: t1 };\n- $[2] = t1;\n- $[3] = t3;\n+ t1 = { bar: t0 };\n+ $[2] = t0;\n+ $[3] = t1;\n } else {\n- t3 = $[3];\n+ t1 = $[3];\n }\n const c_4 = $[4] !== props;\n- const c_5 = $[5] !== t3;\n- let t6;\n+ const c_5 = $[5] !== t1;\n+ let t2;\n if (c_4 || c_5) {\n- t6 = <\/Component>;\n+ t2 = <\/Component>;\n $[4] = props;\n- $[5] = t3;\n- $[6] = t6;\n+ $[5] = t1;\n+ $[6] = t2;\n } else {\n- t6 = $[6];\n+ t2 = $[6];\n }\n- return t6;\n+ return t2;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/logical-expression-object.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/logical-expression-object.expect.md\nindex 01cd635182..39962a6714 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/logical-expression-object.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/logical-expression-object.expect.md\n@@ -21,37 +21,37 @@ function component(props) {\n function component(props) {\n const $ = React.useMemoCache();\n const c_0 = $[0] !== props;\n- let t1;\n+ let t0;\n if (c_0) {\n- t1 = props.a || (props.b && props.c && props.d);\n+ t0 = props.a || (props.b && props.c && props.d);\n $[0] = props;\n- $[1] = t1;\n+ $[1] = t0;\n } else {\n- t1 = $[1];\n+ t0 = $[1];\n }\n- const a = t1;\n+ const a = t0;\n const c_2 = $[2] !== props;\n- let t3;\n+ let t1;\n if (c_2) {\n- t3 = (props.a && props.b && props.c) || props.d;\n+ t1 = (props.a && props.b && props.c) || props.d;\n $[2] = props;\n- $[3] = t3;\n+ $[3] = t1;\n } else {\n- t3 = $[3];\n+ t1 = $[3];\n }\n- const b = t3;\n+ const b = t1;\n const c_4 = $[4] !== a;\n const c_5 = $[5] !== b;\n- let t6;\n+ let t2;\n if (c_4 || c_5) {\n- t6 = { a: a, b: b };\n+ t2 = { a: a, b: b };\n $[4] = a;\n $[5] = b;\n- $[6] = t6;\n+ $[6] = t2;\n } else {\n- t6 = $[6];\n+ t2 = $[6];\n }\n- return t6;\n+ return t2;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/logical-expression.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/logical-expression.expect.md\nindex 07ffec0304..de302a284c 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/logical-expression.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/logical-expression.expect.md\n@@ -16,39 +16,39 @@ function component(props) {\n function component(props) {\n const $ = React.useMemoCache();\n const c_0 = $[0] !== props;\n- let t1;\n+ let t0;\n if (c_0) {\n- t1 = props.a || (props.b && props.c && props.d);\n+ t0 = props.a || (props.b && props.c && props.d);\n $[0] = props;\n- $[1] = t1;\n+ $[1] = t0;\n } else {\n- t1 = $[1];\n+ t0 = $[1];\n }\n- const a = t1;\n+ const a = t0;\n const c_2 = $[2] !== props;\n- let t3;\n+ let t1;\n if (c_2) {\n- t3 = (props.a && props.b && props.c) || props.d;\n+ t1 = (props.a && props.b && props.c) || props.d;\n $[2] = props;\n- $[3] = t3;\n+ $[3] = t1;\n } else {\n- t3 = $[3];\n+ t1 = $[3];\n }\n- const b = t3;\n+ const b = t1;\n const c_4 = $[4] !== a;\n const c_5 = $[5] !== b;\n const c_6 = $[6] !== props;\n- let t7;\n+ let t2;\n if (c_4 || c_5 || c_6) {\n- t7 = a ? b : props.c;\n+ t2 = a ? b : props.c;\n $[4] = a;\n $[5] = b;\n $[6] = props;\n- $[7] = t7;\n+ $[7] = t2;\n } else {\n- t7 = $[7];\n+ t2 = $[7];\n }\n- return t7;\n+ return t2;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/object-pattern-params.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/object-pattern-params.expect.md\nindex 628324fd48..a8b4f10915 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/object-pattern-params.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/object-pattern-params.expect.md\n@@ -37,16 +37,16 @@ function component(t8) {\n }\n const c_4 = $[4] !== y;\n const c_5 = $[5] !== z;\n- let t6;\n+ let t0;\n if (c_4 || c_5) {\n- t6 = { y: y, z: z };\n+ t0 = { y: y, z: z };\n $[4] = y;\n $[5] = z;\n- $[6] = t6;\n+ $[6] = t0;\n } else {\n- t6 = $[6];\n+ t0 = $[6];\n }\n- return t6;\n+ return t0;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/overlapping-scopes-shadowing-within-block.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/overlapping-scopes-shadowing-within-block.expect.md\nindex 8ae89b74ff..45af7c1ef3 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/overlapping-scopes-shadowing-within-block.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/overlapping-scopes-shadowing-within-block.expect.md\n@@ -44,15 +44,15 @@ function foo(a, b, c) {\n y = $[6];\n }\n const c_7 = $[7] !== y;\n- let t8;\n+ let t0;\n if (c_7) {\n- t8 =
{y}<\/div>;\n+ t0 =
{y}<\/div>;\n $[7] = y;\n- $[8] = t8;\n+ $[8] = t0;\n } else {\n- t8 = $[8];\n+ t0 = $[8];\n }\n- x.push(t8);\n+ x.push(t0);\n }\n $[0] = a;\n $[1] = b;\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/property-assignment.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/property-assignment.expect.md\nindex ca51d65bf2..76ea4fdbe7 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/property-assignment.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/property-assignment.expect.md\n@@ -37,16 +37,16 @@ function Component(props) {\n }\n const c_3 = $[3] !== x;\n const c_4 = $[4] !== child;\n- let t5;\n+ let t0;\n if (c_3 || c_4) {\n- t5 = {child}<\/Component>;\n+ t0 = {child}<\/Component>;\n $[3] = x;\n $[4] = child;\n- $[5] = t5;\n+ $[5] = t0;\n } else {\n- t5 = $[5];\n+ t0 = $[5];\n }\n- return t5;\n+ return t0;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/reactive-scopes-if.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/reactive-scopes-if.expect.md\nindex e2bf8d322a..6650e1607e 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/reactive-scopes-if.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/reactive-scopes-if.expect.md\n@@ -39,15 +39,15 @@ function foo(a, b, c) {\n y = $[5];\n }\n const c_6 = $[6] !== y;\n- let t7;\n+ let t0;\n if (c_6) {\n- t7 =
{y}<\/div>;\n+ t0 =
{y}<\/div>;\n $[6] = y;\n- $[7] = t7;\n+ $[7] = t0;\n } else {\n- t7 = $[7];\n+ t0 = $[7];\n }\n- x.push(t7);\n+ x.push(t0);\n } else {\n x.push(c);\n }\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/reactive-scopes.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/reactive-scopes.expect.md\nindex bc91a20009..e655b2d9fe 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/reactive-scopes.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/reactive-scopes.expect.md\n@@ -37,15 +37,15 @@ function f(a, b) {\n x = $[2];\n }\n const c_3 = $[3] !== x;\n- let t4;\n+ let t0;\n if (c_3) {\n- t4 =
{x}<\/div>;\n+ t0 =
{x}<\/div>;\n $[3] = x;\n- $[4] = t4;\n+ $[4] = t0;\n } else {\n- t4 = $[4];\n+ t0 = $[4];\n }\n- return t4;\n+ return t0;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/reassignment-conditional.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/reassignment-conditional.expect.md\nindex 95aac57679..085ed96e1d 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/reassignment-conditional.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/reassignment-conditional.expect.md\n@@ -59,16 +59,16 @@ function Component(props) {\n y.push(props.p2);\n const c_5 = $[5] !== x$0;\n const c_6 = $[6] !== y;\n- let t7;\n+ let t0;\n if (c_5 || c_6) {\n- t7 = <\/Component>;\n+ t0 = <\/Component>;\n $[5] = x$0;\n $[6] = y;\n- $[7] = t7;\n+ $[7] = t0;\n } else {\n- t7 = $[7];\n+ t0 = $[7];\n }\n- return t7;\n+ return t0;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/reassignment-separate-scopes.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/reassignment-separate-scopes.expect.md\nindex 053ee9f94f..efdc1fd9aa 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/reassignment-separate-scopes.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/reassignment-separate-scopes.expect.md\n@@ -98,9 +98,9 @@ function foo(a, b, c) {\n }\n const c_11 = $[11] !== y;\n const c_12 = $[12] !== x$0;\n- let t13;\n+ let t0;\n if (c_11 || c_12) {\n- t13 = (\n+ t0 = (\n
\n {y}\n {x$0}\n@@ -108,11 +108,11 @@ function foo(a, b, c) {\n );\n $[11] = y;\n $[12] = x$0;\n- $[13] = t13;\n+ $[13] = t0;\n } else {\n- t13 = $[13];\n+ t0 = $[13];\n }\n- return t13;\n+ return t0;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/reassignment.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/reassignment.expect.md\nindex 015b228019..280ba31389 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/reassignment.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/reassignment.expect.md\n@@ -45,18 +45,16 @@ function Component(props) {\n } else {\n y = $[2];\n }\n- const c_4 = $[4] !== x$0;\n- const c_5 = $[5] !== y;\n- let t6;\n- if (c_4 || c_5) {\n- t6 = <\/Component>;\n- $[4] = x$0;\n- $[5] = y;\n- $[6] = t6;\n+ const c_4 = $[4] !== y;\n+ let t0;\n+ if (c_4) {\n+ t0 = <\/Component>;\n+ $[4] = y;\n+ $[5] = t0;\n } else {\n- t6 = $[6];\n+ t0 = $[5];\n }\n- return t6;\n+ return t0;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/sequence-expression.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/sequence-expression.expect.md\nindex 6910409d26..2229452ce8 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/sequence-expression.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/sequence-expression.expect.md\n@@ -28,19 +28,17 @@ function sequence(props) {\n } else {\n t0 = $[0];\n }\n- const c_1 = $[1] !== t0;\n let x;\n- if (c_1) {\n+ if ($[1] === Symbol.for(\"react.memo_cache_sentinel\")) {\n x = t0;\n while ((foo(), true)) {\n foo();\n 2;\n x = 2;\n }\n- $[1] = t0;\n- $[2] = x;\n+ $[1] = x;\n } else {\n- x = $[2];\n+ x = $[1];\n }\n return x;\n }\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/simple.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/simple.expect.md\nindex 585974ae54..fd111438ba 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/simple.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/simple.expect.md\n@@ -18,22 +18,26 @@ export default function foo(x, y) {\n const $ = React.useMemoCache();\n if (x) {\n const c_0 = $[0] !== y;\n- let t1;\n+ let t0;\n if (c_0) {\n- t1 = foo(false, y);\n+ t0 = foo(false, y);\n $[0] = y;\n- $[1] = t1;\n+ $[1] = t0;\n } else {\n- t1 = $[1];\n+ t0 = $[1];\n }\n- return t1;\n+ return t0;\n }\n+\n+ const t1 = y * 10;\n+ const c_2 = $[2] !== t1;\n let t2;\n- if ($[2] === Symbol.for(\"react.memo_cache_sentinel\")) {\n- t2 = [y * 10];\n- $[2] = t2;\n+ if (c_2) {\n+ t2 = [t1];\n+ $[2] = t1;\n+ $[3] = t2;\n } else {\n- t2 = $[2];\n+ t2 = $[3];\n }\n return t2;\n }\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/ssa-call-jsx-2.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/ssa-call-jsx-2.expect.md\nindex b7941f12d3..ba8d2049fb 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/ssa-call-jsx-2.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/ssa-call-jsx-2.expect.md\n@@ -32,14 +32,14 @@ function Component(props) {\n a = [];\n b = {};\n foo(a, b);\n- let t2;\n+ let t0;\n if ($[2] === Symbol.for(\"react.memo_cache_sentinel\")) {\n- t2 = foo();\n- $[2] = t2;\n+ t0 = foo();\n+ $[2] = t0;\n } else {\n- t2 = $[2];\n+ t0 = $[2];\n }\n- if (t2) {\n+ if (t0) {\n const _ =
<\/div>;\n }\n \n@@ -50,18 +50,14 @@ function Component(props) {\n a = $[0];\n b = $[1];\n }\n- const c_3 = $[3] !== a;\n- const c_4 = $[4] !== b;\n- let t5;\n- if (c_3 || c_4) {\n- t5 =
<\/div>;\n- $[3] = a;\n- $[4] = b;\n- $[5] = t5;\n+ let t1;\n+ if ($[3] === Symbol.for(\"react.memo_cache_sentinel\")) {\n+ t1 =
<\/div>;\n+ $[3] = t1;\n } else {\n- t5 = $[5];\n+ t1 = $[3];\n }\n- return t5;\n+ return t1;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/ssa-call-jsx.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/ssa-call-jsx.expect.md\nindex 6983f45d60..22fa95c7cb 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/ssa-call-jsx.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/ssa-call-jsx.expect.md\n@@ -36,18 +36,14 @@ function Component(props) {\n a = $[0];\n b = $[1];\n }\n- const c_2 = $[2] !== a;\n- const c_3 = $[3] !== b;\n- let t4;\n- if (c_2 || c_3) {\n- t4 =
<\/div>;\n- $[2] = a;\n- $[3] = b;\n- $[4] = t4;\n+ let t0;\n+ if ($[2] === Symbol.for(\"react.memo_cache_sentinel\")) {\n+ t0 =
<\/div>;\n+ $[2] = t0;\n } else {\n- t4 = $[4];\n+ t0 = $[2];\n }\n- return t4;\n+ return t0;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/ssa-property.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/ssa-property.expect.md\nindex a6b039de63..1a1e9b4cf4 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/ssa-property.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/ssa-property.expect.md\n@@ -23,15 +23,13 @@ function foo() {\n } else {\n x = $[0];\n }\n- const c_1 = $[1] !== x;\n let y;\n- if (c_1) {\n+ if ($[1] === Symbol.for(\"react.memo_cache_sentinel\")) {\n y = {};\n y.x = x;\n- $[1] = x;\n- $[2] = y;\n+ $[1] = y;\n } else {\n- y = $[2];\n+ y = $[1];\n }\n return y;\n }\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/switch-non-final-default.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/switch-non-final-default.expect.md\nindex 6b2c6710d4..8731df2ab8 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/switch-non-final-default.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/switch-non-final-default.expect.md\n@@ -85,16 +85,16 @@ function Component(props) {\n y$0.push(props.p4);\n const c_7 = $[7] !== y$0;\n const c_8 = $[8] !== child;\n- let t9;\n+ let t0;\n if (c_7 || c_8) {\n- t9 = {child}<\/Component>;\n+ t0 = {child}<\/Component>;\n $[7] = y$0;\n $[8] = child;\n- $[9] = t9;\n+ $[9] = t0;\n } else {\n- t9 = $[9];\n+ t0 = $[9];\n }\n- return t9;\n+ return t0;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/switch.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/switch.expect.md\nindex 5ed54310bb..079e07d6d9 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/switch.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/switch.expect.md\n@@ -69,16 +69,16 @@ function Component(props) {\n y$0.push(props.p4);\n const c_7 = $[7] !== y$0;\n const c_8 = $[8] !== child;\n- let t9;\n+ let t0;\n if (c_7 || c_8) {\n- t9 = {child}<\/Component>;\n+ t0 = {child}<\/Component>;\n $[7] = y$0;\n $[8] = child;\n- $[9] = t9;\n+ $[9] = t0;\n } else {\n- t9 = $[9];\n+ t0 = $[9];\n }\n- return t9;\n+ return t0;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/ternary-expression.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/ternary-expression.expect.md\nindex ffd55cfbfd..2a6673c632 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/ternary-expression.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/ternary-expression.expect.md\n@@ -16,37 +16,37 @@ function ternary(props) {\n function ternary(props) {\n const $ = React.useMemoCache();\n const c_0 = $[0] !== props;\n- let t1;\n+ let t0;\n if (c_0) {\n- t1 = props.a && props.b ? props.c || props.d : props.e ?? props.f;\n+ t0 = props.a && props.b ? props.c || props.d : props.e ?? props.f;\n $[0] = props;\n- $[1] = t1;\n+ $[1] = t0;\n } else {\n- t1 = $[1];\n+ t0 = $[1];\n }\n- const a = t1;\n+ const a = t0;\n const c_2 = $[2] !== props;\n- let t3;\n+ let t1;\n if (c_2) {\n- t3 = props.a ? (props.b && props.c ? props.d : props.e) : props.f;\n+ t1 = props.a ? (props.b && props.c ? props.d : props.e) : props.f;\n $[2] = props;\n- $[3] = t3;\n+ $[3] = t1;\n } else {\n- t3 = $[3];\n+ t1 = $[3];\n }\n- const b = t3;\n+ const b = t1;\n const c_4 = $[4] !== a;\n const c_5 = $[5] !== b;\n- let t6;\n+ let t2;\n if (c_4 || c_5) {\n- t6 = a ? b : (null, null);\n+ t2 = a ? b : (null, null);\n $[4] = a;\n $[5] = b;\n- $[6] = t6;\n+ $[6] = t2;\n } else {\n- t6 = $[6];\n+ t2 = $[6];\n }\n- return t6;\n+ return t2;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/type-test-field-load-binary-op.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/type-test-field-load-binary-op.expect.md\nindex 6af4d7a98b..783a26d730 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/type-test-field-load-binary-op.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/type-test-field-load-binary-op.expect.md\n@@ -34,16 +34,12 @@ function component() {\n } else {\n t1 = $[1];\n }\n- const c_2 = $[2] !== t0;\n- const c_3 = $[3] !== t1;\n let x;\n- if (c_2 || c_3) {\n+ if ($[2] === Symbol.for(\"react.memo_cache_sentinel\")) {\n x = { u: t0, v: t1 };\n- $[2] = t0;\n- $[3] = t1;\n- $[4] = x;\n+ $[2] = x;\n } else {\n- x = $[4];\n+ x = $[2];\n }\n const u = x.u;\n const v = x.v;\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/type-test-polymorphic.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/type-test-polymorphic.expect.md\nindex 69c7e8552b..1dd78727d0 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/type-test-polymorphic.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/type-test-polymorphic.expect.md\n@@ -38,18 +38,16 @@ function component() {\n } else {\n o = $[1];\n }\n- const c_2 = $[2] !== o;\n let x;\n- if (c_2) {\n+ if ($[2] === Symbol.for(\"react.memo_cache_sentinel\")) {\n x = {};\n x.t = p;\n \n const z = x.t;\n x.t = o;\n- $[2] = o;\n- $[3] = x;\n+ $[2] = x;\n } else {\n- x = $[3];\n+ x = $[2];\n }\n \n const y = x.t;\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/unary-expr.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/unary-expr.expect.md\nindex 7ca618c6f6..0f26f4d4fa 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/unary-expr.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/unary-expr.expect.md\n@@ -37,14 +37,28 @@ function component(a) {\n const m = !t.t;\n const e = ~t.t;\n const f = typeof t.t;\n- let t2;\n- if ($[2] === Symbol.for(\"react.memo_cache_sentinel\")) {\n- t2 = { z: z, p: p, q: q, n: n, m: m, e: e, f: f };\n- $[2] = t2;\n+ const c_2 = $[2] !== z;\n+ const c_3 = $[3] !== p;\n+ const c_4 = $[4] !== q;\n+ const c_5 = $[5] !== n;\n+ const c_6 = $[6] !== m;\n+ const c_7 = $[7] !== e;\n+ const c_8 = $[8] !== f;\n+ let t0;\n+ if (c_2 || c_3 || c_4 || c_5 || c_6 || c_7 || c_8) {\n+ t0 = { z: z, p: p, q: q, n: n, m: m, e: e, f: f };\n+ $[2] = z;\n+ $[3] = p;\n+ $[4] = q;\n+ $[5] = n;\n+ $[6] = m;\n+ $[7] = e;\n+ $[8] = f;\n+ $[9] = t0;\n } else {\n- t2 = $[2];\n+ t0 = $[9];\n }\n- return t2;\n+ return t0;\n }\n \n ```\ndiff --git a\/compiler\/forget\/src\/tests\/fixtures\/hir\/update-expression.expect.md b\/compiler\/forget\/src\/tests\/fixtures\/hir\/update-expression.expect.md\nindex fdbff2d6eb..5f90acd09d 100644\n--- a\/compiler\/forget\/src\/tests\/fixtures\/hir\/update-expression.expect.md\n+++ b\/compiler\/forget\/src\/tests\/fixtures\/hir\/update-expression.expect.md\n@@ -21,12 +21,18 @@ function foo(props) {\n const y = x$0;\n const x$1 = x$0 - 1;\n const z = x$1;\n+ const c_0 = $[0] !== x$1;\n+ const c_1 = $[1] !== y;\n+ const c_2 = $[2] !== z;\n let t0;\n- if ($[0] === Symbol.for(\"react.memo_cache_sentinel\")) {\n+ if (c_0 || c_1 || c_2) {\n t0 = { x: x$1, y: y, z: z };\n- $[0] = t0;\n+ $[0] = x$1;\n+ $[1] = y;\n+ $[2] = z;\n+ $[3] = t0;\n } else {\n- t0 = $[0];\n+ t0 = $[3];\n }\n return t0;\n }\n","commit":{"subject":"[ReactiveHIR] Infer reactive identifiers and promote temporaries","shortRevision":"ecb084c4b8","revision":"ecb084c4b8b0e7dddadf5fce73e194a8b58d3187","authoredAt":"2023-02-03T14:52:46-05:00","authorName":"mofeiZ","authorEmail":"34200447+mofeiZ@users.noreply.github.com"},"body":"Messed up ghstack, this is a duplicate of #1093","files":[{"path":"compiler\/forget\/src\/CompilerPipeline.ts","status":"M"},{"path":"compiler\/forget\/src\/ReactiveScopes\/CodegenReactiveFunction.ts","status":"M"},{"path":"compiler\/forget\/src\/ReactiveScopes\/InferReactiveIdentifiers.ts","status":"A"},{"path":"compiler\/forget\/src\/ReactiveScopes\/PromoteUsedTemporaries.ts","status":"A"},{"path":"compiler\/forget\/src\/ReactiveScopes\/PropagateScopeDependencies.ts","status":"M"},{"path":"compiler\/forget\/src\/ReactiveScopes\/index.ts","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/alias-nested-member-path.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/call.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/capture-param-mutate.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/capturing-nested-member-call.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/capturing-nested-member-expr-in-nested-func.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/capturing-nested-member-expr.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/component.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/concise-arrow-expr.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/conditional-on-mutable.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/constructor.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/hook-call.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/independent-across-if.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/independent.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/independently-memoize-object-property.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/interdependent-across-if.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/interdependent.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/jsx-fragment.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/jsx-spread.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/logical-expression-object.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/logical-expression.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/object-pattern-params.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/overlapping-scopes-shadowing-within-block.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/property-assignment.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/reactive-scopes-if.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/reactive-scopes.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/reassignment-conditional.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/reassignment-separate-scopes.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/reassignment.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/sequence-expression.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/simple.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/ssa-call-jsx-2.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/ssa-call-jsx.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/ssa-property.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/switch-non-final-default.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/switch.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/ternary-expression.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/type-test-field-load-binary-op.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/type-test-polymorphic.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/unary-expr.expect.md","status":"M"},{"path":"compiler\/forget\/src\/tests\/fixtures\/hir\/update-expression.expect.md","status":"M"}],"parents":["34a7b58334011eace13767dc32c37a5336819983"]}

dillon1000/react

Files changed