{"commit":{"authorName":"Pieter De Baets","authorEmail":"pieterdb@meta.com","shortRevision":"ef8894452b","subject":"Rollout enablePersistedModeClonedFlag (#34520)","revision":"ef8894452b826f905d69e61435c6f2c30731bfa6","authoredAt":"2025-09-30T12:34:13+01:00"},"patch":"diff --git a\/packages\/react-native-renderer\/src\/__tests__\/ReactFabric-test.internal.js b\/packages\/react-native-renderer\/src\/__tests__\/ReactFabric-test.internal.js\nindex f8dbcfd17e..5bb90c24e6 100644\n--- a\/packages\/react-native-renderer\/src\/__tests__\/ReactFabric-test.internal.js\n+++ b\/packages\/react-native-renderer\/src\/__tests__\/ReactFabric-test.internal.js\n@@ -287,7 +287,6 @@ describe('ReactFabric', () => {\n expect(nativeFabricUIManager.completeRoot).toBeCalled();\n });\n \n- \/\/ @gate enablePersistedModeClonedFlag\n it('should not clone nodes when layout effects are used', async () => {\n const View = createReactNativeComponentClass('RCTView', () => ({\n validAttributes: {foo: true},\n@@ -305,6 +304,8 @@ describe('ReactFabric', () => {\n \n <\/View>,\n 11,\n+ null,\n+ true,\n ),\n );\n expect(nativeFabricUIManager.completeRoot).toBeCalled();\n@@ -316,6 +317,8 @@ describe('ReactFabric', () => {\n \n <\/View>,\n 11,\n+ null,\n+ true,\n ),\n );\n expect(nativeFabricUIManager.cloneNode).not.toBeCalled();\n@@ -327,7 +330,6 @@ describe('ReactFabric', () => {\n expect(nativeFabricUIManager.completeRoot).not.toBeCalled();\n });\n \n- \/\/ @gate enablePersistedModeClonedFlag\n it('should not clone nodes when insertion effects are used', async () => {\n const View = createReactNativeComponentClass('RCTView', () => ({\n validAttributes: {foo: true},\n@@ -345,6 +347,8 @@ describe('ReactFabric', () => {\n \n <\/View>,\n 11,\n+ null,\n+ true,\n ),\n );\n expect(nativeFabricUIManager.completeRoot).toBeCalled();\n@@ -356,6 +360,8 @@ describe('ReactFabric', () => {\n \n <\/View>,\n 11,\n+ null,\n+ true,\n ),\n );\n expect(nativeFabricUIManager.cloneNode).not.toBeCalled();\n@@ -367,7 +373,6 @@ describe('ReactFabric', () => {\n expect(nativeFabricUIManager.completeRoot).not.toBeCalled();\n });\n \n- \/\/ @gate enablePersistedModeClonedFlag\n it('should not clone nodes when useImperativeHandle is used', async () => {\n const View = createReactNativeComponentClass('RCTView', () => ({\n validAttributes: {foo: true},\n@@ -387,6 +392,8 @@ describe('ReactFabric', () => {\n \n <\/View>,\n 11,\n+ null,\n+ true,\n ),\n );\n expect(nativeFabricUIManager.completeRoot).toBeCalled();\n@@ -399,6 +406,8 @@ describe('ReactFabric', () => {\n \n <\/View>,\n 11,\n+ null,\n+ true,\n ),\n );\n expect(nativeFabricUIManager.cloneNode).not.toBeCalled();\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberCommitWork.js b\/packages\/react-reconciler\/src\/ReactFiberCommitWork.js\nindex 124d17f943..6be3300a70 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberCommitWork.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberCommitWork.js\n@@ -48,7 +48,6 @@ import {\n alwaysThrottleRetries,\n enableCreateEventHandleAPI,\n enableHiddenSubtreeInsertionEffectCleanup,\n- enablePersistedModeClonedFlag,\n enableProfilerTimer,\n enableProfilerCommitHooks,\n enableSuspenseCallback,\n@@ -1969,10 +1968,7 @@ function recursivelyTraverseMutationEffects(\n }\n }\n \n- if (\n- parentFiber.subtreeFlags &\n- (enablePersistedModeClonedFlag ? MutationMask | Cloned : MutationMask)\n- ) {\n+ if (parentFiber.subtreeFlags & (MutationMask | Cloned)) {\n let child = parentFiber.child;\n while (child !== null) {\n commitMutationEffectsOnFiber(child, root, lanes);\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberCompleteWork.js b\/packages\/react-reconciler\/src\/ReactFiberCompleteWork.js\nindex 404fd86c9d..d3abcb466e 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberCompleteWork.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberCompleteWork.js\n@@ -35,7 +35,6 @@ import {\n enableLegacyHidden,\n enableSuspenseCallback,\n enableScopeAPI,\n- enablePersistedModeClonedFlag,\n enableProfilerTimer,\n enableTransitionTracing,\n passChildrenWhenCloningPersistedNodes,\n@@ -92,7 +91,6 @@ import {\n Snapshot,\n ChildDeletion,\n StaticMask,\n- MutationMask,\n Passive,\n ForceClientRender,\n MaySuspendCommit,\n@@ -205,7 +203,7 @@ function markUpdate(workInProgress: Fiber) {\n * it received an update that requires a clone of the tree above.\n *\/\n function markCloned(workInProgress: Fiber) {\n- if (supportsPersistence && enablePersistedModeClonedFlag) {\n+ if (supportsPersistence) {\n workInProgress.flags |= Cloned;\n }\n }\n@@ -227,9 +225,7 @@ function doesRequireClone(current: null | Fiber, completedWork: Fiber) {\n \/\/ then we only have to check the `completedWork.subtreeFlags`.\n let child = completedWork.child;\n while (child !== null) {\n- const checkedFlags = enablePersistedModeClonedFlag\n- ? Cloned | Visibility | Placement | ChildDeletion\n- : MutationMask;\n+ const checkedFlags = Cloned | Visibility | Placement | ChildDeletion;\n if (\n (child.flags & checkedFlags) !== NoFlags ||\n (child.subtreeFlags & checkedFlags) !== NoFlags\n@@ -526,16 +522,9 @@ function updateHostComponent(\n markUpdate(workInProgress);\n }\n workInProgress.stateNode = newInstance;\n- if (!requiresClone) {\n- if (!enablePersistedModeClonedFlag) {\n- \/\/ If there are no other effects in this tree, we need to flag this node as having one.\n- \/\/ Even though we're not going to use it for anything.\n- \/\/ Otherwise parents won't know that there are new children to propagate upwards.\n- markUpdate(workInProgress);\n- }\n- } else if (\n- !passChildrenWhenCloningPersistedNodes ||\n- hasOffscreenComponentChild\n+ if (\n+ requiresClone &&\n+ (!passChildrenWhenCloningPersistedNodes || hasOffscreenComponentChild)\n ) {\n \/\/ If children have changed, we have to add them all to the set.\n appendAllChildren(\n@@ -693,11 +682,6 @@ function updateHostText(\n currentHostContext,\n workInProgress,\n );\n- if (!enablePersistedModeClonedFlag) {\n- \/\/ We'll have to mark it as having an effect, even though we won't use the effect for anything.\n- \/\/ This lets the parents know that at least one of their children has changed.\n- markUpdate(workInProgress);\n- }\n } else {\n workInProgress.stateNode = current.stateNode;\n }\ndiff --git a\/packages\/shared\/ReactFeatureFlags.js b\/packages\/shared\/ReactFeatureFlags.js\nindex f29ee68d74..a352ca8dee 100644\n--- a\/packages\/shared\/ReactFeatureFlags.js\n+++ b\/packages\/shared\/ReactFeatureFlags.js\n@@ -129,12 +129,6 @@ export const alwaysThrottleRetries: boolean = true;\n \n export const passChildrenWhenCloningPersistedNodes: boolean = false;\n \n-\/**\n- * Enables a new Fiber flag used in persisted mode to reduce the number\n- * of cloned host components.\n- *\/\n-export const enablePersistedModeClonedFlag: boolean = false;\n-\n export const enableEagerAlternateStateNodeCleanup: boolean = true;\n \n \/**\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb-dynamic.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb-dynamic.js\nindex 0b59327b34..0cbcd61a87 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb-dynamic.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb-dynamic.js\n@@ -20,7 +20,6 @@\n export const alwaysThrottleRetries = __VARIANT__;\n export const enableObjectFiber = __VARIANT__;\n export const enableHiddenSubtreeInsertionEffectCleanup = __VARIANT__;\n-export const enablePersistedModeClonedFlag = __VARIANT__;\n export const enableEagerAlternateStateNodeCleanup = __VARIANT__;\n export const passChildrenWhenCloningPersistedNodes = __VARIANT__;\n export const renameElementSymbol = __VARIANT__;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\nindex 409b10d0b2..b6cadd1d2e 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n@@ -22,7 +22,6 @@ export const {\n alwaysThrottleRetries,\n enableHiddenSubtreeInsertionEffectCleanup,\n enableObjectFiber,\n- enablePersistedModeClonedFlag,\n enableEagerAlternateStateNodeCleanup,\n passChildrenWhenCloningPersistedNodes,\n renameElementSymbol,\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\nindex fbef31b026..7d8456cffb 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n@@ -38,7 +38,6 @@ export const enableLegacyFBSupport: boolean = false;\n export const enableLegacyHidden: boolean = false;\n export const enableNoCloningMemoCache: boolean = false;\n export const enableObjectFiber: boolean = false;\n-export const enablePersistedModeClonedFlag: boolean = false;\n export const enablePostpone: boolean = false;\n export const enableReactTestRendererWarning: boolean = false;\n export const enableRetryLaneExpiration: boolean = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\nindex eb02b6a180..260cde9361 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n@@ -53,7 +53,6 @@ export const enableFizzExternalRuntime: boolean = true;\n export const alwaysThrottleRetries: boolean = true;\n \n export const passChildrenWhenCloningPersistedNodes: boolean = false;\n-export const enablePersistedModeClonedFlag: boolean = false;\n export const disableClientCache: boolean = true;\n \n export const enableInfiniteRenderLoopDetection: boolean = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native-fb.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native-fb.js\nindex 768ab592d2..1a46f0d038 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native-fb.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native-fb.js\n@@ -33,7 +33,6 @@ export const enableLegacyFBSupport = false;\n export const enableLegacyHidden = false;\n export const enableNoCloningMemoCache = false;\n export const enableObjectFiber = false;\n-export const enablePersistedModeClonedFlag = false;\n export const enablePostpone = false;\n export const enableProfilerCommitHooks = __PROFILE__;\n export const enableProfilerNestedUpdatePhase = __PROFILE__;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\nindex c0c788db52..ecb165af6b 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n@@ -54,7 +54,6 @@ export const enableFizzExternalRuntime: boolean = false;\n export const alwaysThrottleRetries: boolean = true;\n \n export const passChildrenWhenCloningPersistedNodes: boolean = false;\n-export const enablePersistedModeClonedFlag: boolean = false;\n export const disableClientCache: boolean = true;\n \n export const enableInfiniteRenderLoopDetection: boolean = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\nindex 408fc0b62f..732e4e143e 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n@@ -93,8 +93,6 @@ export const enableFizzExternalRuntime: boolean = true;\n \n export const passChildrenWhenCloningPersistedNodes: boolean = false;\n \n-export const enablePersistedModeClonedFlag: boolean = false;\n-\n export const disableClientCache: boolean = true;\n \n export const enableReactTestRendererWarning: boolean = false;\n","parents":["e6f2a8a376f81faefbbc7f5af411a904eb778dfc"],"files":[{"path":"packages\/react-native-renderer\/src\/__tests__\/ReactFabric-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberCommitWork.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberCompleteWork.js","status":"M"},{"path":"packages\/shared\/ReactFeatureFlags.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.native-fb-dynamic.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.native-fb.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.native-oss.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native-fb.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.www.js","status":"M"}],"body":"## Summary\n\nExperimentation has completed for this at Meta and we've observed\npositive impact on key React Native surfaces.\n\n## How did you test this change?\n\nyarn flow fabric"}

dillon1000/react

Files changed