{"commit":{"revision":"f02a5f5c79eed4a200afe477452b6b7a680c16af","authorName":"Jan Kassens","subject":"Flow upgrade to 0.182","authorEmail":"jkassens@meta.com","authoredAt":"2022-10-04T13:25:17-04:00","shortRevision":"f02a5f5c79"},"files":[{"status":"M","path":"package.json"},{"status":"M","path":"packages\/react-devtools-inline\/src\/backend.js"},{"status":"M","path":"packages\/react-devtools-inline\/src\/frontend.js"},{"status":"M","path":"packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.core-fb.js"},{"status":"M","path":"packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.core-oss.js"},{"status":"M","path":"packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.extension-fb.js"},{"status":"M","path":"packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.extension-oss.js"},{"status":"M","path":"packages\/react-devtools-shared\/src\/devtools\/views\/Settings\/SettingsModal.js"},{"status":"M","path":"packages\/react-dom-bindings\/src\/client\/ReactDOMFloatClient.js"},{"status":"M","path":"packages\/react-dom-bindings\/src\/events\/forks\/EventListener-www.js"},{"status":"M","path":"packages\/react\/src\/ReactStartTransition.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.native-fb-dynamic.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.native-fb.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.native-oss.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.testing.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.testing.www.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.www.js"},{"status":"M","path":"scripts\/flow\/config\/flowconfig"},{"status":"M","path":"yarn.lock"}],"body":"ghstack-source-id: b9bb8c1560e8ac6baf424deea2015c00629fb353\nPull Request resolved: https:\/\/github.com\/facebook\/react\/pull\/25419","parents":["72593f008ec2011104d78b460dd287e7dfcac838"],"patch":"diff --git a\/package.json b\/package.json\nindex 6b7571870f..b3c2542034 100644\n--- a\/package.json\n+++ b\/package.json\n@@ -63,7 +63,7 @@\n \"eslint-plugin-react-internal\": \"link:.\/scripts\/eslint-rules\",\n \"fbjs-scripts\": \"1.2.0\",\n \"filesize\": \"^6.0.1\",\n- \"flow-bin\": \"^0.176.0\",\n+ \"flow-bin\": \"^0.182.0\",\n \"glob\": \"^7.1.6\",\n \"glob-stream\": \"^6.1.0\",\n \"google-closure-compiler\": \"^20200517.0.0\",\ndiff --git a\/packages\/react-devtools-inline\/src\/backend.js b\/packages\/react-devtools-inline\/src\/backend.js\nindex 234c7f5f88..97d2368ac1 100644\n--- a\/packages\/react-devtools-inline\/src\/backend.js\n+++ b\/packages\/react-devtools-inline\/src\/backend.js\n@@ -80,6 +80,7 @@ export function activate(\n bridge,\n }: {\n bridge?: BackendBridge,\n+ \/\/ $FlowFixMe[incompatible-exact]\n } = {},\n ): void {\n if (bridge == null) {\ndiff --git a\/packages\/react-devtools-inline\/src\/frontend.js b\/packages\/react-devtools-inline\/src\/frontend.js\nindex 1e5ea336a4..272fbba0b9 100644\n--- a\/packages\/react-devtools-inline\/src\/frontend.js\n+++ b\/packages\/react-devtools-inline\/src\/frontend.js\n@@ -62,6 +62,7 @@ export function initialize(\n }: {\n bridge?: FrontendBridge,\n store?: Store,\n+ \/\/ $FlowFixMe[incompatible-exact]\n } = {},\n ): React.AbstractComponent {\n if (bridge == null) {\ndiff --git a\/packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.core-fb.js b\/packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.core-fb.js\nindex 59b8e61a42..41d7d0aa11 100644\n--- a\/packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.core-fb.js\n+++ b\/packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.core-fb.js\n@@ -29,7 +29,5 @@ export const enableProfilerComponentTree = true;\n import typeof * as FeatureFlagsType from '.\/DevToolsFeatureFlags.default';\n import typeof * as ExportsType from '.\/DevToolsFeatureFlags.core-fb';\n \n-\/\/ eslint-disable-next-line no-unused-vars\n-type Check<_X, Y: _X, X: Y = _X> = null;\n-\/\/ eslint-disable-next-line no-unused-expressions\n-(null: Check);\n+\/\/ Flow magic to verify the exports of this file match the original version.\n+((((null: any): ExportsType): FeatureFlagsType): ExportsType);\ndiff --git a\/packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.core-oss.js b\/packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.core-oss.js\nindex 8102c6b751..1811dc3411 100644\n--- a\/packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.core-oss.js\n+++ b\/packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.core-oss.js\n@@ -29,7 +29,5 @@ export const enableProfilerComponentTree = true;\n import typeof * as FeatureFlagsType from '.\/DevToolsFeatureFlags.default';\n import typeof * as ExportsType from '.\/DevToolsFeatureFlags.core-oss';\n \n-\/\/ eslint-disable-next-line no-unused-vars\n-type Check<_X, Y: _X, X: Y = _X> = null;\n-\/\/ eslint-disable-next-line no-unused-expressions\n-(null: Check);\n+\/\/ Flow magic to verify the exports of this file match the original version.\n+((((null: any): ExportsType): FeatureFlagsType): ExportsType);\ndiff --git a\/packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.extension-fb.js b\/packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.extension-fb.js\nindex 76d5546efb..ffe795786b 100644\n--- a\/packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.extension-fb.js\n+++ b\/packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.extension-fb.js\n@@ -29,7 +29,5 @@ export const enableProfilerComponentTree = true;\n import typeof * as FeatureFlagsType from '.\/DevToolsFeatureFlags.default';\n import typeof * as ExportsType from '.\/DevToolsFeatureFlags.extension-fb';\n \n-\/\/ eslint-disable-next-line no-unused-vars\n-type Check<_X, Y: _X, X: Y = _X> = null;\n-\/\/ eslint-disable-next-line no-unused-expressions\n-(null: Check);\n+\/\/ Flow magic to verify the exports of this file match the original version.\n+((((null: any): ExportsType): FeatureFlagsType): ExportsType);\ndiff --git a\/packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.extension-oss.js b\/packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.extension-oss.js\nindex 2e6cabf4b5..b006b25e7d 100644\n--- a\/packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.extension-oss.js\n+++ b\/packages\/react-devtools-shared\/src\/config\/DevToolsFeatureFlags.extension-oss.js\n@@ -29,7 +29,5 @@ export const enableProfilerComponentTree = true;\n import typeof * as FeatureFlagsType from '.\/DevToolsFeatureFlags.default';\n import typeof * as ExportsType from '.\/DevToolsFeatureFlags.extension-oss';\n \n-\/\/ eslint-disable-next-line no-unused-vars\n-type Check<_X, Y: _X, X: Y = _X> = null;\n-\/\/ eslint-disable-next-line no-unused-expressions\n-(null: Check);\n+\/\/ Flow magic to verify the exports of this file match the original version.\n+((((null: any): ExportsType): FeatureFlagsType): ExportsType);\ndiff --git a\/packages\/react-devtools-shared\/src\/devtools\/views\/Settings\/SettingsModal.js b\/packages\/react-devtools-shared\/src\/devtools\/views\/Settings\/SettingsModal.js\nindex 58377f9696..bafaf237d4 100644\n--- a\/packages\/react-devtools-shared\/src\/devtools\/views\/Settings\/SettingsModal.js\n+++ b\/packages\/react-devtools-shared\/src\/devtools\/views\/Settings\/SettingsModal.js\n@@ -82,6 +82,7 @@ function SettingsModalImpl(_: {}) {\n case 'components':\n view = ;\n break;\n+ \/\/ $FlowFixMe[incompatible-type] is this missing in TabID?\n case 'debugging':\n view = ;\n break;\ndiff --git a\/packages\/react-dom-bindings\/src\/client\/ReactDOMFloatClient.js b\/packages\/react-dom-bindings\/src\/client\/ReactDOMFloatClient.js\nindex 0658e14134..dbe7444014 100644\n--- a\/packages\/react-dom-bindings\/src\/client\/ReactDOMFloatClient.js\n+++ b\/packages\/react-dom-bindings\/src\/client\/ReactDOMFloatClient.js\n@@ -657,6 +657,7 @@ function acquireStyleResource(resource: StyleResource): Instance {\n }\n }\n resource.count++;\n+ \/\/ $FlowFixMe[incompatible-return] found when upgrading Flow\n return resource.instance;\n }\n \ndiff --git a\/packages\/react-dom-bindings\/src\/events\/forks\/EventListener-www.js b\/packages\/react-dom-bindings\/src\/events\/forks\/EventListener-www.js\nindex b9f20cca80..1055979bcf 100644\n--- a\/packages\/react-dom-bindings\/src\/events\/forks\/EventListener-www.js\n+++ b\/packages\/react-dom-bindings\/src\/events\/forks\/EventListener-www.js\n@@ -66,7 +66,4 @@ export function removeEventListener(\n }\n \n \/\/ Flow magic to verify the exports of this file match the original version.\n-\/\/ eslint-disable-next-line no-unused-vars\n-type Check<_X, Y: _X, X: Y = _X> = null;\n-\/\/ eslint-disable-next-line no-unused-expressions\n-(null: Check);\n+((((null: any): EventListenerType): EventListenerShimType): EventListenerType);\ndiff --git a\/packages\/react\/src\/ReactStartTransition.js b\/packages\/react\/src\/ReactStartTransition.js\nindex 678daf9832..daafea7e9e 100644\n--- a\/packages\/react\/src\/ReactStartTransition.js\n+++ b\/packages\/react\/src\/ReactStartTransition.js\n@@ -26,7 +26,9 @@ export function startTransition(\n \n if (enableTransitionTracing) {\n if (options !== undefined && options.name !== undefined) {\n+ \/\/ $FlowFixMe[incompatible-use] found when upgrading Flow\n ReactCurrentBatchConfig.transition.name = options.name;\n+ \/\/ $FlowFixMe[incompatible-use] found when upgrading Flow\n ReactCurrentBatchConfig.transition.startTime = -1;\n }\n }\n@@ -46,6 +48,7 @@ export function startTransition(\n 'Otherwise concurrent mode guarantees are off the table.',\n );\n }\n+ \/\/ $FlowFixMe[incompatible-use] found when upgrading Flow\n currentTransition._updatedFibers.clear();\n }\n }\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb-dynamic.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb-dynamic.js\nindex 7138679c53..6e9aaacf0e 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb-dynamic.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb-dynamic.js\n@@ -23,7 +23,4 @@\n \/\/ update the test configuration.\n \n \/\/ \/\/ Flow magic to verify the exports of this file match the original version.\n-\/\/ \/\/ eslint-disable-next-line no-unused-vars\n-\/\/ type Check<_X, Y: _X, X: Y = _X> = null;\n-\/\/ \/\/ eslint-disable-next-line no-unused-expressions\n-\/\/ (null: Check);\n+\/\/ ((((null: any): ExportsType): FeatureFlagsType): ExportsType);\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\nindex 821f947415..beafb67bf0 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n@@ -86,8 +86,6 @@ export const enableTransitionTracing = false;\n export const enableFloat = false;\n \n export const useModernStrictMode = false;\n+\n \/\/ Flow magic to verify the exports of this file match the original version.\n-\/\/ eslint-disable-next-line no-unused-vars\n-type Check<_X, Y: _X, X: Y = _X> = null;\n-\/\/ eslint-disable-next-line no-unused-expressions\n-(null: Check);\n+((((null: any): ExportsType): FeatureFlagsType): ExportsType);\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\nindex c63c218700..3fdedac111 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n@@ -75,8 +75,6 @@ export const enableTransitionTracing = false;\n export const enableFloat = false;\n \n export const useModernStrictMode = false;\n+\n \/\/ Flow magic to verify the exports of this file match the original version.\n-\/\/ eslint-disable-next-line no-unused-vars\n-type Check<_X, Y: _X, X: Y = _X> = null;\n-\/\/ eslint-disable-next-line no-unused-expressions\n-(null: Check);\n+((((null: any): ExportsType): FeatureFlagsType): ExportsType);\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\nindex 665c42cb8f..ce7afbcef7 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n@@ -75,8 +75,6 @@ export const enableTransitionTracing = false;\n export const enableFloat = false;\n \n export const useModernStrictMode = false;\n+\n \/\/ Flow magic to verify the exports of this file match the original version.\n-\/\/ eslint-disable-next-line no-unused-vars\n-type Check<_X, Y: _X, X: Y = _X> = null;\n-\/\/ eslint-disable-next-line no-unused-expressions\n-(null: Check);\n+((((null: any): ExportsType): FeatureFlagsType): ExportsType);\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js\nindex c48df6576e..7d9054bfeb 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js\n@@ -73,8 +73,6 @@ export const enableTransitionTracing = false;\n export const enableFloat = false;\n \n export const useModernStrictMode = false;\n+\n \/\/ Flow magic to verify the exports of this file match the original version.\n-\/\/ eslint-disable-next-line no-unused-vars\n-type Check<_X, Y: _X, X: Y = _X> = null;\n-\/\/ eslint-disable-next-line no-unused-expressions\n-(null: Check);\n+((((null: any): ExportsType): FeatureFlagsType): ExportsType);\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\nindex d4e135d655..38278fbc93 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n@@ -77,8 +77,6 @@ export const enableTransitionTracing = false;\n export const enableFloat = false;\n \n export const useModernStrictMode = false;\n+\n \/\/ Flow magic to verify the exports of this file match the original version.\n-\/\/ eslint-disable-next-line no-unused-vars\n-type Check<_X, Y: _X, X: Y = _X> = null;\n-\/\/ eslint-disable-next-line no-unused-expressions\n-(null: Check);\n+((((null: any): ExportsType): FeatureFlagsType): ExportsType);\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.testing.js b\/packages\/shared\/forks\/ReactFeatureFlags.testing.js\nindex f77ed6fa13..308aaed94d 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.testing.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.testing.js\n@@ -75,8 +75,6 @@ export const enableTransitionTracing = false;\n export const enableFloat = false;\n \n export const useModernStrictMode = false;\n+\n \/\/ Flow magic to verify the exports of this file match the original version.\n-\/\/ eslint-disable-next-line no-unused-vars\n-type Check<_X, Y: _X, X: Y = _X> = null;\n-\/\/ eslint-disable-next-line no-unused-expressions\n-(null: Check);\n+((((null: any): ExportsType): FeatureFlagsType): ExportsType);\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js\nindex 1c78538140..89b24c8ed6 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js\n@@ -76,8 +76,6 @@ export const enableTransitionTracing = false;\n export const enableFloat = false;\n \n export const useModernStrictMode = false;\n+\n \/\/ Flow magic to verify the exports of this file match the original version.\n-\/\/ eslint-disable-next-line no-unused-vars\n-type Check<_X, Y: _X, X: Y = _X> = null;\n-\/\/ eslint-disable-next-line no-unused-expressions\n-(null: Check);\n+((((null: any): ExportsType): FeatureFlagsType): ExportsType);\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\nindex f8566f9ecb..1811c9bf7c 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n@@ -112,8 +112,6 @@ export const enableUseMutableSource = true;\n export const enableCustomElementPropertySupport = __EXPERIMENTAL__;\n \n export const useModernStrictMode = false;\n+\n \/\/ Flow magic to verify the exports of this file match the original version.\n-\/\/ eslint-disable-next-line no-unused-vars\n-type Check<_X, Y: _X, X: Y = _X> = null;\n-\/\/ eslint-disable-next-line no-unused-expressions\n-(null: Check);\n+((((null: any): ExportsType): FeatureFlagsType): ExportsType);\ndiff --git a\/scripts\/flow\/config\/flowconfig b\/scripts\/flow\/config\/flowconfig\nindex 470bd08692..fadeb06f0b 100644\n--- a\/scripts\/flow\/config\/flowconfig\n+++ b\/scripts\/flow\/config\/flowconfig\n@@ -48,4 +48,4 @@ munge_underscores=false\n %REACT_RENDERER_FLOW_OPTIONS%\n \n [version]\n-^0.176.0\n+^0.182.0\ndiff --git a\/yarn.lock b\/yarn.lock\nindex e5bf340809..696a20379a 100644\n--- a\/yarn.lock\n+++ b\/yarn.lock\n@@ -7912,10 +7912,10 @@ flatted@^2.0.0:\n resolved \"https:\/\/registry.yarnpkg.com\/flatted\/-\/flatted-2.0.2.tgz#4575b21e2bcee7434aa9be662f4b7b5f9c2b5138\"\n integrity sha512-r5wGx7YeOwNWNlCA0wQ86zKyDLMQr+\/RB8xy74M4hTphfmjlijTSSXGuH8rnvKZnfT9i+75zmd8jcKdMR4O6jA==\n \n-flow-bin@^0.176.0:\n- version \"0.176.3\"\n- resolved \"https:\/\/registry.yarnpkg.com\/flow-bin\/-\/flow-bin-0.176.3.tgz#d32de04e044ab474afe543b9fd245608bb6a6ac8\"\n- integrity sha512-lbNqgjr2GlGLAEVp5+dhG4LdnFE7ekbvVNifAdlvTx58\/nE8GrCOMiUwEQy4dLnfL2NIRMk2dbEVTrugeQJ3mA==\n+flow-bin@^0.182.0:\n+ version \"0.182.0\"\n+ resolved \"https:\/\/registry.yarnpkg.com\/flow-bin\/-\/flow-bin-0.182.0.tgz#1dacbd72465743670412ada015d3182deda6f966\"\n+ integrity sha512-Ux90c2sMfoV\/VVjOEFT2OHFJFnyfoIbTK\/5AKAMnU4Skfru1G+FyS5YLu3XxQl0R6mpA9+rrFlPfYZq\/5B+J3w==\n \n fluent-syntax@0.13.0:\n version \"0.13.0\"\n"}

dillon1000/react

Files changed