{"files":[{"status":"M","path":"src\/__tests__\/__snapshots__\/profilingCharts-test.js.snap"},{"status":"M","path":"src\/devtools\/views\/Profiler\/ChartNode.js"},{"status":"M","path":"src\/devtools\/views\/Profiler\/CommitFlamegraph.css"},{"status":"M","path":"src\/devtools\/views\/Profiler\/CommitFlamegraph.js"},{"status":"M","path":"src\/devtools\/views\/Profiler\/CommitFlamegraphListItem.js"},{"status":"M","path":"src\/devtools\/views\/Profiler\/FlamegraphChartBuilder.js"},{"status":"M","path":"src\/devtools\/views\/Profiler\/InteractionListItem.css"},{"status":"M","path":"src\/devtools\/views\/Profiler\/SnapshotCommitListItem.css"},{"status":"M","path":"src\/devtools\/views\/Settings\/SettingsContext.js"},{"status":"M","path":"src\/devtools\/views\/root.css"}],"parents":["6fd2e72b5e06358ebe6ab719edbbde2a1845ce4a"],"body":"","commit":{"subject":"Improve scanning Profiler chart for deep renders","authoredAt":"2019-05-15T14:15:14-07:00","revision":"f10a6b379ca2de83bb46ee17a267d3e478776fc1","authorName":"Brian Vaughn","authorEmail":"bvaughn@fb.com","shortRevision":"f10a6b379c"},"patch":"diff --git a\/src\/__tests__\/__snapshots__\/profilingCharts-test.js.snap b\/src\/__tests__\/__snapshots__\/profilingCharts-test.js.snap\nindex 9da03f5935..043ac17f80 100644\n--- a\/src\/__tests__\/__snapshots__\/profilingCharts-test.js.snap\n+++ b\/src\/__tests__\/__snapshots__\/profilingCharts-test.js.snap\n@@ -70,6 +70,10 @@ Object {\n 3 => 2,\n },\n \"maxSelfDuration\": 10,\n+ \"renderPathNodes\": Set {\n+ 1,\n+ 3,\n+ },\n \"rows\": Array [\n Array [\n Object {\n@@ -189,6 +193,9 @@ Object {\n 3 => 2,\n },\n \"maxSelfDuration\": 10,\n+ \"renderPathNodes\": Set {\n+ 1,\n+ },\n \"rows\": Array [\n Array [\n Object {\ndiff --git a\/src\/devtools\/views\/Profiler\/ChartNode.js b\/src\/devtools\/views\/Profiler\/ChartNode.js\nindex b739434e63..121f46ecb2 100644\n--- a\/src\/devtools\/views\/Profiler\/ChartNode.js\n+++ b\/src\/devtools\/views\/Profiler\/ChartNode.js\n@@ -13,6 +13,7 @@ type Props = {|\n onClick: (event: SyntheticMouseEvent<*>) => mixed,\n onDoubleClick?: (event: SyntheticMouseEvent<*>) => mixed,\n placeLabelAboveNode?: boolean,\n+ textStyle?: Object,\n width: number,\n x: number,\n y: number,\n@@ -27,6 +28,7 @@ export default function ChartNode({\n label,\n onClick,\n onDoubleClick,\n+ textStyle,\n width,\n x,\n y,\n@@ -57,7 +59,9 @@ export default function ChartNode({\n }}\n y={height < textHeight ? -textHeight : 0}\n >\n-

{label}<\/div>\n+

\n+ {label}\n+ <\/div>\n <\/foreignObject>\n )}\n <\/g>\ndiff --git a\/src\/devtools\/views\/Profiler\/CommitFlamegraph.css b\/src\/devtools\/views\/Profiler\/CommitFlamegraph.css\nindex bc441e485e..d9ab14ef3c 100644\n--- a\/src\/devtools\/views\/Profiler\/CommitFlamegraph.css\n+++ b\/src\/devtools\/views\/Profiler\/CommitFlamegraph.css\n@@ -3,3 +3,8 @@\n height: 100%;\n padding: 0.5rem;\n }\n+\n+.PatternPath {\n+ stroke: var(--color-commit-did-not-render-pattern);\n+ stroke-width: 1;\n+}\ndiff --git a\/src\/devtools\/views\/Profiler\/CommitFlamegraph.js b\/src\/devtools\/views\/Profiler\/CommitFlamegraph.js\nindex 881da0e77b..9827224152 100644\n--- a\/src\/devtools\/views\/Profiler\/CommitFlamegraph.js\n+++ b\/src\/devtools\/views\/Profiler\/CommitFlamegraph.js\n@@ -1,6 +1,6 @@\n \/\/ @flow\n \n-import React, { useCallback, useContext, useMemo } from 'react';\n+import React, { forwardRef, useCallback, useContext, useMemo } from 'react';\n import AutoSizer from 'react-virtualized-auto-sizer';\n import { FixedSizeList } from 'react-window';\n import { ProfilerContext } from '.\/ProfilerContext';\n@@ -152,7 +152,7 @@ function CommitFlamegraph({\n return (\n \n );\n }\n+\n+const InnerElementType = forwardRef(({ children, ...rest }, ref) => (\n+

dillon1000/react

Files changed