{"parents":["f3a70990a5a03bb26e6a71e43c204849392d2b07"],"files":[{"path":"packages\/react-devtools-shared\/src\/__tests__\/useEditableValue-test.js","status":"M"}],"commit":{"authoredAt":"2024-02-05T17:11:22+00:00","subject":"chore: use versioned render in useEditableValue test (#28212)","revision":"f244fd3884adbe5717b7e46da18911e9899cade9","shortRevision":"f244fd3884","authorName":"Ruslan Lesiutin","authorEmail":"rdlesyutin@gmail.com"},"patch":"diff --git a\/packages\/react-devtools-shared\/src\/__tests__\/useEditableValue-test.js b\/packages\/react-devtools-shared\/src\/__tests__\/useEditableValue-test.js\nindex d3ae11df79..61b538e2d2 100644\n--- a\/packages\/react-devtools-shared\/src\/__tests__\/useEditableValue-test.js\n+++ b\/packages\/react-devtools-shared\/src\/__tests__\/useEditableValue-test.js\n@@ -7,22 +7,24 @@\n * @flow\n *\/\n \n+import {getVersionedRenderImplementation} from '.\/utils';\n+\n describe('useEditableValue', () => {\n let act;\n let React;\n- let legacyRender;\n let useEditableValue;\n \n beforeEach(() => {\n const utils = require('.\/utils');\n act = utils.act;\n- legacyRender = utils.legacyRender;\n \n React = require('react');\n \n useEditableValue = require('..\/devtools\/views\/hooks').useEditableValue;\n });\n \n+ const {render} = getVersionedRenderImplementation();\n+\n it('should not cause a loop with values like NaN', () => {\n let state;\n \n@@ -32,8 +34,8 @@ describe('useEditableValue', () => {\n return null;\n }\n \n- const container = document.createElement('div');\n- legacyRender(, container);\n+ act(() => render());\n+\n expect(state.editableValue).toEqual('NaN');\n expect(state.externalValue).toEqual(NaN);\n expect(state.parsedValue).toEqual(NaN);\n@@ -50,8 +52,8 @@ describe('useEditableValue', () => {\n return null;\n }\n \n- const container = document.createElement('div');\n- legacyRender(, container);\n+ act(() => render());\n+\n expect(state.editableValue).toEqual('1');\n expect(state.externalValue).toEqual(1);\n expect(state.parsedValue).toEqual(1);\n@@ -60,7 +62,8 @@ describe('useEditableValue', () => {\n \n \/\/ If there are NO pending changes,\n \/\/ an update to the external prop value should override the local\/pending value.\n- legacyRender(, container);\n+ act(() => render());\n+\n expect(state.editableValue).toEqual('2');\n expect(state.externalValue).toEqual(2);\n expect(state.parsedValue).toEqual(2);\n@@ -78,8 +81,8 @@ describe('useEditableValue', () => {\n return null;\n }\n \n- const container = document.createElement('div');\n- legacyRender(, container);\n+ act(() => render());\n+\n expect(state.editableValue).toEqual('1');\n expect(state.externalValue).toEqual(1);\n expect(state.parsedValue).toEqual(1);\n@@ -102,7 +105,8 @@ describe('useEditableValue', () => {\n \n \/\/ If there ARE pending changes,\n \/\/ an update to the external prop value should NOT override the local\/pending value.\n- legacyRender(, container);\n+ act(() => render());\n+\n expect(state.editableValue).toEqual('2');\n expect(state.externalValue).toEqual(3);\n expect(state.parsedValue).toEqual(2);\n@@ -120,8 +124,8 @@ describe('useEditableValue', () => {\n return null;\n }\n \n- const container = document.createElement('div');\n- legacyRender(, container);\n+ act(() => render());\n+\n expect(state.editableValue).toEqual('1');\n expect(state.externalValue).toEqual(1);\n expect(state.parsedValue).toEqual(1);\n@@ -153,8 +157,8 @@ describe('useEditableValue', () => {\n return null;\n }\n \n- const container = document.createElement('div');\n- legacyRender(, container);\n+ act(() => render());\n+\n expect(state.editableValue).toEqual('1');\n expect(state.externalValue).toEqual(1);\n expect(state.parsedValue).toEqual(1);\n","body":""}

dillon1000/react

Files changed