{"commit":{"authoredAt":"2023-12-04T16:10:36-05:00","authorEmail":"jkassens@meta.com","shortRevision":"f498aa2992","subject":"Flow: make more objects exact (#27790)","revision":"f498aa299292d4d1e999f66d1c769440ad10d57c","authorName":"Jan Kassens"},"body":"This makes a couple objects more exact. Nothing critical, just noticed\r\nthis old branch I had created when doing some Flow upgrades in the past.","parents":["223db40d5a04dc3311f963f5296675f7f43139e8"],"patch":"diff --git a\/packages\/react-debug-tools\/src\/ReactDebugHooks.js b\/packages\/react-debug-tools\/src\/ReactDebugHooks.js\nindex 7e2e2effb1..1110415482 100644\n--- a\/packages\/react-debug-tools\/src\/ReactDebugHooks.js\n+++ b\/packages\/react-debug-tools\/src\/ReactDebugHooks.js\n@@ -36,7 +36,6 @@ type HookLogEntry = {\n primitive: string,\n stackError: Error,\n value: mixed,\n- ...\n };\n \n let hookLog: Array = [];\n@@ -408,7 +407,6 @@ export type HooksNode = {\n value: mixed,\n subHooks: Array,\n hookSource?: HookSource,\n- ...\n };\n export type HooksTree = Array;\n \ndiff --git a\/packages\/react-devtools-core\/src\/backend.js b\/packages\/react-devtools-core\/src\/backend.js\nindex 72674a0a8c..ee26ff35a4 100644\n--- a\/packages\/react-devtools-core\/src\/backend.js\n+++ b\/packages\/react-devtools-core\/src\/backend.js\n@@ -36,7 +36,6 @@ type ConnectOptions = {\n isAppActive?: () => boolean,\n websocket?: ?WebSocket,\n devToolsSettingsManager: ?DevToolsSettingsManager,\n- ...\n };\n \n \/\/ Install a global variable to allow patching console early (during injection).\ndiff --git a\/packages\/react-devtools-shared\/src\/devtools\/cache.js b\/packages\/react-devtools-shared\/src\/devtools\/cache.js\nindex c8f62ba385..4bb44bacb3 100644\n--- a\/packages\/react-devtools-shared\/src\/devtools\/cache.js\n+++ b\/packages\/react-devtools-shared\/src\/devtools\/cache.js\n@@ -53,7 +53,6 @@ export type Resource = {\n read(Input): Value,\n preload(Input): void,\n write(Key, Value): void,\n- ...\n };\n \n const Pending = 0;\ndiff --git a\/packages\/react-devtools-shared\/src\/devtools\/views\/Components\/NativeStyleEditor\/AutoSizeInput.js b\/packages\/react-devtools-shared\/src\/devtools\/views\/Components\/NativeStyleEditor\/AutoSizeInput.js\nindex c69108db7b..524e6d02cc 100644\n--- a\/packages\/react-devtools-shared\/src\/devtools\/views\/Components\/NativeStyleEditor\/AutoSizeInput.js\n+++ b\/packages\/react-devtools-shared\/src\/devtools\/views\/Components\/NativeStyleEditor\/AutoSizeInput.js\n@@ -16,7 +16,6 @@ type Props = {\n placeholder?: string,\n testName?: ?string,\n value: any,\n- ...\n };\n \n export default function AutoSizeInput({\ndiff --git a\/packages\/react-devtools-shared\/src\/devtools\/views\/Components\/OwnersStack.js b\/packages\/react-devtools-shared\/src\/devtools\/views\/Components\/OwnersStack.js\nindex d4e177e30a..0486b55c69 100644\n--- a\/packages\/react-devtools-shared\/src\/devtools\/views\/Components\/OwnersStack.js\n+++ b\/packages\/react-devtools-shared\/src\/devtools\/views\/Components\/OwnersStack.js\n@@ -202,7 +202,6 @@ type ElementsDropdownProps = {\n owners: Array,\n selectedIndex: number,\n selectOwner: SelectOwner,\n- ...\n };\n function ElementsDropdown({owners, selectOwner}: ElementsDropdownProps) {\n const store = useContext(StoreContext);\ndiff --git a\/packages\/react-devtools-shared\/src\/devtools\/views\/Profiler\/CommitRankedListItem.js b\/packages\/react-devtools-shared\/src\/devtools\/views\/Profiler\/CommitRankedListItem.js\nindex f1aafecb7e..4a8ab9b7e6 100644\n--- a\/packages\/react-devtools-shared\/src\/devtools\/views\/Profiler\/CommitRankedListItem.js\n+++ b\/packages\/react-devtools-shared\/src\/devtools\/views\/Profiler\/CommitRankedListItem.js\n@@ -21,7 +21,6 @@ type Props = {\n data: ItemData,\n index: number,\n style: Object,\n- ...\n };\n \n function CommitRankedListItem({data, index, style}: Props) {\ndiff --git a\/packages\/react-devtools-shared\/src\/hydration.js b\/packages\/react-devtools-shared\/src\/hydration.js\nindex f9834fcb41..6522076e7d 100644\n--- a\/packages\/react-devtools-shared\/src\/hydration.js\n+++ b\/packages\/react-devtools-shared\/src\/hydration.js\n@@ -427,7 +427,7 @@ export function hydrate(\n parent[last] = undefined;\n } else {\n \/\/ Replace the string keys with Symbols so they're non-enumerable.\n- const replaced: {[key: symbol]: boolean | string, ...} = {};\n+ const replaced: {[key: symbol]: boolean | string} = {};\n replaced[meta.inspectable] = !!value.inspectable;\n replaced[meta.inspected] = false;\n replaced[meta.name] = value.name;\ndiff --git a\/packages\/react-dom\/src\/client\/ReactDOMRoot.js b\/packages\/react-dom\/src\/client\/ReactDOMRoot.js\nindex 0e3579eb37..9b93ab6354 100644\n--- a\/packages\/react-dom\/src\/client\/ReactDOMRoot.js\n+++ b\/packages\/react-dom\/src\/client\/ReactDOMRoot.js\n@@ -35,15 +35,14 @@ export type RootType = {\n render(children: ReactNodeList): void,\n unmount(): void,\n _internalRoot: FiberRoot | null,\n- ...\n };\n+\n export type CreateRootOptions = {\n unstable_strictMode?: boolean,\n unstable_concurrentUpdatesByDefault?: boolean,\n unstable_transitionCallbacks?: TransitionTracingCallbacks,\n identifierPrefix?: string,\n onRecoverableError?: (error: mixed) => void,\n- ...\n };\n \n export type HydrateRootOptions = {\n@@ -57,7 +56,6 @@ export type HydrateRootOptions = {\n identifierPrefix?: string,\n onRecoverableError?: (error: mixed) => void,\n formState?: ReactFormState | null,\n- ...\n };\n \n import {\ndiff --git a\/packages\/shared\/ReactTypes.js b\/packages\/shared\/ReactTypes.js\nindex db44433e69..c4e790ce5d 100644\n--- a\/packages\/shared\/ReactTypes.js\n+++ b\/packages\/shared\/ReactTypes.js\n@@ -31,15 +31,12 @@ export type ReactProvider = {\n props: {\n value: T,\n children?: ReactNodeList,\n- ...\n },\n- ...\n };\n \n export type ReactProviderType = {\n $$typeof: symbol | number,\n _context: ReactContext,\n- ...\n };\n \n export type ReactConsumer = {\n@@ -49,9 +46,7 @@ export type ReactConsumer = {\n ref: null,\n props: {\n children: (value: T) => ReactNodeList,\n- ...\n },\n- ...\n };\n \n export type ReactContext = {\n@@ -71,7 +66,6 @@ export type ReactContext = {\n \/\/ only used by ServerContext\n _defaultValue: T,\n _globalName: string,\n- ...\n };\n \n export type ServerContextJSONValue =\n@@ -91,7 +85,6 @@ export type ReactPortal = {\n children: ReactNodeList,\n \/\/ TODO: figure out the API for cross-renderer implementation.\n implementation: any,\n- ...\n };\n \n export type RefObject = {\n@@ -104,7 +97,7 @@ export type ReactScope = {\n \n export type ReactScopeQuery = (\n type: string,\n- props: {[string]: mixed, ...},\n+ props: {[string]: mixed},\n instance: mixed,\n ) => boolean;\n \ndiff --git a\/scripts\/rollup\/shims\/react-native\/ReactNativeViewConfigRegistry.js b\/scripts\/rollup\/shims\/react-native\/ReactNativeViewConfigRegistry.js\nindex 704099ec6b..84a7082ea2 100644\n--- a\/scripts\/rollup\/shims\/react-native\/ReactNativeViewConfigRegistry.js\n+++ b\/scripts\/rollup\/shims\/react-native\/ReactNativeViewConfigRegistry.js\n@@ -22,13 +22,11 @@ export const customBubblingEventTypes: {\n skipBubbling?: ?boolean,\n }>,\n }>,\n- ...\n } = {};\n export const customDirectEventTypes: {\n [eventName: string]: $ReadOnly<{\n registrationName: string,\n }>,\n- ...\n } = {};\n \n const viewConfigCallbacks = new Map ViewConfig>();\n","files":[{"status":"M","path":"packages\/react-debug-tools\/src\/ReactDebugHooks.js"},{"status":"M","path":"packages\/react-devtools-core\/src\/backend.js"},{"status":"M","path":"packages\/react-devtools-shared\/src\/devtools\/cache.js"},{"status":"M","path":"packages\/react-devtools-shared\/src\/devtools\/views\/Components\/NativeStyleEditor\/AutoSizeInput.js"},{"status":"M","path":"packages\/react-devtools-shared\/src\/devtools\/views\/Components\/OwnersStack.js"},{"status":"M","path":"packages\/react-devtools-shared\/src\/devtools\/views\/Profiler\/CommitRankedListItem.js"},{"status":"M","path":"packages\/react-devtools-shared\/src\/hydration.js"},{"status":"M","path":"packages\/react-dom\/src\/client\/ReactDOMRoot.js"},{"status":"M","path":"packages\/shared\/ReactTypes.js"},{"status":"M","path":"scripts\/rollup\/shims\/react-native\/ReactNativeViewConfigRegistry.js"}]}

dillon1000/react

Files changed