dillon1000/react

Commit

Change warning() to automatically inject the stack, and add warningWithoutStack() as opt-out (#13161)

* Use %s in the console calls

* Add shared/warningWithStack

* Convert some warning callsites to warningWithStack

* Use warningInStack in shared utilities and remove unnecessary checks

* Replace more warning() calls with warningWithStack()

* Fixes after rebase + use warningWithStack in react

* Make warning have stack by default; warningWithoutStack opts out

* Forbid builds that may not use internals

* Revert newly added stacks

I changed my mind and want to keep this PR without functional changes. So we won't "fix" any warnings that are already missing stacks. We'll do it in follow-ups instead.

* Fix silly find/replace mistake

* Reorder imports

* Add protection against warning argument count mismatches

* Address review
Browse files
Changed paths59 files
First-parent comparison
M packages/create-subscription/src/createSubscription.js ModifiedM packages/events/EventPluginUtils.js ModifiedM packages/events/EventPropagators.js ModifiedM packages/events/ResponderTouchHistoryStore.js ModifiedM packages/events/SyntheticEvent.js ModifiedM packages/react-dom/src/client/ReactDOM.js ModifiedM packages/react-dom/src/client/ReactDOMFiberComponent.js ModifiedM packages/react-dom/src/client/ReactDOMFiberInput.js ModifiedM packages/react-dom/src/client/ReactDOMFiberOption.js ModifiedM packages/react-dom/src/client/ReactDOMFiberSelect.js ModifiedM packages/react-dom/src/client/ReactDOMFiberTextarea.js ModifiedM packages/react-dom/src/client/validateDOMNesting.js ModifiedM packages/react-dom/src/events/SimpleEventPlugin.js ModifiedM packages/react-dom/src/server/ReactPartialRenderer.js ModifiedM packages/react-dom/src/shared/CSSPropertyOperations.js ModifiedM packages/react-dom/src/shared/DOMProperty.js ModifiedM packages/react-dom/src/shared/ReactControlledValuePropTypes.js ModifiedM packages/react-dom/src/shared/ReactDOMInvalidARIAHook.js ModifiedM packages/react-dom/src/shared/ReactDOMNullInputValuePropHook.js ModifiedM packages/react-dom/src/shared/ReactDOMUnknownPropertyHook.js ModifiedM packages/react-dom/src/shared/assertValidProps.js ModifiedM packages/react-dom/src/shared/warnValidStyle.js ModifiedM packages/react-native-renderer/src/ReactFabric.js ModifiedM packages/react-native-renderer/src/ReactNativeEventEmitter.js ModifiedM packages/react-native-renderer/src/ReactNativeRenderer.js ModifiedM packages/react-reconciler/src/ReactChildFiber.js ModifiedM packages/react-reconciler/src/ReactFiberBeginWork.js ModifiedM packages/react-reconciler/src/ReactFiberClassComponent.js ModifiedM packages/react-reconciler/src/ReactFiberCommitWork.js ModifiedM packages/react-reconciler/src/ReactFiberContext.js ModifiedM packages/react-reconciler/src/ReactFiberDevToolsHook.js ModifiedM packages/react-reconciler/src/ReactFiberNewContext.js ModifiedM packages/react-reconciler/src/ReactFiberReconciler.js ModifiedM packages/react-reconciler/src/ReactFiberScheduler.js ModifiedM packages/react-reconciler/src/ReactFiberStack.js ModifiedM packages/react-reconciler/src/ReactFiberTreeReflection.js ModifiedM packages/react-reconciler/src/ReactProfilerTimer.js ModifiedM packages/react-reconciler/src/ReactStrictModeWarnings.js ModifiedM packages/react-reconciler/src/ReactUpdateQueue.js ModifiedM packages/react-reconciler/src/__tests__/ReactNewContext-test.internal.js ModifiedM packages/react-scheduler/src/ReactScheduler.js ModifiedM packages/react/src/ReactChildren.js ModifiedM packages/react/src/ReactContext.js ModifiedM packages/react/src/ReactElement.js ModifiedM packages/react/src/ReactElementValidator.js ModifiedM packages/react/src/ReactNoopUpdateQueue.js ModifiedM packages/react/src/forwardRef.js ModifiedM packages/shared/getComponentName.js ModifiedM packages/shared/lowPriorityWarning.js ModifiedM packages/shared/warning.js ModifiedA packages/shared/warningWithoutStack.js AddedM packages/simple-cache-provider/src/SimpleCacheProvider.js ModifiedM scripts/babel/__tests__/wrap-warning-with-env-check-test.js ModifiedM scripts/babel/wrap-warning-with-env-check.js ModifiedM scripts/eslint-rules/warning-and-invariant-args.js ModifiedM scripts/jest/matchers/__tests__/toWarnDev-test.js ModifiedM scripts/jest/matchers/toWarnDev.js ModifiedM scripts/rollup/forks.js ModifiedM scripts/rollup/plugins/use-forks-plugin.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…