{"body":"","parents":["7813cfa52cf4d2d298e755699698f30199eaac5c"],"patch":"diff --git a\/compiler\/.github\/workflows\/ci.yml b\/compiler\/.github\/workflows\/ci.yml\nindex 85e7592960..3f154bf6c5 100644\n--- a\/compiler\/.github\/workflows\/ci.yml\n+++ b\/compiler\/.github\/workflows\/ci.yml\n@@ -21,5 +21,7 @@ jobs:\n working-directory: forget\n - run: yarn build\n working-directory: forget\n+ - run: yarn lint\n+ working-directory: forget\n - run: yarn test\n working-directory: forget\ndiff --git a\/compiler\/forget\/.eslintrc.js b\/compiler\/forget\/.eslintrc.js\nindex 45040277cb..f00a91e235 100644\n--- a\/compiler\/forget\/.eslintrc.js\n+++ b\/compiler\/forget\/.eslintrc.js\n@@ -56,6 +56,7 @@ module.exports = {\n \"constructor\",\n ],\n \"@typescript-eslint\/array-type\": [\"off\", \"generic\"],\n+ \"@typescript-eslint\/triple-slash-reference\": \"off\",\n },\n parser: \"@typescript-eslint\/parser\",\n plugins: [\"@typescript-eslint\"],\ndiff --git a\/compiler\/forget\/src\/CompilerError.ts b\/compiler\/forget\/src\/CompilerError.ts\nindex 2695c0d7e1..af3343fc45 100644\n--- a\/compiler\/forget\/src\/CompilerError.ts\n+++ b\/compiler\/forget\/src\/CompilerError.ts\n@@ -125,7 +125,7 @@ export class CompilerError extends Error {\n \n override set message(_message: string) {}\n \n- override toString() {\n+ override toString(): string {\n return this.details.map((detail) => detail.toString()).join(\"\\n\\n\");\n }\n \ndiff --git a\/compiler\/forget\/src\/Inference\/AnalyseFunctions.ts b\/compiler\/forget\/src\/Inference\/AnalyseFunctions.ts\nindex 2a59edaf1a..42e9bd9f87 100644\n--- a\/compiler\/forget\/src\/Inference\/AnalyseFunctions.ts\n+++ b\/compiler\/forget\/src\/Inference\/AnalyseFunctions.ts\n@@ -43,7 +43,7 @@ class State {\n }\n }\n \n-export default function analyseFunctions(func: HIRFunction) {\n+export default function analyseFunctions(func: HIRFunction): void {\n const state = new State();\n \n for (const [_, block] of func.body.blocks) {\n@@ -73,7 +73,7 @@ export default function analyseFunctions(func: HIRFunction) {\n }\n }\n \n-function lower(func: HIRFunction) {\n+function lower(func: HIRFunction): void {\n mergeConsecutiveBlocks(func);\n enterSSA(func);\n eliminateRedundantPhi(func);\n@@ -85,7 +85,11 @@ function lower(func: HIRFunction) {\n logHIRFunction(\"AnalyseFunction (inner)\", func);\n }\n \n-function infer(value: FunctionExpression, state: State, context: Place[]) {\n+function infer(\n+ value: FunctionExpression,\n+ state: State,\n+ context: Place[]\n+): void {\n const mutations = new Set(\n value.loweredFunc.context\n .filter((dep) => isMutatedOrReassigned(dep.identifier))\n@@ -127,7 +131,7 @@ function infer(value: FunctionExpression, state: State, context: Place[]) {\n }\n }\n \n-function isMutatedOrReassigned(id: Identifier) {\n+function isMutatedOrReassigned(id: Identifier): boolean {\n \/\/ This check checks for mutation and reassingnment, so the usual check for\n \/\/ mutation (ie, `mutableRange.end - mutableRange.start > 1`) isn't quite\n \/\/ enough.\ndiff --git a\/compiler\/forget\/src\/Inference\/DropMemoCalls.ts b\/compiler\/forget\/src\/Inference\/DropMemoCalls.ts\nindex 8c9353b768..e2d25407b2 100644\n--- a\/compiler\/forget\/src\/Inference\/DropMemoCalls.ts\n+++ b\/compiler\/forget\/src\/Inference\/DropMemoCalls.ts\n@@ -1,6 +1,6 @@\n import { Effect, HIRFunction, HookType, isHookType } from \"..\/HIR\";\n \n-export default function (func: HIRFunction) {\n+export default function (func: HIRFunction): void {\n for (const [_, block] of func.body.blocks) {\n for (const instr of block.instructions) {\n switch (instr.value.kind) {\ndiff --git a\/compiler\/forget\/src\/Inference\/InferAlias.ts b\/compiler\/forget\/src\/Inference\/InferAlias.ts\nindex b2d127a7e3..7f37c0efab 100644\n--- a\/compiler\/forget\/src\/Inference\/InferAlias.ts\n+++ b\/compiler\/forget\/src\/Inference\/InferAlias.ts\n@@ -20,7 +20,10 @@ export function inferAliases(func: HIRFunction): DisjointSet {\n return aliases;\n }\n \n-function inferInstr(instr: Instruction, aliases: DisjointSet) {\n+function inferInstr(\n+ instr: Instruction,\n+ aliases: DisjointSet\n+): void {\n const { lvalue, value: instrValue } = instr;\n let alias: Place | null = null;\n switch (instrValue.kind) {\ndiff --git a\/compiler\/forget\/src\/Inference\/InferAliasForPhis.ts b\/compiler\/forget\/src\/Inference\/InferAliasForPhis.ts\nindex 0059cd3003..cd57bdef58 100644\n--- a\/compiler\/forget\/src\/Inference\/InferAliasForPhis.ts\n+++ b\/compiler\/forget\/src\/Inference\/InferAliasForPhis.ts\n@@ -10,7 +10,7 @@ import DisjointSet from \"..\/Utils\/DisjointSet\";\n export function inferAliasForPhis(\n func: HIRFunction,\n aliases: DisjointSet\n-) {\n+): void {\n for (const [_, block] of func.body.blocks) {\n for (const phi of block.phis) {\n const isPhiMutatedAfterCreation: boolean =\ndiff --git a\/compiler\/forget\/src\/Inference\/InferAliasForStores.ts b\/compiler\/forget\/src\/Inference\/InferAliasForStores.ts\nindex 1a3191ac15..ba787cbf2e 100644\n--- a\/compiler\/forget\/src\/Inference\/InferAliasForStores.ts\n+++ b\/compiler\/forget\/src\/Inference\/InferAliasForStores.ts\n@@ -20,7 +20,7 @@ import DisjointSet from \"..\/Utils\/DisjointSet\";\n export function inferAliasForStores(\n func: HIRFunction,\n aliases: DisjointSet\n-) {\n+): void {\n for (const [_, block] of func.body.blocks) {\n for (const instr of block.instructions) {\n const { value, lvalue } = instr;\ndiff --git a\/compiler\/forget\/src\/Inference\/InferMutableLifetimes.ts b\/compiler\/forget\/src\/Inference\/InferMutableLifetimes.ts\nindex 8f222815ea..f2b2ebd74a 100644\n--- a\/compiler\/forget\/src\/Inference\/InferMutableLifetimes.ts\n+++ b\/compiler\/forget\/src\/Inference\/InferMutableLifetimes.ts\n@@ -60,7 +60,7 @@ import { assertExhaustive } from \"..\/Utils\/utils\";\n * ```\n *\/\n \n-function infer(place: Place, instr: Instruction) {\n+function infer(place: Place, instr: Instruction): void {\n place.identifier.mutableRange.end = makeInstructionId(instr.id + 1);\n }\n \n@@ -68,7 +68,7 @@ function inferPlace(\n place: Place,\n instr: Instruction,\n inferMutableRangeForStores: boolean\n-) {\n+): void {\n switch (place.effect) {\n case Effect.Unknown: {\n throw new Error(\n@@ -98,7 +98,7 @@ function inferPlace(\n export function inferMutableLifetimes(\n func: HIRFunction,\n inferMutableRangeForStores: boolean\n-) {\n+): void {\n for (const [_, block] of func.body.blocks) {\n for (const phi of block.phis) {\n let start = Number.MAX_SAFE_INTEGER;\ndiff --git a\/compiler\/forget\/src\/Inference\/InferMutableRanges.ts b\/compiler\/forget\/src\/Inference\/InferMutableRanges.ts\nindex c5c168371f..cf6f0fa345 100644\n--- a\/compiler\/forget\/src\/Inference\/InferMutableRanges.ts\n+++ b\/compiler\/forget\/src\/Inference\/InferMutableRanges.ts\n@@ -12,7 +12,7 @@ import { inferAliasForStores } from \".\/InferAliasForStores\";\n import { inferMutableLifetimes } from \".\/InferMutableLifetimes\";\n import { inferMutableRangesForAlias } from \".\/InferMutableRangesForAlias\";\n \n-export function inferMutableRanges(ir: HIRFunction) {\n+export function inferMutableRanges(ir: HIRFunction): void {\n \/\/ Infer mutable ranges for non fields\n inferMutableLifetimes(ir, false);\n \ndiff --git a\/compiler\/forget\/src\/Inference\/InferMutableRangesForAlias.ts b\/compiler\/forget\/src\/Inference\/InferMutableRangesForAlias.ts\nindex 4de85bec4b..c38e93bc3b 100644\n--- a\/compiler\/forget\/src\/Inference\/InferMutableRangesForAlias.ts\n+++ b\/compiler\/forget\/src\/Inference\/InferMutableRangesForAlias.ts\n@@ -2,9 +2,9 @@ import { HIRFunction, Identifier, InstructionId } from \"..\/HIR\/HIR\";\n import DisjointSet from \"..\/Utils\/DisjointSet\";\n \n export function inferMutableRangesForAlias(\n- fn: HIRFunction,\n+ _fn: HIRFunction,\n aliases: DisjointSet\n-) {\n+): void {\n const aliasSets = aliases.buildSets();\n for (const aliasSet of aliasSets) {\n \/\/ Update mutableRange.end only if the identifiers have actually been\ndiff --git a\/compiler\/forget\/src\/Inference\/InferReferenceEffects.ts b\/compiler\/forget\/src\/Inference\/InferReferenceEffects.ts\nindex ef71ee4999..178ab940d4 100644\n--- a\/compiler\/forget\/src\/Inference\/InferReferenceEffects.ts\n+++ b\/compiler\/forget\/src\/Inference\/InferReferenceEffects.ts\n@@ -76,7 +76,7 @@ import { assertExhaustive } from \"..\/Utils\/utils\";\n * When control flow paths converge the types of values are merged together, with the value\n * types forming a lattice to ensure convergence.\n *\/\n-export default function inferReferenceEffects(fn: HIRFunction) {\n+export default function inferReferenceEffects(fn: HIRFunction): void {\n \/\/ Initial state contains function params\n \/\/ TODO: include module declarations here as well\n const initialState = InferenceState.empty();\n@@ -124,7 +124,7 @@ export default function inferReferenceEffects(fn: HIRFunction) {\n \/\/ so track the list of incoming state for each successor block.\n \/\/ These are merged when reaching that block again.\n const queuedStates: Map = new Map();\n- function queue(blockId: BlockId, state: InferenceState) {\n+ function queue(blockId: BlockId, state: InferenceState): void {\n let queuedState = queuedStates.get(blockId);\n if (queuedState != null) {\n \/\/ merge the queued states for this block\n@@ -187,7 +187,7 @@ class InferenceState {\n \/**\n * (Re)initializes a @param value with its default @param kind.\n *\/\n- initialize(value: InstructionValue, kind: ValueKind) {\n+ initialize(value: InstructionValue, kind: ValueKind): void {\n invariant(\n value.kind !== \"LoadLocal\",\n \"Expected all top-level identifiers to be defined as variables, not values\"\n@@ -225,7 +225,7 @@ class InferenceState {\n \/**\n * Updates the value at @param place to point to the same value as @param value.\n *\/\n- alias(place: Place, value: Place) {\n+ alias(place: Place, value: Place): void {\n const values = this.#variables.get(value.identifier.id);\n invariant(\n values != null,\n@@ -238,7 +238,7 @@ class InferenceState {\n \/**\n * Defines (initializing or updating) a variable with a specific kind of value.\n *\/\n- define(place: Place, value: InstructionValue) {\n+ define(place: Place, value: InstructionValue): void {\n invariant(\n this.#values.has(value),\n `Expected value to be initialized at '${printSourceLocation(value.loc)}'`\n@@ -262,7 +262,7 @@ class InferenceState {\n * Similarly, a freeze reference is converted to readonly if the\n * value is already frozen or is immutable.\n *\/\n- reference(place: Place, effectKind: Effect) {\n+ reference(place: Place, effectKind: Effect): void {\n const values = this.#variables.get(place.identifier.id);\n if (values === undefined) {\n place.effect = effectKind === Effect.Mutate ? Effect.Mutate : Effect.Read;\n@@ -442,7 +442,7 @@ class InferenceState {\n return result;\n }\n \n- inferPhi(phi: Phi) {\n+ inferPhi(phi: Phi): void {\n const values: Set = new Set();\n for (const [_, operand] of phi.operands) {\n const operandValues = this.#variables.get(operand.id);\n@@ -554,11 +554,10 @@ function mergeValues(a: ValueKind, b: ValueKind): ValueKind {\n * recording references on the @param state according to JS semantics.\n *\/\n function inferBlock(\n- env: Environment,\n-\n+ _env: Environment,\n state: InferenceState,\n block: BasicBlock\n-) {\n+): void {\n for (const phi of block.phis) {\n state.inferPhi(phi);\n }\n@@ -876,7 +875,7 @@ function inferBlock(\n function hasContextRefOperand(\n state: InferenceState,\n instrValue: InstructionValue\n-) {\n+): boolean {\n for (const place of eachInstructionValueOperand(instrValue)) {\n if (state.isDefined(place) && state.kind(place) === ValueKind.Context) {\n return true;\ndiff --git a\/compiler\/forget\/src\/Optimization\/ConstantPropagation.ts b\/compiler\/forget\/src\/Optimization\/ConstantPropagation.ts\nindex 66dffffa37..ac124fc2ad 100644\n--- a\/compiler\/forget\/src\/Optimization\/ConstantPropagation.ts\n+++ b\/compiler\/forget\/src\/Optimization\/ConstantPropagation.ts\n@@ -119,7 +119,7 @@ function applyConstantPropagation(fn: HIRFunction): boolean {\n const testValue = read(constants, terminal.test);\n if (testValue !== null) {\n hasChanges = true;\n- const targetBlockId = Boolean(testValue.value)\n+ const targetBlockId = testValue.value\n ? terminal.consequent\n : terminal.alternate;\n block.terminal = {\ndiff --git a\/compiler\/forget\/src\/Optimization\/DeadCodeElimination.ts b\/compiler\/forget\/src\/Optimization\/DeadCodeElimination.ts\nindex eefbe504bc..7c1e97d200 100644\n--- a\/compiler\/forget\/src\/Optimization\/DeadCodeElimination.ts\n+++ b\/compiler\/forget\/src\/Optimization\/DeadCodeElimination.ts\n@@ -60,7 +60,7 @@ export function deadCodeElimination(fn: HIRFunction): void {\n }\n for (const phi of block.phis) {\n if (used.has(phi.id)) {\n- for (const [pred, operand] of phi.operands) {\n+ for (const [_pred, operand] of phi.operands) {\n used.add(operand);\n }\n }\n@@ -196,7 +196,6 @@ function pruneableValue(\n case \"ArrayExpression\":\n case \"BinaryExpression\":\n case \"ComputedLoad\":\n- case \"ComputedStore\":\n case \"FunctionExpression\":\n case \"LoadLocal\":\n case \"JsxExpression\":\ndiff --git a\/compiler\/forget\/src\/ReactiveScopes\/CodegenReactiveFunction.ts b\/compiler\/forget\/src\/ReactiveScopes\/CodegenReactiveFunction.ts\nindex c4cde0a172..b1464ffe55 100644\n--- a\/compiler\/forget\/src\/ReactiveScopes\/CodegenReactiveFunction.ts\n+++ b\/compiler\/forget\/src\/ReactiveScopes\/CodegenReactiveFunction.ts\n@@ -498,9 +498,6 @@ function codegenInstruction(\n cx.temp.set(instr.lvalue.identifier.id, value);\n return t.emptyStatement();\n } else {\n- const kind = cx.hasDeclared(instr.lvalue.identifier)\n- ? InstructionKind.Reassign\n- : InstructionKind.Const;\n if (cx.hasDeclared(instr.lvalue.identifier)) {\n return createExpressionStatement(\n instr.loc,\ndiff --git a\/compiler\/forget\/src\/ReactiveScopes\/DeriveMinimalDependencies.ts b\/compiler\/forget\/src\/ReactiveScopes\/DeriveMinimalDependencies.ts\nindex d62ef4e168..fda29326a5 100644\n--- a\/compiler\/forget\/src\/ReactiveScopes\/DeriveMinimalDependencies.ts\n+++ b\/compiler\/forget\/src\/ReactiveScopes\/DeriveMinimalDependencies.ts\n@@ -1,5 +1,5 @@\n import invariant from \"invariant\";\n-import { Identifier, IdentifierId, ReactiveScopeDependency } from \"..\/HIR\";\n+import { Identifier, ReactiveScopeDependency } from \"..\/HIR\";\n import { printIdentifier } from \"..\/HIR\/PrintHIR\";\n import { assertExhaustive } from \"..\/Utils\/utils\";\n \n@@ -46,7 +46,7 @@ export class ReactiveScopeDependencyTree {\n return rootNode;\n }\n \n- add(dep: ReactiveScopeDependencyInfo) {\n+ add(dep: ReactiveScopeDependencyInfo): void {\n const path = dep.path ?? [];\n let currNode = this.#getOrCreateRoot(dep.identifier);\n \n@@ -102,7 +102,7 @@ export class ReactiveScopeDependencyTree {\n depsFromInnerScope: ReactiveScopeDependencyTree,\n innerScopeInConditionalWithinParent: boolean,\n checkValidDepIdFn: (id: Identifier) => boolean\n- ) {\n+ ): void {\n for (const [id, otherRoot] of depsFromInnerScope.#roots) {\n if (!checkValidDepIdFn(id)) {\n continue;\n@@ -119,7 +119,7 @@ export class ReactiveScopeDependencyTree {\n \n promoteDepsFromExhaustiveConditionals(\n trees: Array\n- ) {\n+ ): void {\n invariant(\n trees.length > 1,\n \"Expected trees to be at least 2 elements long.\"\n@@ -180,13 +180,13 @@ enum PropertyAccessType {\n UnconditionalDependency = \"UnconditionalDependency\",\n }\n \n-function isUnconditional(access: PropertyAccessType) {\n+function isUnconditional(access: PropertyAccessType): boolean {\n return (\n access === PropertyAccessType.UnconditionalAccess ||\n access === PropertyAccessType.UnconditionalDependency\n );\n }\n-function isDependency(access: PropertyAccessType) {\n+function isDependency(access: PropertyAccessType): boolean {\n return (\n access === PropertyAccessType.ConditionalDependency ||\n access === PropertyAccessType.UnconditionalDependency\n@@ -318,7 +318,7 @@ function deriveMinimalDependenciesInSubtree(\n * conditional equivalent, mutating subtree in place.\n * @param subtree unconditional node representing a subtree of dependencies\n *\/\n-function demoteSubtreeToConditional(subtree: DependencyNode) {\n+function demoteSubtreeToConditional(subtree: DependencyNode): void {\n const stack: Array = [subtree];\n \n let node;\n@@ -355,7 +355,7 @@ function addSubtree(\n currNode: DependencyNode,\n otherNode: DependencyNode,\n demoteOtherNode: boolean\n-) {\n+): void {\n let otherType = otherNode.accessType;\n if (demoteOtherNode) {\n otherType = isDependency(otherType)\n@@ -405,7 +405,7 @@ function addSubtree(\n function addSubtreeIntersection(\n otherProperties: Array>,\n currProperties: Map\n-) {\n+): void {\n invariant(\n otherProperties.length > 1,\n \"[DeriveMinimalDependencies] Expected otherProperties to be at least 2 elements long.\"\ndiff --git a\/compiler\/forget\/src\/ReactiveScopes\/InferReactiveIdentifiers.ts b\/compiler\/forget\/src\/ReactiveScopes\/InferReactiveIdentifiers.ts\nindex 3f1e020e9e..9cf3621d46 100644\n--- a\/compiler\/forget\/src\/ReactiveScopes\/InferReactiveIdentifiers.ts\n+++ b\/compiler\/forget\/src\/ReactiveScopes\/InferReactiveIdentifiers.ts\n@@ -29,7 +29,7 @@ class State {\n }\n \n class Visitor extends ReactiveFunctionVisitor {\n- override visitInstruction(instr: ReactiveInstruction, state: State) {\n+ override visitInstruction(instr: ReactiveInstruction, state: State): void {\n this.traverseInstruction(instr, state);\n const lval = instr.lvalue;\n if (lval == null) {\ndiff --git a\/compiler\/forget\/src\/ReactiveScopes\/PropagateScopeDependencies.ts b\/compiler\/forget\/src\/ReactiveScopes\/PropagateScopeDependencies.ts\nindex 0a2d34cc51..a97f87fe47 100644\n--- a\/compiler\/forget\/src\/ReactiveScopes\/PropagateScopeDependencies.ts\n+++ b\/compiler\/forget\/src\/ReactiveScopes\/PropagateScopeDependencies.ts\n@@ -158,7 +158,7 @@ class Context {\n *\/\n promoteDepsFromExhaustiveConditionals(\n depsInConditionals: Array\n- ) {\n+ ): void {\n this.#dependencies.promoteDepsFromExhaustiveConditionals(\n depsInConditionals\n );\n@@ -205,7 +205,7 @@ class Context {\n }\n \n \/\/ Checks if identifier is a valid dependency in the current scope\n- #checkValidDependencyId(identifier: Identifier) {\n+ #checkValidDependencyId(identifier: Identifier): boolean {\n \/\/ If this operand is used in a scope, has a dynamic value, and was defined\n \/\/ before this scope, then its a dependency of the scope.\n const currentDeclaration =\ndiff --git a\/compiler\/forget\/src\/SSA\/EliminateRedundantPhi.ts b\/compiler\/forget\/src\/SSA\/EliminateRedundantPhi.ts\nindex 48b3964b5f..b9e4c036fc 100644\n--- a\/compiler\/forget\/src\/SSA\/EliminateRedundantPhi.ts\n+++ b\/compiler\/forget\/src\/SSA\/EliminateRedundantPhi.ts\n@@ -27,7 +27,7 @@ import {\n * and phis rewrite all their identifiers based on this table. The algorithm loops over the CFG repeatedly\n * until there are no new rewrites: for a CFG without back-edges it completes in a single pass.\n *\/\n-export function eliminateRedundantPhi(fn: HIRFunction) {\n+export function eliminateRedundantPhi(fn: HIRFunction): void {\n const ir = fn.body;\n const rewrites: Map = new Map();\n \n@@ -111,7 +111,10 @@ export function eliminateRedundantPhi(fn: HIRFunction) {\n } while (rewrites.size > size && hasBackEdge);\n }\n \n-function rewritePlace(place: Place, rewrites: Map) {\n+function rewritePlace(\n+ place: Place,\n+ rewrites: Map\n+): void {\n const rewrite = rewrites.get(place.identifier);\n if (rewrite != null) {\n place.identifier = rewrite;\ndiff --git a\/compiler\/forget\/src\/TypeInference\/InferTypes.ts b\/compiler\/forget\/src\/TypeInference\/InferTypes.ts\nindex c33e9ec1ed..9fad30415c 100644\n--- a\/compiler\/forget\/src\/TypeInference\/InferTypes.ts\n+++ b\/compiler\/forget\/src\/TypeInference\/InferTypes.ts\n@@ -11,7 +11,7 @@ import {\n } from \"..\/HIR\/HIR\";\n import { eachInstructionLValue, eachInstructionOperand } from \"..\/HIR\/visitors\";\n \n-function isPrimitiveBinaryOp(op: t.BinaryExpression[\"operator\"]) {\n+function isPrimitiveBinaryOp(op: t.BinaryExpression[\"operator\"]): boolean {\n switch (op) {\n case \"+\":\n case \"-\":\n@@ -22,7 +22,6 @@ function isPrimitiveBinaryOp(op: t.BinaryExpression[\"operator\"]) {\n case \"&\":\n case \"|\":\n case \">>\":\n- case \">>\":\n case \"<<\":\n case \"^\":\n case \">\":\n@@ -36,7 +35,7 @@ function isPrimitiveBinaryOp(op: t.BinaryExpression[\"operator\"]) {\n }\n }\n \n-export default function (func: HIRFunction) {\n+export default function (func: HIRFunction): void {\n const unifier = new Unifier();\n for (const e of generate(func)) {\n unifier.unify(e.left, e.right);\n@@ -44,7 +43,7 @@ export default function (func: HIRFunction) {\n apply(func, unifier);\n }\n \n-function apply(func: HIRFunction, unifier: Unifier) {\n+function apply(func: HIRFunction, unifier: Unifier): void {\n for (const [_, block] of func.body.blocks) {\n for (const phi of block.phis) {\n phi.type = unifier.get(phi.type);\n@@ -169,7 +168,7 @@ type Substitution = Map;\n class Unifier {\n substitutions: Substitution = new Map();\n \n- unify(tA: Type, tB: Type) {\n+ unify(tA: Type, tB: Type): void {\n if (typeEquals(tA, tB)) {\n return;\n }\ndiff --git a\/compiler\/forget\/src\/Utils\/DisjointSet.ts b\/compiler\/forget\/src\/Utils\/DisjointSet.ts\nindex 3f66105a77..6c7fa69ed9 100644\n--- a\/compiler\/forget\/src\/Utils\/DisjointSet.ts\n+++ b\/compiler\/forget\/src\/Utils\/DisjointSet.ts\n@@ -80,7 +80,6 @@ export default class DisjointSet {\n canonicalize(): Map {\n const entries = new Map();\n for (const item of this.#entries.keys()) {\n- const parent = this.#entries.get(item)!;\n const root = this.find(item)!;\n entries.set(item, root);\n }\n","files":[{"status":"M","path":"compiler\/.github\/workflows\/ci.yml"},{"status":"M","path":"compiler\/forget\/.eslintrc.js"},{"status":"M","path":"compiler\/forget\/src\/CompilerError.ts"},{"status":"M","path":"compiler\/forget\/src\/Inference\/AnalyseFunctions.ts"},{"status":"M","path":"compiler\/forget\/src\/Inference\/DropMemoCalls.ts"},{"status":"M","path":"compiler\/forget\/src\/Inference\/InferAlias.ts"},{"status":"M","path":"compiler\/forget\/src\/Inference\/InferAliasForPhis.ts"},{"status":"M","path":"compiler\/forget\/src\/Inference\/InferAliasForStores.ts"},{"status":"M","path":"compiler\/forget\/src\/Inference\/InferMutableLifetimes.ts"},{"status":"M","path":"compiler\/forget\/src\/Inference\/InferMutableRanges.ts"},{"status":"M","path":"compiler\/forget\/src\/Inference\/InferMutableRangesForAlias.ts"},{"status":"M","path":"compiler\/forget\/src\/Inference\/InferReferenceEffects.ts"},{"status":"M","path":"compiler\/forget\/src\/Optimization\/ConstantPropagation.ts"},{"status":"M","path":"compiler\/forget\/src\/Optimization\/DeadCodeElimination.ts"},{"status":"M","path":"compiler\/forget\/src\/ReactiveScopes\/CodegenReactiveFunction.ts"},{"status":"M","path":"compiler\/forget\/src\/ReactiveScopes\/DeriveMinimalDependencies.ts"},{"status":"M","path":"compiler\/forget\/src\/ReactiveScopes\/InferReactiveIdentifiers.ts"},{"status":"M","path":"compiler\/forget\/src\/ReactiveScopes\/PropagateScopeDependencies.ts"},{"status":"M","path":"compiler\/forget\/src\/SSA\/EliminateRedundantPhi.ts"},{"status":"M","path":"compiler\/forget\/src\/TypeInference\/InferTypes.ts"},{"status":"M","path":"compiler\/forget\/src\/Utils\/DisjointSet.ts"}],"commit":{"shortRevision":"faa8eef0a8","authorName":"Lauren Tan","authoredAt":"2023-03-10T16:21:01-05:00","subject":"[be] Fix remaining lints and enable lint in CI","authorEmail":"poteto@users.noreply.github.com","revision":"faa8eef0a89666dad5fb489162d1fe0a1b5836aa"}}

dillon1000/react

Files changed