{"files":[{"path":"compiler\/forget\/src\/CompilerPipeline.ts","status":"M"},{"path":"compiler\/forget\/src\/HIR\/HIR.ts","status":"M"},{"path":"compiler\/forget\/src\/Inference\/DropMemoCalls.ts","status":"A"},{"path":"compiler\/forget\/src\/Inference\/index.ts","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/use-callback-simple.expect.md","status":"A"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/use-callback-simple.js","status":"A"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/useMemo-simple.expect.md","status":"A"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/useMemo-simple.js","status":"A"}],"body":"This drops the memo hook calls from the IR","commit":{"authorName":"Sathya Gunasekaran","authorEmail":"gsathya.ceg@gmail.com","revision":"fb8f293c321050817cb1c1fdb201cc33954d089b","authoredAt":"2023-02-14T23:07:19+00:00","subject":"[hir] Add a DropMemoCall pass","shortRevision":"fb8f293c32"},"parents":["e0562bbd51c8da906e62e34e335d2bacd48aba6e"],"patch":"diff --git a\/compiler\/forget\/src\/CompilerPipeline.ts b\/compiler\/forget\/src\/CompilerPipeline.ts\nindex 9807f6c212..cbd44e26b7 100644\n--- a\/compiler\/forget\/src\/CompilerPipeline.ts\n+++ b\/compiler\/forget\/src\/CompilerPipeline.ts\n@@ -14,6 +14,7 @@ import {\n } from \".\/HIR\";\n import {\n analyseFunctions,\n+ dropMemoCalls,\n inferMutableRanges,\n inferReferenceEffects,\n } from \".\/Inference\";\n@@ -65,6 +66,9 @@ export function* run(\n inferTypes(hir);\n yield log({ kind: \"hir\", name: \"InferTypes\", value: hir });\n \n+ dropMemoCalls(hir);\n+ yield log({ kind: \"hir\", name: \"DropMemoCalls\", value: hir });\n+\n analyseFunctions(hir);\n yield log({ kind: \"hir\", name: \"AnalyseFunctions\", value: hir });\n \ndiff --git a\/compiler\/forget\/src\/HIR\/HIR.ts b\/compiler\/forget\/src\/HIR\/HIR.ts\nindex 9da418c3cf..6126f6c5cc 100644\n--- a\/compiler\/forget\/src\/HIR\/HIR.ts\n+++ b\/compiler\/forget\/src\/HIR\/HIR.ts\n@@ -745,3 +745,7 @@ export function isObjectType(id: Identifier): boolean {\n export function isPrimitiveType(id: Identifier): boolean {\n return id.type.kind === \"Primitive\";\n }\n+\n+export function isHookType(id: Identifier): boolean {\n+ return id.type.kind === \"Hook\";\n+}\ndiff --git a\/compiler\/forget\/src\/Inference\/DropMemoCalls.ts b\/compiler\/forget\/src\/Inference\/DropMemoCalls.ts\nnew file mode 100644\nindex 0000000000..75b8fd5cd5\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/Inference\/DropMemoCalls.ts\n@@ -0,0 +1,60 @@\n+import invariant from \"invariant\";\n+import {\n+ Effect,\n+ HIRFunction,\n+ HookType,\n+ InstructionValue,\n+ isHookType,\n+} from \"..\/HIR\";\n+\n+export default function (func: HIRFunction) {\n+ for (const [_, block] of func.body.blocks) {\n+ for (const instr of block.instructions) {\n+ switch (instr.value.kind) {\n+ case \"CallExpression\": {\n+ if (isHookType(instr.value.callee.identifier)) {\n+ const name = (instr.value.callee.identifier.type as HookType).name;\n+ if (name === \"useMemo\") {\n+ const [fn] = instr.value.args;\n+\n+ \/\/ TODO(gsn): Consider inlining the function passed to useMemo,\n+ \/\/ rather than just calling it directly.\n+ \/\/\n+ \/\/ Replace the hook callee with the fn arg.\n+ \/\/\n+ \/\/ before:\n+ \/\/ foo = Call useMemo$2($9, $10)\n+ \/\/\n+ \/\/ after:\n+ \/\/ foo = Call $9()\n+ instr.value = {\n+ kind: \"CallExpression\",\n+ callee: fn,\n+ \/\/ Drop the args, including the deps array which DCE will remove\n+ \/\/ later.\n+ args: [],\n+ loc: instr.value.loc,\n+ };\n+ } else if (name === \"useCallback\") {\n+ const [fn] = instr.value.args;\n+\n+ \/\/ Instead of a Call, just alias the callback directly.\n+ \/\/\n+ \/\/ before:\n+ \/\/ foo = Call useCallback$8($19)\n+ \/\/\n+ \/\/ after:\n+ \/\/ foo = $19\n+ instr.value = {\n+ kind: \"Identifier\",\n+ identifier: fn.identifier,\n+ effect: Effect.Unknown,\n+ loc: instr.value.loc,\n+ };\n+ }\n+ }\n+ }\n+ }\n+ }\n+ }\n+}\ndiff --git a\/compiler\/forget\/src\/Inference\/index.ts b\/compiler\/forget\/src\/Inference\/index.ts\nindex 907516d3c9..a77861f352 100644\n--- a\/compiler\/forget\/src\/Inference\/index.ts\n+++ b\/compiler\/forget\/src\/Inference\/index.ts\n@@ -5,6 +5,7 @@\n * LICENSE file in the root directory of this source tree.\n *\/\n \n+export { default as dropMemoCalls } from \".\/DropMemoCalls\";\n export { inferMutableRanges } from \".\/InferMutableRanges\";\n export { default as analyseFunctions } from \".\/AnalyseFunctions\";\n export { default as inferReferenceEffects } from \".\/InferReferenceEffects\";\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/use-callback-simple.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/use-callback-simple.expect.md\nnew file mode 100644\nindex 0000000000..456784061e\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/use-callback-simple.expect.md\n@@ -0,0 +1,47 @@\n+\n+## Input\n+\n+```javascript\n+function component() {\n+ const [count, setCount] = useState(0);\n+ const increment = useCallback(() => setCount(count + 1));\n+\n+ return <\/Foo>;\n+}\n+\n+```\n+\n+## Code\n+\n+```javascript\n+function component() {\n+ const $ = React.unstable_useMemoCache();\n+ const t2 = useState(0);\n+ const count = t2[0];\n+ const setCount = t2[1];\n+ const c_0 = $[0] !== setCount;\n+ const c_1 = $[1] !== count;\n+ let t0;\n+ if (c_0 || c_1) {\n+ t0 = () => setCount(count + 1);\n+ $[0] = setCount;\n+ $[1] = count;\n+ $[2] = t0;\n+ } else {\n+ t0 = $[2];\n+ }\n+ const increment = t0;\n+ const c_3 = $[3] !== increment;\n+ let t1;\n+ if (c_3) {\n+ t1 = <\/Foo>;\n+ $[3] = increment;\n+ $[4] = t1;\n+ } else {\n+ t1 = $[4];\n+ }\n+ return t1;\n+}\n+\n+```\n+ \n\\ No newline at end of file\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/use-callback-simple.js b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/use-callback-simple.js\nnew file mode 100644\nindex 0000000000..132fcb30a2\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/use-callback-simple.js\n@@ -0,0 +1,6 @@\n+function component() {\n+ const [count, setCount] = useState(0);\n+ const increment = useCallback(() => setCount(count + 1));\n+\n+ return <\/Foo>;\n+}\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/useMemo-simple.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/useMemo-simple.expect.md\nnew file mode 100644\nindex 0000000000..76ee9099ad\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/useMemo-simple.expect.md\n@@ -0,0 +1,39 @@\n+\n+## Input\n+\n+```javascript\n+function component(a) {\n+ let x = useMemo(() => [a], [a]);\n+ return <\/Foo>;\n+}\n+\n+```\n+\n+## Code\n+\n+```javascript\n+function component(a) {\n+ const $ = React.unstable_useMemoCache();\n+ const c_0 = $[0] !== a;\n+ let x;\n+ if (c_0) {\n+ x = (() => [a])();\n+ $[0] = a;\n+ $[1] = x;\n+ } else {\n+ x = $[1];\n+ }\n+ const c_2 = $[2] !== x;\n+ let t0;\n+ if (c_2) {\n+ t0 = <\/Foo>;\n+ $[2] = x;\n+ $[3] = t0;\n+ } else {\n+ t0 = $[3];\n+ }\n+ return t0;\n+}\n+\n+```\n+ \n\\ No newline at end of file\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/useMemo-simple.js b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/useMemo-simple.js\nnew file mode 100644\nindex 0000000000..a680d099be\n--- \/dev\/null\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/useMemo-simple.js\n@@ -0,0 +1,4 @@\n+function component(a) {\n+ let x = useMemo(() => [a], [a]);\n+ return <\/Foo>;\n+}\n"}

dillon1000/react

Files changed