{"commit":{"authoredAt":"2019-08-22T23:58:16+01:00","subject":"[react-events] Ensure updateEventListeners updates in commit phase (#16540)","revision":"fc807720780962729df2ad1b0f53258603c020c7","shortRevision":"fc80772078","authorName":"Dominic Gannaway","authorEmail":"trueadm@users.noreply.github.com"},"files":[{"path":"packages\/react-art\/src\/ReactARTHostConfig.js","status":"M"},{"path":"packages\/react-dom\/src\/client\/ReactDOMHostConfig.js","status":"M"},{"path":"packages\/react-dom\/src\/events\/DOMEventResponderSystem.js","status":"M"},{"path":"packages\/react-dom\/src\/events\/__tests__\/DOMEventResponderSystem-test.internal.js","status":"M"},{"path":"packages\/react-native-renderer\/src\/ReactFabricHostConfig.js","status":"M"},{"path":"packages\/react-native-renderer\/src\/ReactNativeHostConfig.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberCommitWork.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberCompleteWork.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberEvents.js","status":"M"},{"path":"packages\/react-test-renderer\/src\/ReactTestHostConfig.js","status":"M"}],"parents":["0f6e3cd61cf4a5a1491bb3c92780936aebc2a146"],"patch":"diff --git a\/packages\/react-art\/src\/ReactARTHostConfig.js b\/packages\/react-art\/src\/ReactARTHostConfig.js\nindex 231ee89205..247086c64b 100644\n--- a\/packages\/react-art\/src\/ReactARTHostConfig.js\n+++ b\/packages\/react-art\/src\/ReactARTHostConfig.js\n@@ -432,7 +432,6 @@ export function mountResponderInstance(\n props: Object,\n state: Object,\n instance: Object,\n- rootContainerInstance: Object,\n ) {\n throw new Error('Not yet implemented.');\n }\ndiff --git a\/packages\/react-dom\/src\/client\/ReactDOMHostConfig.js b\/packages\/react-dom\/src\/client\/ReactDOMHostConfig.js\nindex bc2e94f802..6b95e63ac9 100644\n--- a\/packages\/react-dom\/src\/client\/ReactDOMHostConfig.js\n+++ b\/packages\/react-dom\/src\/client\/ReactDOMHostConfig.js\n@@ -824,10 +824,9 @@ export function mountResponderInstance(\n responderProps: Object,\n responderState: Object,\n instance: Instance,\n- rootContainerInstance: Container,\n ): ReactDOMEventResponderInstance {\n \/\/ Listen to events\n- const doc = rootContainerInstance.ownerDocument;\n+ const doc = instance.ownerDocument;\n const documentBody = doc.body || doc;\n const {\n rootEventTypes,\ndiff --git a\/packages\/react-dom\/src\/events\/DOMEventResponderSystem.js b\/packages\/react-dom\/src\/events\/DOMEventResponderSystem.js\nindex e6db323c63..267b9ce63b 100644\n--- a\/packages\/react-dom\/src\/events\/DOMEventResponderSystem.js\n+++ b\/packages\/react-dom\/src\/events\/DOMEventResponderSystem.js\n@@ -12,7 +12,7 @@ import {\n PASSIVE_NOT_SUPPORTED,\n } from 'legacy-events\/EventSystemFlags';\n import type {AnyNativeEvent} from 'legacy-events\/PluginModuleType';\n-import {HostComponent} from 'shared\/ReactWorkTags';\n+import {HostComponent, SuspenseComponent} from 'shared\/ReactWorkTags';\n import type {EventPriority} from 'shared\/ReactTypes';\n import type {\n ReactDOMEventResponder,\n@@ -32,10 +32,6 @@ import type {Fiber} from 'react-reconciler\/src\/ReactFiber';\n import warning from 'shared\/warning';\n import {enableFlareAPI} from 'shared\/ReactFeatureFlags';\n import invariant from 'shared\/invariant';\n-import {\n- isFiberSuspenseAndTimedOut,\n- getSuspenseFallbackChild,\n-} from 'react-reconciler\/src\/ReactFiberEvents';\n \n import {getClosestInstanceFromNode} from '..\/client\/ReactDOMComponentTree';\n import {\n@@ -630,6 +626,14 @@ function validateResponderContext(): void {\n );\n }\n \n+function isFiberSuspenseAndTimedOut(fiber: Fiber): boolean {\n+ return fiber.tag === SuspenseComponent && fiber.memoizedState !== null;\n+}\n+\n+function getSuspenseFallbackChild(fiber: Fiber): Fiber | null {\n+ return ((((fiber.child: any): Fiber).sibling: any): Fiber).child;\n+}\n+\n export function dispatchEventForResponderEventSystem(\n topLevelType: string,\n targetFiber: null | Fiber,\ndiff --git a\/packages\/react-dom\/src\/events\/__tests__\/DOMEventResponderSystem-test.internal.js b\/packages\/react-dom\/src\/events\/__tests__\/DOMEventResponderSystem-test.internal.js\nindex 80f3a0a492..6eaaec4505 100644\n--- a\/packages\/react-dom\/src\/events\/__tests__\/DOMEventResponderSystem-test.internal.js\n+++ b\/packages\/react-dom\/src\/events\/__tests__\/DOMEventResponderSystem-test.internal.js\n@@ -14,6 +14,7 @@ let ReactFeatureFlags;\n let ReactDOM;\n let ReactDOMServer;\n let ReactTestRenderer;\n+let Scheduler;\n \n \/\/ FIXME: What should the public API be for setting an event's priority? Right\n \/\/ now it's an enum but is that what we want? Hard coding this for now.\n@@ -72,6 +73,7 @@ describe('DOMEventResponderSystem', () => {\n React = require('react');\n ReactDOM = require('react-dom');\n ReactDOMServer = require('react-dom\/server');\n+ Scheduler = require('scheduler');\n container = document.createElement('div');\n document.body.appendChild(container);\n });\n@@ -811,8 +813,8 @@ describe('DOMEventResponderSystem', () => {\n \n it('the event responder system should warn on accessing invalid properties', () => {\n const TestResponder = createEventResponder({\n- rootEventTypes: ['click'],\n- onRootEvent: (event, context, props) => {\n+ targetEventTypes: ['click'],\n+ onEvent: (event, context, props) => {\n const syntheticEvent = {\n target: event.target,\n type: 'click',\n@@ -823,19 +825,24 @@ describe('DOMEventResponderSystem', () => {\n });\n \n let handler;\n+ let buttonRef = React.createRef();\n const Test = () => {\n const listener = React.unstable_useResponder(TestResponder, {\n onClick: handler,\n });\n \n- return

dillon1000/react

Files changed