dillon1000/react

Commit

Don't fire the render phase update warning for class lifecycles (#18330)

* Change the warning to not say "function body"

This warning is more generic and may happen with class components too.

* Dedupe by the rendering component

* Don't warn outside of render
Browse files
Dan Abramov authored fe1f79b95b5987b7179d1eaf5ff5bb9a7bc4b7b5 Parent 22cab1c
Changed paths5 files
First-parent comparison
M packages/react-dom/src/__tests__/ReactCompositeComponent-test.js ModifiedM packages/react-reconciler/src/ReactFiberBeginWork.js ModifiedM packages/react-reconciler/src/ReactFiberWorkLoop.js ModifiedM packages/react-reconciler/src/__tests__/ReactHooks-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactHooksWithNoopRenderer-test.internal.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…