dillon1000/react

Commit

Fix usage of console.error to prevent transform (#24188)

We were suppressing the `react-internals/warning-args` lint rule
for the call to `console.error` in `defaultOnRecoverableError`.

As far as I could tell, the lint rule exists because on dev builds,
we replace all calls to `console.error` with [this error
function](https://github.com/facebook/react/blob/main/packages/shared/consoleWithStackDev.js#L31-L37)
which expects a format string + args and nothing else. We were trying
to pass in an `Error` object directly. After this commit's change,
we will still be passing an `Error` but the transform won't occur.
Browse files
Changed paths1 file
First-parent comparison
M packages/react-dom/src/client/ReactDOMRoot.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…