dillon1000/react

Commit

Fix promotion of catch bindings w/in function expressions

One of our visitors wasn't visiting TryTerminal's handlerBinding, which meant 
that we missed renaming those identifiers in RenameVariables. I also updated the 
printers to print this binding.
Browse files
Joe Savona authored fe91bcefd2bbc3da9f1998befb466acc8b4afdca Parent 449aa70
Changed paths13 files
First-parent comparison
M compiler/packages/babel-plugin-react-forget/src/HIR/PrintHIR.ts ModifiedM compiler/packages/babel-plugin-react-forget/src/HIR/visitors.ts ModifiedM compiler/packages/babel-plugin-react-forget/src/ReactiveScopes/PrintReactiveFunction.ts ModifiedM compiler/packages/babel-plugin-react-forget/src/ReactiveScopes/visitors.ts ModifiedD compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-try-catch-within-function-expression.expect.md DeletedA compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/try-catch-within-function-expression-returns-caught-value.expect.md AddedA compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/try-catch-within-function-expression-returns-caught-value.js AddedA compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/try-catch-within-function-expression.expect.md AddedR compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-try-catch-within-function-expression.js →compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/try-catch-within-function-expression.js RenamedA compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/try-catch-within-object-method-returns-caught-value.expect.md AddedA compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/try-catch-within-object-method-returns-caught-value.js AddedA compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/try-catch-within-object-method.expect.md AddedA compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/try-catch-within-object-method.js Added
Patch

Files changed

Rendering syntax-highlighted changes…