{"commit":{"authoredAt":"2024-02-05T17:12:40+00:00","revision":"09c0769448655deaf69e2bf65eecc74268fda02a","subject":"chore: use versioned render in console test (#28213)","authorEmail":"rdlesyutin@gmail.com","authorName":"Ruslan Lesiutin","shortRevision":"09c0769448"},"parents":["f244fd3884adbe5717b7e46da18911e9899cade9"],"files":[{"status":"M","path":"packages\/react-devtools-shared\/src\/__tests__\/console-test.js"}],"body":"","patch":"diff --git a\/packages\/react-devtools-shared\/src\/__tests__\/console-test.js b\/packages\/react-devtools-shared\/src\/__tests__\/console-test.js\nindex e70c8e3a0a..e2674b10f3 100644\n--- a\/packages\/react-devtools-shared\/src\/__tests__\/console-test.js\n+++ b\/packages\/react-devtools-shared\/src\/__tests__\/console-test.js\n@@ -7,13 +7,12 @@\n * @flow\n *\/\n \n-import {normalizeCodeLocInfo} from '.\/utils';\n+import {getVersionedRenderImplementation, normalizeCodeLocInfo} from '.\/utils';\n \n let React;\n let ReactDOMClient;\n let act;\n let fakeConsole;\n-let legacyRender;\n let mockError;\n let mockInfo;\n let mockGroup;\n@@ -67,9 +66,10 @@ describe('console', () => {\n \n const utils = require('.\/utils');\n act = utils.act;\n- legacyRender = utils.legacyRender;\n });\n \n+ const {render} = getVersionedRenderImplementation();\n+\n \/\/ @reactVersion >=18.0\n it('should not patch console methods that are not explicitly overridden', () => {\n expect(fakeConsole.error).not.toBe(mockError);\n@@ -185,7 +185,7 @@ describe('console', () => {\n return null;\n };\n \n- act(() => legacyRender(, document.createElement('div')));\n+ act(() => render());\n \n expect(mockWarn).toHaveBeenCalledTimes(1);\n expect(mockWarn.mock.calls[0]).toHaveLength(1);\n@@ -215,7 +215,7 @@ describe('console', () => {\n return null;\n };\n \n- act(() => legacyRender(, document.createElement('div')));\n+ act(() => render());\n \n expect(mockLog).toHaveBeenCalledTimes(1);\n expect(mockLog.mock.calls[0]).toHaveLength(1);\n@@ -256,7 +256,7 @@ describe('console', () => {\n return null;\n };\n \n- act(() => legacyRender(, document.createElement('div')));\n+ act(() => render());\n \n expect(mockLog).toHaveBeenCalledTimes(2);\n expect(mockLog.mock.calls[0]).toHaveLength(1);\n@@ -313,9 +313,8 @@ describe('console', () => {\n }\n }\n \n- const container = document.createElement('div');\n- act(() => legacyRender(, container));\n- act(() => legacyRender(, container));\n+ act(() => render());\n+ act(() => render());\n \n expect(mockLog).toHaveBeenCalledTimes(2);\n expect(mockLog.mock.calls[0]).toHaveLength(1);\n@@ -367,7 +366,7 @@ describe('console', () => {\n }\n }\n \n- act(() => legacyRender(, document.createElement('div')));\n+ act(() => render());\n \n expect(mockLog).toHaveBeenCalledTimes(1);\n expect(mockLog.mock.calls[0]).toHaveLength(1);\n@@ -396,7 +395,7 @@ describe('console', () => {\n return null;\n };\n \n- act(() => legacyRender(, document.createElement('div')));\n+ act(() => render());\n \n expect(mockWarn).toHaveBeenCalledTimes(1);\n expect(mockWarn.mock.calls[0]).toHaveLength(1);\n@@ -410,7 +409,7 @@ describe('console', () => {\n breakOnConsoleErrors: false,\n showInlineWarningsAndErrors: false,\n });\n- act(() => legacyRender(, document.createElement('div')));\n+ act(() => render());\n \n expect(mockWarn).toHaveBeenCalledTimes(2);\n expect(mockWarn.mock.calls[1]).toHaveLength(2);\n@@ -457,7 +456,7 @@ describe('console', () => {\n return null;\n };\n \n- act(() => legacyRender(, document.createElement('div')));\n+ act(() => render());\n \n expect(mockLog).toHaveBeenCalledTimes(1);\n expect(mockLog.mock.calls[0]).toHaveLength(1);\n@@ -483,7 +482,7 @@ describe('console', () => {\n return null;\n };\n \n- act(() => legacyRender(, document.createElement('div')));\n+ act(() => render());\n \n expect(mockWarn).toHaveBeenCalledTimes(1);\n expect(mockWarn.mock.calls[0][0]).toBe('Symbol:');\n@@ -824,7 +823,6 @@ describe('console error', () => {\n \n const utils = require('.\/utils');\n act = utils.act;\n- legacyRender = utils.legacyRender;\n });\n \n \/\/ @reactVersion >=18.0\n"}

dillon1000/react

Files changed