{"parents":["21ac62c77ac68c66b2a1f0adcc60f7760b884a0e"],"body":"","commit":{"authorEmail":"dan.abramov@gmail.com","shortRevision":"82c7ca4cca","authorName":"Dan Abramov","subject":"Add component stacks to some warnings (#13218)","revision":"82c7ca4cca90976cd1230e03ea1a4372a4276e67","authoredAt":"2018-07-17T20:15:03+01:00"},"files":[{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactDOMComponent-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactDOMInput-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactDOMSelect-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationAttributes-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationElements-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactDOMTextarea-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactServerRendering-test.js"},{"status":"M","path":"packages\/react-dom\/src\/client\/ReactDOMFiberComponent.js"},{"status":"M","path":"packages\/react-dom\/src\/client\/ReactDOMFiberInput.js"},{"status":"M","path":"packages\/react-dom\/src\/client\/ReactDOMFiberOption.js"},{"status":"M","path":"packages\/react-dom\/src\/client\/ReactDOMFiberSelect.js"},{"status":"M","path":"packages\/react-dom\/src\/client\/ReactDOMFiberTextarea.js"},{"status":"M","path":"packages\/react-dom\/src\/server\/ReactPartialRenderer.js"},{"status":"M","path":"packages\/react-dom\/src\/shared\/DOMProperty.js"},{"status":"M","path":"packages\/react-dom\/src\/shared\/ReactDOMUnknownPropertyHook.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberBeginWork.js"},{"status":"M","path":"packages\/react-reconciler\/src\/__tests__\/ReactNewContext-test.internal.js"}],"patch":"diff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMComponent-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMComponent-test.js\nindex 08a83ace2e..441545fc0a 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMComponent-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMComponent-test.js\n@@ -567,7 +567,6 @@ describe('ReactDOMComponent', () => {\n }\n }).toWarnDev(\n 'Warning: Invalid attribute name: `blah\" onclick=\"beevil\" noise=\"hi`',\n- {withoutStack: true}, \/\/ TODO: add a stack\n );\n });\n \n@@ -587,7 +586,6 @@ describe('ReactDOMComponent', () => {\n }\n }).toWarnDev(\n 'Warning: Invalid attribute name: `blah\" onclick=\"beevil\" noise=\"hi`',\n- {withoutStack: true}, \/\/ TODO: add a stack\n );\n });\n \n@@ -1006,7 +1004,6 @@ describe('ReactDOMComponent', () => {\n '
is using incorrect casing. ' +\n 'Use PascalCase for React components, ' +\n 'or lowercase for HTML elements.',\n- {withoutStack: true}, \/\/ TODO: add a stack\n );\n expect(returnedValue).not.toContain('<\/BR>');\n });\n@@ -1023,7 +1020,6 @@ describe('ReactDOMComponent', () => {\n ' is using incorrect casing. ' +\n 'Use PascalCase for React components, ' +\n 'or lowercase for HTML elements.',\n- {withoutStack: true}, \/\/ TODO: add a stack\n );\n });\n \n@@ -1033,7 +1029,6 @@ describe('ReactDOMComponent', () => {\n ).toWarnDev(\n 'The `aria` attribute is reserved for future use in React. ' +\n 'Pass individual `aria-` attributes instead.',\n- {withoutStack: true}, \/\/ TODO: add a stack\n );\n });\n \n@@ -1056,12 +1051,10 @@ describe('ReactDOMComponent', () => {\n \n expect(() => ReactTestUtils.renderIntoDocument()).toWarnDev(\n 'The tag is unrecognized in this browser',\n- {withoutStack: true}, \/\/ TODO: add a stack\n );\n \/\/ Test deduplication\n expect(() => ReactTestUtils.renderIntoDocument()).toWarnDev(\n 'The tag is unrecognized in this browser',\n- {withoutStack: true}, \/\/ TODO: add a stack\n );\n ReactTestUtils.renderIntoDocument();\n \/\/ This is a funny case.\n@@ -1073,15 +1066,12 @@ describe('ReactDOMComponent', () => {\n \/\/ Corner case. Make sure out deduplication logic doesn't break with weird tag.\n expect(() =>\n ReactTestUtils.renderIntoDocument(),\n- ).toWarnDev(\n- [\n- ' is using incorrect casing. ' +\n- 'Use PascalCase for React components, ' +\n- 'or lowercase for HTML elements.',\n- 'The tag is unrecognized in this browser',\n- ],\n- {withoutStack: true}, \/\/ TODO: add a stack\n- );\n+ ).toWarnDev([\n+ ' is using incorrect casing. ' +\n+ 'Use PascalCase for React components, ' +\n+ 'or lowercase for HTML elements.',\n+ 'The tag is unrecognized in this browser',\n+ ]);\n } finally {\n Object.prototype.toString = realToString; \/\/ eslint-disable-line no-extend-native\n }\n@@ -1140,7 +1130,6 @@ describe('ReactDOMComponent', () => {\n expect(() => ReactDOM.render(, node)).toWarnDev(\n 'ShadyComponent is using shady DOM. Using shady DOM with React can ' +\n 'cause things to break subtly.',\n- {withoutStack: true}, \/\/ TODO: add a stack\n );\n mountComponent({is: 'custom-shady-div2'});\n } finally {\n@@ -1161,7 +1150,6 @@ describe('ReactDOMComponent', () => {\n expect(() => mountComponent({is: 'custom-shady-div'})).toWarnDev(\n 'A component is using shady DOM. Using shady DOM with React can ' +\n 'cause things to break subtly.',\n- {withoutStack: true}, \/\/ TODO: add a stack\n );\n \n \/\/ No additional warnings are expected\n@@ -1209,17 +1197,13 @@ describe('ReactDOMComponent', () => {\n it('should validate against use of innerHTML', () => {\n expect(() =>\n mountComponent({innerHTML: 'Hi Jim!<\/span>'}),\n- ).toWarnDev('Directly setting property `innerHTML` is not permitted. ', {\n- withoutStack: true, \/\/ TODO: add a stack\n- });\n+ ).toWarnDev('Directly setting property `innerHTML` is not permitted. ');\n });\n \n it('should validate against use of innerHTML without case sensitivity', () => {\n expect(() =>\n mountComponent({innerhtml: 'Hi Jim!<\/span>'}),\n- ).toWarnDev('Directly setting property `innerHTML` is not permitted. ', {\n- withoutStack: true, \/\/ TODO: add a stack\n- });\n+ ).toWarnDev('Directly setting property `innerHTML` is not permitted. ');\n });\n \n it('should validate use of dangerouslySetInnerHTML', () => {\n@@ -1812,13 +1796,11 @@ describe('ReactDOMComponent', () => {\n ReactTestUtils.renderIntoDocument(

{}} \/>),\n ).toWarnDev(\n 'React uses onFocus and onBlur instead of onFocusIn and onFocusOut.',\n- {withoutStack: true}, \/\/ TODO: add a stack\n );\n expect(() =>\n ReactTestUtils.renderIntoDocument(

{}} \/>),\n ).toWarnDev(\n 'React uses onFocus and onBlur instead of onFocusIn and onFocusOut.',\n- {withoutStack: true}, \/\/ TODO: add a stack\n );\n });\n \n@@ -1828,13 +1810,11 @@ describe('ReactDOMComponent', () => {\n ReactTestUtils.renderIntoDocument(

{}} \/>),\n ).toWarnDev(\n 'React uses onFocus and onBlur instead of onFocusIn and onFocusOut.',\n- {withoutStack: true}, \/\/ TODO: add a stack\n );\n });\n \n@@ -1844,13 +1824,11 @@ describe('ReactDOMComponent', () => {\n ReactDOMServer.renderToString(

{}} \/>),\n ).toWarnDev(\n 'React uses onFocus and onBlur instead of onFocusIn and onFocusOut.',\n- {withoutStack: true}, \/\/ TODO: add a stack\n );\n expect(() =>\n ReactDOMServer.renderToString(

{}} \/>),\n ).toWarnDev(\n 'React uses onFocus and onBlur instead of onFocusIn and onFocusOut.',\n- {withoutStack: true}, \/\/ TODO: add a stack\n );\n });\n \n@@ -1860,13 +1838,11 @@ describe('ReactDOMComponent', () => {\n ReactDOMServer.renderToString(

{}} \/>),\n ).toWarnDev(\n 'React uses onFocus and onBlur instead of onFocusIn and onFocusOut.',\n- {withoutStack: true}, \/\/ TODO: add a stack\n );\n expect(() =>\n ReactDOMServer.renderToString(

{}} \/>),\n ).toWarnDev(\n 'React uses onFocus and onBlur instead of onFocusIn and onFocusOut.',\n- {withoutStack: true}, \/\/ TODO: add a stack\n );\n });\n \ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMInput-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMInput-test.js\nindex aaa2083934..480287cfc0 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMInput-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMInput-test.js\n@@ -930,7 +930,6 @@ describe('ReactDOMInput', () => {\n 'both). Decide between using a controlled or uncontrolled input ' +\n 'element and remove one of these props. More info: ' +\n 'https:\/\/fb.me\/react-controlled-components',\n- {withoutStack: true}, \/\/ TODO: add a stack\n );\n ReactDOM.unmountComponentAtNode(container);\n \n@@ -958,7 +957,6 @@ describe('ReactDOMInput', () => {\n 'both). Decide between using a controlled or uncontrolled input ' +\n 'element and remove one of these props. More info: ' +\n 'https:\/\/fb.me\/react-controlled-components',\n- {withoutStack: true}, \/\/ TODO: add a stack\n );\n ReactDOM.unmountComponentAtNode(container);\n \ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMSelect-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMSelect-test.js\nindex 8ed6f32d0f..5548c03931 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMSelect-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMSelect-test.js\n@@ -566,25 +566,21 @@ describe('ReactDOMSelect', () => {\n });\n \n it('should warn if selected is set on

dillon1000/react

Files changed