dillon1000/react

Commit

Inlined DevTools event emitter impl (#18378)

DevTools previously used the NPM events package for dispatching events. This package has an unfortunate flaw though- if a listener throws during event dispatch, no subsequent listeners are called. I've replaced that event dispatcher with my own implementation that ensures all listeners are called before it re-throws an error.

This commit replaces that event emitter with a custom implementation that calls all listeners before re-throwing an error.
Browse files
Changed paths8 files
First-parent comparison
M packages/react-devtools-shared/package.json ModifiedA packages/react-devtools-shared/src/__tests__/events-test.js AddedM packages/react-devtools-shared/src/backend/agent.js ModifiedM packages/react-devtools-shared/src/bridge.js ModifiedM packages/react-devtools-shared/src/devtools/ProfilerStore.js ModifiedM packages/react-devtools-shared/src/devtools/store.js ModifiedA packages/react-devtools-shared/src/events.js AddedM scripts/flow/react-devtools.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…